Re: [PATCH] hw/arm/boot: Use the IEC binary prefix definitions

2019-09-23 Thread Thomas Huth
On 21/09/2019 12.34, Philippe Mathieu-Daudé wrote: > IEC binary prefixes ease code review: the unit is explicit. > > Signed-off-by: Philippe Mathieu-Daudé > --- > hw/arm/boot.c | 8 > 1 file changed, 4 insertions(+), 4 deletions(-) > > diff --git a/hw/arm/boot.c b/hw/arm/boot.c > index

Re: [PATCH] hw/arm/boot: Use the IEC binary prefix definitions

2019-09-23 Thread Stefano Garzarella
On Mon, Sep 23, 2019 at 10:43:12AM +0200, Philippe Mathieu-Daudé wrote: > On 9/23/19 10:29 AM, Stefano Garzarella wrote: > > On Sat, Sep 21, 2019 at 12:34:04PM +0200, Philippe Mathieu-Daudé wrote: > >> IEC binary prefixes ease code review: the unit is explicit. > >> > >> Signed-off-by: Philippe Mat

Re: [PATCH] hw/arm/boot: Use the IEC binary prefix definitions

2019-09-23 Thread Philippe Mathieu-Daudé
On 9/23/19 10:29 AM, Stefano Garzarella wrote: > On Sat, Sep 21, 2019 at 12:34:04PM +0200, Philippe Mathieu-Daudé wrote: >> IEC binary prefixes ease code review: the unit is explicit. >> >> Signed-off-by: Philippe Mathieu-Daudé >> --- >> hw/arm/boot.c | 8 >> 1 file changed, 4 insertions

Re: [PATCH] hw/arm/boot: Use the IEC binary prefix definitions

2019-09-23 Thread Stefano Garzarella
On Sat, Sep 21, 2019 at 12:34:04PM +0200, Philippe Mathieu-Daudé wrote: > IEC binary prefixes ease code review: the unit is explicit. > > Signed-off-by: Philippe Mathieu-Daudé > --- > hw/arm/boot.c | 8 > 1 file changed, 4 insertions(+), 4 deletions(-) > > diff --git a/hw/arm/boot.c b/

Re: [PATCH] hw/arm/boot: Use the IEC binary prefix definitions

2019-09-21 Thread Richard Henderson
On 9/21/19 3:34 AM, Philippe Mathieu-Daudé wrote: > IEC binary prefixes ease code review: the unit is explicit. > > Signed-off-by: Philippe Mathieu-Daudé > --- > hw/arm/boot.c | 8 > 1 file changed, 4 insertions(+), 4 deletions(-) Reviewed-by: Richard Henderson r~

[PATCH] hw/arm/boot: Use the IEC binary prefix definitions

2019-09-21 Thread Philippe Mathieu-Daudé
IEC binary prefixes ease code review: the unit is explicit. Signed-off-by: Philippe Mathieu-Daudé --- hw/arm/boot.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/hw/arm/boot.c b/hw/arm/boot.c index bf97ef3e33..59bb2fa0d3 100644 --- a/hw/arm/boot.c +++ b/hw/arm/boot.