Re: [PATCH] hw/acpi: changes towards enabling -Wshadow=local

2023-09-29 Thread Markus Armbruster
Ani Sinha writes: > Your shadow-next has no changes. Have you not pushed to that branch? I did, but only after I was done updating patches. Intend to post my pull request shortly.

Re: [PATCH] hw/acpi: changes towards enabling -Wshadow=local

2023-09-29 Thread Ani Sinha
> On 29-Sep-2023, at 1:32 PM, Markus Armbruster wrote: > > Ani Sinha writes: > >>> On 29-Sep-2023, at 11:43 AM, Markus Armbruster wrote: >>> >>> Ani Sinha writes: >>> > On 29-Sep-2023, at 11:17 AM, Markus Armbruster wrote: > > Ani Sinha writes: > >> Code changes i

Re: [PATCH] hw/acpi: changes towards enabling -Wshadow=local

2023-09-29 Thread Markus Armbruster
Ani Sinha writes: >> On 29-Sep-2023, at 11:43 AM, Markus Armbruster wrote: >> >> Ani Sinha writes: >> On 29-Sep-2023, at 11:17 AM, Markus Armbruster wrote: Ani Sinha writes: > Code changes in acpi that addresses all compiler complaints coming from > enabling >

Re: [PATCH] hw/acpi: changes towards enabling -Wshadow=local

2023-09-28 Thread Ani Sinha
> On 29-Sep-2023, at 11:43 AM, Markus Armbruster wrote: > > Ani Sinha writes: > >>> On 29-Sep-2023, at 11:17 AM, Markus Armbruster wrote: >>> >>> Ani Sinha writes: >>> Code changes in acpi that addresses all compiler complaints coming from enabling -Wshadow flags. Enablin

Re: [PATCH] hw/acpi: changes towards enabling -Wshadow=local

2023-09-28 Thread Markus Armbruster
Ani Sinha writes: >> On 29-Sep-2023, at 11:17 AM, Markus Armbruster wrote: >> >> Ani Sinha writes: >> >>> Code changes in acpi that addresses all compiler complaints coming from >>> enabling >>> -Wshadow flags. Enabling -Wshadow catches cases of local variables shadowing >>> other local vari

Re: [PATCH] hw/acpi: changes towards enabling -Wshadow=local

2023-09-28 Thread Ani Sinha
> On 29-Sep-2023, at 11:17 AM, Markus Armbruster wrote: > > Ani Sinha writes: > >> Code changes in acpi that addresses all compiler complaints coming from >> enabling >> -Wshadow flags. Enabling -Wshadow catches cases of local variables shadowing >> other local variables or parameters. Thes

Re: [PATCH] hw/acpi: changes towards enabling -Wshadow=local

2023-09-28 Thread Markus Armbruster
Ani Sinha writes: > Code changes in acpi that addresses all compiler complaints coming from > enabling > -Wshadow flags. Enabling -Wshadow catches cases of local variables shadowing > other local variables or parameters. These makes the code confusing and/or > adds > bugs that are difficult to

Re: [PATCH] hw/acpi: changes towards enabling -Wshadow=local

2023-09-22 Thread Michael S. Tsirkin
On Fri, Sep 22, 2023 at 06:12:02PM +0530, Ani Sinha wrote: > Code changes in acpi that addresses all compiler complaints coming from > enabling > -Wshadow flags. Enabling -Wshadow catches cases of local variables shadowing > other local variables or parameters. These makes the code confusing and/o

[PATCH] hw/acpi: changes towards enabling -Wshadow=local

2023-09-22 Thread Ani Sinha
Code changes in acpi that addresses all compiler complaints coming from enabling -Wshadow flags. Enabling -Wshadow catches cases of local variables shadowing other local variables or parameters. These makes the code confusing and/or adds bugs that are difficult to catch. The code is tested to buil