Re: [PATCH] gitlab-ci: Only push Docker 'latest' image when building default branch

2021-02-16 Thread Philippe Mathieu-Daudé
On 2/16/21 10:52 AM, Daniel P. Berrangé wrote: > On Tue, Feb 16, 2021 at 08:05:09AM +0100, Philippe Mathieu-Daudé wrote: >> On 2/16/21 7:55 AM, Thomas Huth wrote: >>> On 15/02/2021 20.28, Philippe Mathieu-Daudé wrote: While we are interested in building docker images in different branches

Re: [PATCH] gitlab-ci: Only push Docker 'latest' image when building default branch

2021-02-16 Thread Daniel P . Berrangé
On Tue, Feb 16, 2021 at 08:05:09AM +0100, Philippe Mathieu-Daudé wrote: > On 2/16/21 7:55 AM, Thomas Huth wrote: > > On 15/02/2021 20.28, Philippe Mathieu-Daudé wrote: > >> While we are interested in building docker images in different > >> branches, it only makes sense to push 'latest' to the regi

Re: [PATCH] gitlab-ci: Only push Docker 'latest' image when building default branch

2021-02-15 Thread Philippe Mathieu-Daudé
On 2/16/21 7:55 AM, Thomas Huth wrote: > On 15/02/2021 20.28, Philippe Mathieu-Daudé wrote: >> While we are interested in building docker images in different >> branches, it only makes sense to push 'latest' to the registry >> when this is the project default branch (usually 'master'). >> >> Else w

Re: [PATCH] gitlab-ci: Only push Docker 'latest' image when building default branch

2021-02-15 Thread Thomas Huth
On 15/02/2021 20.28, Philippe Mathieu-Daudé wrote: While we are interested in building docker images in different branches, it only makes sense to push 'latest' to the registry when this is the project default branch (usually 'master'). Else when pushing different branches concurrently we might

[PATCH] gitlab-ci: Only push Docker 'latest' image when building default branch

2021-02-15 Thread Philippe Mathieu-Daudé
While we are interested in building docker images in different branches, it only makes sense to push 'latest' to the registry when this is the project default branch (usually 'master'). Else when pushing different branches concurrently we might have inconsistent image state between branches. Sign