Re: [PATCH] file-posix: detect the lock using the real file

2020-12-10 Thread Daniel P . Berrangé
On Thu, Dec 10, 2020 at 11:53:09PM +0800, Feng Li wrote: > My mistake, you are not on the receiver list of my v2. > I use the get_maintainer.sh to generate the cc list. > I will resend it to you. No, need. I've seen 2, but didn't think you were referring to that as it still has most of the flaws I

Re: [PATCH] file-posix: detect the lock using the real file

2020-12-10 Thread Feng Li
My mistake, you are not on the receiver list of my v2. I use the get_maintainer.sh to generate the cc list. I will resend it to you. Daniel P. Berrangé 于2020年12月10日周四 下午11:29写道： > > On Thu, Dec 10, 2020 at 10:56:59PM +0800, Li Feng wrote: > > Kevin Wolf 于2020年12月10日周四 上午1:43写道： > > > > > > Am 09

Re: [PATCH] file-posix: detect the lock using the real file

2020-12-10 Thread Daniel P . Berrangé
On Thu, Dec 10, 2020 at 10:56:59PM +0800, Li Feng wrote: > Kevin Wolf 于2020年12月10日周四 上午1:43写道： > > > > Am 09.12.2020 um 10:33 hat Daniel P. Berrangé geschrieben: > > > On Tue, Dec 08, 2020 at 03:38:22PM +0100, Kevin Wolf wrote: > > > > Am 08.12.2020 um 13:59 hat Li Feng geschrieben: > > > > > This

Re: [PATCH] file-posix: detect the lock using the real file

2020-12-10 Thread Li Feng
Kevin Wolf 于2020年12月10日周四 上午1:43写道： > > Am 09.12.2020 um 10:33 hat Daniel P. Berrangé geschrieben: > > On Tue, Dec 08, 2020 at 03:38:22PM +0100, Kevin Wolf wrote: > > > Am 08.12.2020 um 13:59 hat Li Feng geschrieben: > > > > This patch addresses this issue: > > > > When accessing a volume on an NF

Re: [PATCH] file-posix: detect the lock using the real file

2020-12-09 Thread Kevin Wolf
Am 09.12.2020 um 10:33 hat Daniel P. Berrangé geschrieben: > On Tue, Dec 08, 2020 at 03:38:22PM +0100, Kevin Wolf wrote: > > Am 08.12.2020 um 13:59 hat Li Feng geschrieben: > > > This patch addresses this issue: > > > When accessing a volume on an NFS filesystem without supporting the file > > >

Re: [PATCH] file-posix: detect the lock using the real file

2020-12-09 Thread Daniel P . Berrangé
On Tue, Dec 08, 2020 at 03:38:22PM +0100, Kevin Wolf wrote: > Am 08.12.2020 um 13:59 hat Li Feng geschrieben: > > This patch addresses this issue: > > When accessing a volume on an NFS filesystem without supporting the file > > lock, > > tools, like qemu-img, will complain "Failed to lock byte 100

Re: [PATCH] file-posix: detect the lock using the real file

2020-12-08 Thread Li Feng
Kevin Wolf 于2020年12月8日周二 下午10:38写道： > > Am 08.12.2020 um 13:59 hat Li Feng geschrieben: > > This patch addresses this issue: > > When accessing a volume on an NFS filesystem without supporting the file > > lock, > > tools, like qemu-img, will complain "Failed to lock byte 100". > > > > In the ori

Re: [PATCH] file-posix: detect the lock using the real file

2020-12-08 Thread Li Feng
Daniel P. Berrangé 于2020年12月8日周二 下午9:45写道： > > On Tue, Dec 08, 2020 at 08:59:37PM +0800, Li Feng wrote: > > This patch addresses this issue: > > When accessing a volume on an NFS filesystem without supporting the file > > lock, > > tools, like qemu-img, will complain "Failed to lock byte 100". >

Re: [PATCH] file-posix: detect the lock using the real file

2020-12-08 Thread Kevin Wolf
Am 08.12.2020 um 13:59 hat Li Feng geschrieben: > This patch addresses this issue: > When accessing a volume on an NFS filesystem without supporting the file lock, > tools, like qemu-img, will complain "Failed to lock byte 100". > > In the original code, the qemu_has_ofd_lock will test the lock on

Re: [PATCH] file-posix: detect the lock using the real file

2020-12-08 Thread Daniel P . Berrangé
On Tue, Dec 08, 2020 at 08:59:37PM +0800, Li Feng wrote: > This patch addresses this issue: > When accessing a volume on an NFS filesystem without supporting the file lock, > tools, like qemu-img, will complain "Failed to lock byte 100". > > In the original code, the qemu_has_ofd_lock will test th

[PATCH] file-posix: detect the lock using the real file

2020-12-08 Thread Li Feng
This patch addresses this issue: When accessing a volume on an NFS filesystem without supporting the file lock, tools, like qemu-img, will complain "Failed to lock byte 100". In the original code, the qemu_has_ofd_lock will test the lock on the "/dev/null" pseudo-file. Actually, the file.locking i