Re: [PATCH] ebpf: fix compatibility with libbpf 1.0+

2023-02-15 Thread Jason Wang
On Wed, Feb 15, 2023 at 4:27 AM Andrew Melnichenko wrote: > > Hi, all. > In the future, there would be eBPF RSS + the helper for Libvirt interaction. > And those patches are required for future work. Technically they are > required for the current builds with linked libbpf 1.01. > Can we apply thi

Re: [PATCH] ebpf: fix compatibility with libbpf 1.0+

2023-02-14 Thread Andrew Melnichenko
Hi, all. In the future, there would be eBPF RSS + the helper for Libvirt interaction. And those patches are required for future work. Technically they are required for the current builds with linked libbpf 1.01. Can we apply this patch? On Wed, Dec 28, 2022 at 6:19 PM Andrew Melnichenko wrote: >

Re: [PATCH] ebpf: fix compatibility with libbpf 1.0+

2022-12-28 Thread Andrew Melnichenko
Hi, it's a good idea to update the skeleton generation. Technically skeleton generation is not a part of Qemu building. The skeleton is already presented in the Qemu tree, so we skip dependencies from clang/bpftool. It's a good idea to have an updated bpf program and simplified Makefile with Qemu s

Re: [PATCH] ebpf: fix compatibility with libbpf 1.0+

2022-12-20 Thread Shreesh Adiga
On Sun, Dec 18, 2022 at 05:15:04PM +0100, Philippe Mathieu-Daudé wrote: > Hi, > > On 18/12/22 15:39, Shreesh Adiga wrote: > > The current implementation fails to load on a system with > > libbpf 1.0 and reports that legacy map definitions in 'maps' > > section are not supported by libbpf v1.0+. Thi

Re: [PATCH] ebpf: fix compatibility with libbpf 1.0+

2022-12-20 Thread Daniel P . Berrangé
On Tue, Dec 20, 2022 at 07:32:47PM +0530, Shreesh Adiga wrote: > On Mon, Dec 19, 2022 at 01:49:37PM +, Daniel P. Berrangé wrote: > > On Mon, Dec 19, 2022 at 07:14:54PM +0530, Shreesh Adiga wrote: > > > Hi Daniel, > > > > > > On Mon, Dec 19, 2022 at 10:56:57AM +, Daniel P. Berrangé wrote: >

Re: [PATCH] ebpf: fix compatibility with libbpf 1.0+

2022-12-20 Thread Shreesh Adiga
On Mon, Dec 19, 2022 at 01:49:37PM +, Daniel P. Berrangé wrote: > On Mon, Dec 19, 2022 at 07:14:54PM +0530, Shreesh Adiga wrote: > > Hi Daniel, > > > > On Mon, Dec 19, 2022 at 10:56:57AM +, Daniel P. Berrangé wrote: > > > On Sun, Dec 18, 2022 at 08:09:27PM +0530, Shreesh Adiga wrote: > > >

Re: [PATCH] ebpf: fix compatibility with libbpf 1.0+

2022-12-19 Thread Daniel P . Berrangé
On Mon, Dec 19, 2022 at 07:14:54PM +0530, Shreesh Adiga wrote: > Hi Daniel, > > On Mon, Dec 19, 2022 at 10:56:57AM +, Daniel P. Berrangé wrote: > > On Sun, Dec 18, 2022 at 08:09:27PM +0530, Shreesh Adiga wrote: > > > The current implementation fails to load on a system with > > > libbpf 1.0 an

Re: [PATCH] ebpf: fix compatibility with libbpf 1.0+

2022-12-19 Thread Shreesh Adiga
Hi Daniel, On Mon, Dec 19, 2022 at 10:56:57AM +, Daniel P. Berrangé wrote: > On Sun, Dec 18, 2022 at 08:09:27PM +0530, Shreesh Adiga wrote: > > The current implementation fails to load on a system with > > libbpf 1.0 and reports that legacy map definitions in 'maps' > > section are not support

Re: [PATCH] ebpf: fix compatibility with libbpf 1.0+

2022-12-19 Thread Daniel P . Berrangé
On Sun, Dec 18, 2022 at 08:09:27PM +0530, Shreesh Adiga wrote: > The current implementation fails to load on a system with > libbpf 1.0 and reports that legacy map definitions in 'maps' > section are not supported by libbpf v1.0+. This commit updates > the Makefile to add BTF (-g flag) and appropri

Re: [PATCH] ebpf: fix compatibility with libbpf 1.0+

2022-12-18 Thread Philippe Mathieu-Daudé
Hi, On 18/12/22 15:39, Shreesh Adiga wrote: The current implementation fails to load on a system with libbpf 1.0 and reports that legacy map definitions in 'maps' section are not supported by libbpf v1.0+. This commit updates the Makefile to add BTF (-g flag) and appropriately updates the maps i

[PATCH] ebpf: fix compatibility with libbpf 1.0+

2022-12-18 Thread Shreesh Adiga
The current implementation fails to load on a system with libbpf 1.0 and reports that legacy map definitions in 'maps' section are not supported by libbpf v1.0+. This commit updates the Makefile to add BTF (-g flag) and appropriately updates the maps in rss.bpf.c and update the skeleton file in rep