Re: [PATCH] dma-helpers: Fix iovec alignment

2024-12-23 Thread Peter Xu
On Sat, Dec 21, 2024 at 12:07:05AM +0300, Michael Tokarev wrote: > 11.08.2024 20:47, Michael Tokarev пишет: > > 12.04.2024 18:25, Eric Blake wrote: > > > On Fri, Apr 12, 2024 at 10:06:17AM +0200, Stefan Fritsch wrote: > > > > Commit 99868af3d0 changed the hardcoded constant BDRV_SECTOR_SIZE to a >

Re: [PATCH] dma-helpers: Fix iovec alignment

2024-12-20 Thread Michael Tokarev
11.08.2024 20:47, Michael Tokarev пишет: 12.04.2024 18:25, Eric Blake wrote: On Fri, Apr 12, 2024 at 10:06:17AM +0200, Stefan Fritsch wrote: Commit 99868af3d0 changed the hardcoded constant BDRV_SECTOR_SIZE to a dynamic field 'align' but introduced a bug. qemu_iovec_discard_back() is now passed

Re: [PATCH] dma-helpers: Fix iovec alignment

2024-08-13 Thread Stefan Fritsch
On Mon, 12 Aug 2024, John Snow wrote: > On Tue, Apr 16, 2024 at 7:54 AM Stefan Fritsch wrote: > > > adding John Snow to CC because he investigated this in 2020. > > > > On Fri, 12 Apr 2024, Eric Blake wrote: > > > > > On Fri, Apr 12, 2024 at 10:06:17AM +0200, Stefan Fritsch wrote: > > > > Commit

Re: [PATCH] dma-helpers: Fix iovec alignment

2024-08-12 Thread John Snow
On Tue, Apr 16, 2024 at 7:54 AM Stefan Fritsch wrote: > adding John Snow to CC because he investigated this in 2020. > > On Fri, 12 Apr 2024, Eric Blake wrote: > > > On Fri, Apr 12, 2024 at 10:06:17AM +0200, Stefan Fritsch wrote: > > > Commit 99868af3d0 changed the hardcoded constant BDRV_SECTOR_

Re: [PATCH] dma-helpers: Fix iovec alignment

2024-08-11 Thread Michael Tokarev
12.04.2024 18:25, Eric Blake wrote: On Fri, Apr 12, 2024 at 10:06:17AM +0200, Stefan Fritsch wrote: Commit 99868af3d0 changed the hardcoded constant BDRV_SECTOR_SIZE to a dynamic field 'align' but introduced a bug. qemu_iovec_discard_back() is now passed the wanted iov length instead of the actu

Re: [PATCH] dma-helpers: Fix iovec alignment

2024-04-16 Thread Stefan Fritsch
adding John Snow to CC because he investigated this in 2020. On Fri, 12 Apr 2024, Eric Blake wrote: > On Fri, Apr 12, 2024 at 10:06:17AM +0200, Stefan Fritsch wrote: > > Commit 99868af3d0 changed the hardcoded constant BDRV_SECTOR_SIZE to a > > dynamic field 'align' but introduced a bug. qemu_iov

Re: [PATCH] dma-helpers: Fix iovec alignment

2024-04-12 Thread Eric Blake
On Fri, Apr 12, 2024 at 10:06:17AM +0200, Stefan Fritsch wrote: > Commit 99868af3d0 changed the hardcoded constant BDRV_SECTOR_SIZE to a > dynamic field 'align' but introduced a bug. qemu_iovec_discard_back() > is now passed the wanted iov length instead of the actually required > amount that shoul

Re: [PATCH] dma-helpers: Fix iovec alignment

2024-04-12 Thread Philippe Mathieu-Daudé
On 12/4/24 10:06, Stefan Fritsch wrote: Commit 99868af3d0 changed the hardcoded constant BDRV_SECTOR_SIZE to a dynamic field 'align' but introduced a bug. qemu_iovec_discard_back() is now passed the wanted iov length instead of the actually required amount that should be removed from the end of t

[PATCH] dma-helpers: Fix iovec alignment

2024-04-12 Thread Stefan Fritsch
Commit 99868af3d0 changed the hardcoded constant BDRV_SECTOR_SIZE to a dynamic field 'align' but introduced a bug. qemu_iovec_discard_back() is now passed the wanted iov length instead of the actually required amount that should be removed from the end of the iov. The bug can likely only be hit in