Re: [PATCH] disas: Fix build with glib2.0 >=2.67.3

2021-03-08 Thread Christian Ehrhardt
On Wed, Feb 24, 2021 at 2:15 PM Daniel P. Berrangé wrote: > > On Wed, Feb 24, 2021 at 01:07:33PM +, Peter Maydell wrote: > > On Wed, 24 Feb 2021 at 11:04, Daniel P. Berrangé > > wrote: > > > So from osdep.h I think something like this is likely sufficient: > > > > > > diff --git a/include/qe

Re: [PATCH] disas: Fix build with glib2.0 >=2.67.3

2021-03-08 Thread Daniel P . Berrangé
On Mon, Mar 08, 2021 at 02:50:39PM +0100, Christian Ehrhardt wrote: > On Wed, Feb 24, 2021 at 2:15 PM Daniel P. Berrangé > wrote: > > > > On Wed, Feb 24, 2021 at 01:07:33PM +, Peter Maydell wrote: > > > On Wed, 24 Feb 2021 at 11:04, Daniel P. Berrangé > > > wrote: > > > > So from osdep.h I

Re: [PATCH] disas: Fix build with glib2.0 >=2.67.3

2021-02-24 Thread Daniel P . Berrangé
On Wed, Feb 24, 2021 at 01:07:33PM +, Peter Maydell wrote: > On Wed, 24 Feb 2021 at 11:04, Daniel P. Berrangé wrote: > > So from osdep.h I think something like this is likely sufficient: > > > > diff --git a/include/qemu/osdep.h b/include/qemu/osdep.h > > index ba15be9c56..7a1d83a8b6 100644 >

Re: [PATCH] disas: Fix build with glib2.0 >=2.67.3

2021-02-24 Thread Peter Maydell
On Wed, 24 Feb 2021 at 11:04, Daniel P. Berrangé wrote: > So from osdep.h I think something like this is likely sufficient: > > diff --git a/include/qemu/osdep.h b/include/qemu/osdep.h > index ba15be9c56..7a1d83a8b6 100644 > --- a/include/qemu/osdep.h > +++ b/include/qemu/osdep.h > @@ -126,6 +126,

Re: [PATCH] disas: Fix build with glib2.0 >=2.67.3

2021-02-24 Thread Daniel P . Berrangé
On Wed, Feb 24, 2021 at 08:38:30AM +0100, Christian Ehrhardt wrote: > On Tue, Feb 23, 2021 at 5:12 PM Daniel P. Berrangé > wrote: > > > > On Tue, Feb 23, 2021 at 03:43:48PM +, Peter Maydell wrote: > > > On Tue, 23 Feb 2021 at 15:03, Christian Ehrhardt > > > wrote: > > > > We need to make hea

Re: [PATCH] disas: Fix build with glib2.0 >=2.67.3

2021-02-23 Thread Christian Ehrhardt
On Tue, Feb 23, 2021 at 5:12 PM Daniel P. Berrangé wrote: > > On Tue, Feb 23, 2021 at 03:43:48PM +, Peter Maydell wrote: > > On Tue, 23 Feb 2021 at 15:03, Christian Ehrhardt > > wrote: > > > > > > glib2.0 introduced a change in 2.67.3 and later which triggers an > > > issue [1] for anyone inc

Re: [PATCH] disas: Fix build with glib2.0 >=2.67.3

2021-02-23 Thread Daniel P . Berrangé
On Tue, Feb 23, 2021 at 03:43:48PM +, Peter Maydell wrote: > On Tue, 23 Feb 2021 at 15:03, Christian Ehrhardt > wrote: > > > > glib2.0 introduced a change in 2.67.3 and later which triggers an > > issue [1] for anyone including it's headers in a "extern C" context > > which a few files in disa

Re: [PATCH] disas: Fix build with glib2.0 >=2.67.3

2021-02-23 Thread Peter Maydell
On Tue, 23 Feb 2021 at 15:03, Christian Ehrhardt wrote: > > glib2.0 introduced a change in 2.67.3 and later which triggers an > issue [1] for anyone including it's headers in a "extern C" context > which a few files in disas/* do. An example of such an include chain > and error look like: > > ../.

[PATCH] disas: Fix build with glib2.0 >=2.67.3

2021-02-23 Thread Christian Ehrhardt
glib2.0 introduced a change in 2.67.3 and later which triggers an issue [1] for anyone including it's headers in a "extern C" context which a few files in disas/* do. An example of such an include chain and error look like: ../../disas/arm-a64.cc In file included from /usr/include/glib-2.0/glib/gm