Queued for 10.0.
LGTM, thanks!
Reviewed-by: zhenwei pi
On 3/12/25 18:11, Markus Armbruster wrote:
When cryptodev_lkcf_set_op_desc() fails, we report an error, but
continue anyway. This is wrong. We then pass a non-null @local_error
to various functions, which could easily fail error_setv()'s assertion
on fai
zhenwei pi writes:
> On 3/18/25 21:21, Markus Armbruster wrote:
>> zhenwei pi writes:
>>
>>> Hi Markus,
>>>
>>> Current code style seems buggy, I think the main reason is that the Error
>>> *errp is not generated at right place. keyctl_pkey_XXX fails without new
>>> error, qcrypto_akcipher_XX
zhenwei pi writes:
> Hi Markus,
>
> Current code style seems buggy, I think the main reason is that the Error
> *errp is not generated at right place. keyctl_pkey_XXX fails without new
> error, qcrypto_akcipher_XXX fails with new error, but they are in the same
> switch-case code block. If we
On 3/18/25 21:21, Markus Armbruster wrote:
zhenwei pi writes:
Hi Markus,
Current code style seems buggy, I think the main reason is that the Error *errp
is not generated at right place. keyctl_pkey_XXX fails without new error,
qcrypto_akcipher_XXX fails with new error, but they are in th
Hi Markus,
Current code style seems buggy, I think the main reason is that the
Error *errp is not generated at right place. keyctl_pkey_XXX fails
without new error, qcrypto_akcipher_XXX fails with new error, but they
are in the same switch-case code block. If we can separate crypto
operations
When cryptodev_lkcf_set_op_desc() fails, we report an error, but
continue anyway. This is wrong. We then pass a non-null @local_error
to various functions, which could easily fail error_setv()'s assertion
on failure.
Fail the function instead.
When qcrypto_akcipher_new() fails, we fail the func
zhenwei pi writes:
> On 3/12/25 18:11, Markus Armbruster wrote:
>> When cryptodev_lkcf_set_op_desc() fails, we report an error, but
>> continue anyway. This is wrong. We then pass a non-null @local_error
>> to various functions, which could easily fail error_setv()'s assertion
>> on failure.
>>
On 3/12/25 18:11, Markus Armbruster wrote:
When cryptodev_lkcf_set_op_desc() fails, we report an error, but
continue anyway. This is wrong. We then pass a non-null @local_error
to various functions, which could easily fail error_setv()'s assertion
on failure.
Fail the function instead.
Whe
