Re: [PATCH] contrib/plugins: Add a plugin to generate basic block vectors

2024-08-14 Thread Pierrick Bouvier
On 8/13/24 23:32, Akihiko Odaki wrote: On 2024/08/14 14:41, Pierrick Bouvier wrote: On 8/13/24 21:56, Akihiko Odaki wrote: On 2024/08/14 4:20, Pierrick Bouvier wrote: Hi Akihiko, and thanks for contributing this new plugin. Hi, Thanks for reviewing Recently, plugins documentation has bee

Re: [PATCH] contrib/plugins: Add a plugin to generate basic block vectors

2024-08-13 Thread Akihiko Odaki
On 2024/08/14 14:41, Pierrick Bouvier wrote: On 8/13/24 21:56, Akihiko Odaki wrote: On 2024/08/14 4:20, Pierrick Bouvier wrote: Hi Akihiko, and thanks for contributing this new plugin. Hi, Thanks for reviewing Recently, plugins documentation has been modified, and list of plugins and thei

Re: [PATCH] contrib/plugins: Add a plugin to generate basic block vectors

2024-08-13 Thread Pierrick Bouvier
On 8/13/24 21:56, Akihiko Odaki wrote: On 2024/08/14 4:20, Pierrick Bouvier wrote: Hi Akihiko, and thanks for contributing this new plugin. Hi, Thanks for reviewing Recently, plugins documentation has been modified, and list of plugins and their doc is now in "docs/about/emulation.rst". Yo

Re: [PATCH] contrib/plugins: Add a plugin to generate basic block vectors

2024-08-13 Thread Akihiko Odaki
On 2024/08/14 4:20, Pierrick Bouvier wrote: Hi Akihiko, and thanks for contributing this new plugin. Hi, Thanks for reviewing Recently, plugins documentation has been modified, and list of plugins and their doc is now in "docs/about/emulation.rst". You may want to rebase on top of master.

Re: [PATCH] contrib/plugins: Add a plugin to generate basic block vectors

2024-08-13 Thread Pierrick Bouvier
Hi Akihiko, and thanks for contributing this new plugin. Recently, plugins documentation has been modified, and list of plugins and their doc is now in "docs/about/emulation.rst". You may want to rebase on top of master. Globally, I'm ok with this plugin and the implementation. Just a few fi

[PATCH] contrib/plugins: Add a plugin to generate basic block vectors

2024-08-12 Thread Akihiko Odaki
SimPoint is a widely used tool to find the ideal microarchitecture simulation points so Valgrind[2] and Pin[3] support generating basic block vectors for use with them. Let's add a corresponding plugin to QEMU too. Note that this plugin has a different goal with tests/plugin/bb.c. This plugin cre