Re: [PATCH] chardev: add a mutex to protect IOWatchPoll::src

2024-07-12 Thread Sergey Dyasli
On 11/07/2024 12:23, Paolo Bonzini wrote: So I think we should just revert commit 2b316774f60, which is not hard to do (if it works) even if the code has since moved from qemu-char.c to chardev/char-io.c. Hi Paolo, Thanks for the suggestion - I've tried it and it seems to work. I'll send out

Re: [PATCH] chardev: add a mutex to protect IOWatchPoll::src

2024-07-11 Thread Paolo Bonzini
On 7/11/24 11:51, Sergey Dyasli wrote: After 038b4217884c ("Revert "chardev: use a child source for qio input source"") we've been observing the "iwp->src == NULL" assertion triggering periodically during the initial capabilities querying by libvirtd. One of possible backtraces: Hi Sergey, tha

[PATCH] chardev: add a mutex to protect IOWatchPoll::src

2024-07-11 Thread Sergey Dyasli
After 038b4217884c ("Revert "chardev: use a child source for qio input source"") we've been observing the "iwp->src == NULL" assertion triggering periodically during the initial capabilities querying by libvirtd. One of possible backtraces: Thread 1 (Thread 0x7f16cd4f0700 (LWP 43858)): 0 __GI_rai