Re: [PATCH] bswap.h: Fix const_le64() macro

2024-01-23 Thread Ira Weiny
Peter Maydell wrote: > The const_le64() macro introduced in commit 845d80a8c7b187 turns out > to have a bug which means that on big-endian systems the compiler > complains if the argument isn't already a 64-bit type. This hasn't > caused a problem yet, because there are no in-tree uses, but it > me

Re: [PATCH] bswap.h: Fix const_le64() macro

2024-01-23 Thread Kevin Wolf
Am 22.01.2024 um 18:37 hat Peter Maydell geschrieben: > The const_le64() macro introduced in commit 845d80a8c7b187 turns out > to have a bug which means that on big-endian systems the compiler > complains if the argument isn't already a 64-bit type. This hasn't > caused a problem yet, because there

Re: [PATCH] bswap.h: Fix const_le64() macro

2024-01-22 Thread Thomas Huth
On 22/01/2024 18.37, Peter Maydell wrote: The const_le64() macro introduced in commit 845d80a8c7b187 turns out to have a bug which means that on big-endian systems the compiler complains if the argument isn't already a 64-bit type. This hasn't caused a problem yet, because there are no in-tree us

Re: [PATCH] bswap.h: Fix const_le64() macro

2024-01-22 Thread Philippe Mathieu-Daudé
On 22/1/24 18:37, Peter Maydell wrote: The const_le64() macro introduced in commit 845d80a8c7b187 turns out to have a bug which means that on big-endian systems the compiler complains if the argument isn't already a 64-bit type. This hasn't caused a problem yet, because there are no in-tree uses,

[PATCH] bswap.h: Fix const_le64() macro

2024-01-22 Thread Peter Maydell
The const_le64() macro introduced in commit 845d80a8c7b187 turns out to have a bug which means that on big-endian systems the compiler complains if the argument isn't already a 64-bit type. This hasn't caused a problem yet, because there are no in-tree uses, but it means it's not possible for anybo