Re: [PATCH] bsd-user: add option to enable plugins

2025-05-08 Thread Philippe Mathieu-Daudé
On 1/4/25 01:42, Pierrick Bouvier wrote: Nothing prevent plugins to be enabled on this platform for user binaries, only the option in the driver is missing. Signed-off-by: Pierrick Bouvier --- bsd-user/main.c | 12 1 file changed, 12 insertions(+) Patch queued, thanks.

Re: [PATCH] bsd-user: add option to enable plugins

2025-05-06 Thread Philippe Mathieu-Daudé
On 6/5/25 02:25, Warner Losh wrote: I'm also ignorant of plugins, but (a) if not enabling plugins is a nop and (b) plugins either work or fail completely, then I think we can enable them. If they cause problems when not enabled by the user, though, we'll likely have to revert. Elsewhere in this

Re: [PATCH] bsd-user: add option to enable plugins

2025-05-05 Thread Warner Losh
I'm also ignorant of plugins, but (a) if not enabling plugins is a nop and (b) plugins either work or fail completely, then I think we can enable them. If they cause problems when not enabled by the user, though, we'll likely have to revert. I don't know enough about them, though, to review. Warn

Re: [PATCH] bsd-user: add option to enable plugins

2025-05-05 Thread Pierrick Bouvier
On 4/28/25 3:57 PM, Kyle Evans wrote: On 4/28/25 14:36, Pierrick Bouvier wrote: On 3/31/25 4:42 PM, Pierrick Bouvier wrote: Nothing prevent plugins to be enabled on this platform for user binaries, only the option in the driver is missing. Signed-off-by: Pierrick Bouvier ---   bsd-user/main.

Re: [PATCH] bsd-user: add option to enable plugins

2025-04-28 Thread Pierrick Bouvier
On 4/28/25 3:57 PM, Kyle Evans wrote: Gentle ping on this series. As we didn't have any feedback from BSD side, could we consider to enable this upstream? Sorry- I have no strong opinion on plugins, but the diff looks incredibly reasonable and non-invasive. I'm not really seeing any reason we

Re: [PATCH] bsd-user: add option to enable plugins

2025-04-28 Thread Kyle Evans
On 4/28/25 14:36, Pierrick Bouvier wrote: On 3/31/25 4:42 PM, Pierrick Bouvier wrote: Nothing prevent plugins to be enabled on this platform for user binaries, only the option in the driver is missing. Signed-off-by: Pierrick Bouvier ---   bsd-user/main.c | 12   1 file changed, 12

Re: [PATCH] bsd-user: add option to enable plugins

2025-04-28 Thread Pierrick Bouvier
On 3/31/25 4:42 PM, Pierrick Bouvier wrote: Nothing prevent plugins to be enabled on this platform for user binaries, only the option in the driver is missing. Signed-off-by: Pierrick Bouvier --- bsd-user/main.c | 12 1 file changed, 12 insertions(+) diff --git a/bsd-user/main.

Re: [PATCH] bsd-user: add option to enable plugins

2025-04-05 Thread Pierrick Bouvier
On 3/31/25 16:42, Pierrick Bouvier wrote: Nothing prevent plugins to be enabled on this platform for user binaries, only the option in the driver is missing. Signed-off-by: Pierrick Bouvier --- bsd-user/main.c | 12 1 file changed, 12 insertions(+) diff --git a/bsd-user/main.c

Re: [PATCH] bsd-user: add option to enable plugins

2025-04-01 Thread Philippe Mathieu-Daudé
On 1/4/25 16:59, Pierrick Bouvier wrote: On 4/1/25 07:44, Philippe Mathieu-Daudé wrote: On 1/4/25 16:33, Pierrick Bouvier wrote: On 3/31/25 23:15, Philippe Mathieu-Daudé wrote: Hi Pierrick, On 1/4/25 01:42, Pierrick Bouvier wrote: Nothing prevent plugins to be enabled on this platform for us

Re: [PATCH] bsd-user: add option to enable plugins

2025-04-01 Thread Pierrick Bouvier
On 3/31/25 23:15, Philippe Mathieu-Daudé wrote: Hi Pierrick, On 1/4/25 01:42, Pierrick Bouvier wrote: Nothing prevent plugins to be enabled on this platform for user binaries, only the option in the driver is missing. Per commit 903e870f245 ("plugins/api: split out binary path/start/end/entry

Re: [PATCH] bsd-user: add option to enable plugins

2025-04-01 Thread Pierrick Bouvier
On 4/1/25 07:44, Philippe Mathieu-Daudé wrote: On 1/4/25 16:33, Pierrick Bouvier wrote: On 3/31/25 23:15, Philippe Mathieu-Daudé wrote: Hi Pierrick, On 1/4/25 01:42, Pierrick Bouvier wrote: Nothing prevent plugins to be enabled on this platform for user binaries, only the option in the driver

Re: [PATCH] bsd-user: add option to enable plugins

2025-04-01 Thread Philippe Mathieu-Daudé
On 1/4/25 16:33, Pierrick Bouvier wrote: On 3/31/25 23:15, Philippe Mathieu-Daudé wrote: Hi Pierrick, On 1/4/25 01:42, Pierrick Bouvier wrote: Nothing prevent plugins to be enabled on this platform for user binaries, only the option in the driver is missing. Per commit 903e870f245 ("plugins/

Re: [PATCH] bsd-user: add option to enable plugins

2025-03-31 Thread Philippe Mathieu-Daudé
Hi Pierrick, On 1/4/25 01:42, Pierrick Bouvier wrote: Nothing prevent plugins to be enabled on this platform for user binaries, only the option in the driver is missing. Per commit 903e870f245 ("plugins/api: split out binary path/start/end/entry code") this is deliberate: The BSD user-mod

[PATCH] bsd-user: add option to enable plugins

2025-03-31 Thread Pierrick Bouvier
Nothing prevent plugins to be enabled on this platform for user binaries, only the option in the driver is missing. Signed-off-by: Pierrick Bouvier --- bsd-user/main.c | 12 1 file changed, 12 insertions(+) diff --git a/bsd-user/main.c b/bsd-user/main.c index fdb160bed0f..329bd1acc