Re: [PATCH] bsd-user: Add missing break after do_bsd_preadv

2023-08-21 Thread Philippe Mathieu-Daudé
On 20/8/23 06:54, Warner Losh wrote: Without it, we'd call preadv, then write with weird parameters, which is clearly not ideal... Signed-off-by: Warner Losh --- bsd-user/freebsd/os-syscall.c | 1 + 1 file changed, 1 insertion(+) Ouch. Fixes: 770d8abae7 ("bsd-user/bsd-file.h: Meat of the

Re: [PATCH] bsd-user: Add missing break after do_bsd_preadv

2023-08-20 Thread Richard Henderson
On 8/19/23 21:54, Warner Losh wrote: Without it, we'd call preadv, then write with weird parameters, which is clearly not ideal... Signed-off-by: Warner Losh --- bsd-user/freebsd/os-syscall.c | 1 + 1 file changed, 1 insertion(+) Reviewed-by: Richard Henderson r~

[PATCH] bsd-user: Add missing break after do_bsd_preadv

2023-08-19 Thread Warner Losh
Without it, we'd call preadv, then write with weird parameters, which is clearly not ideal... Signed-off-by: Warner Losh --- bsd-user/freebsd/os-syscall.c | 1 + 1 file changed, 1 insertion(+) diff --git a/bsd-user/freebsd/os-syscall.c b/bsd-user/freebsd/os-syscall.c index de36c4b71c6..c90400ab