Re: [PATCH] blockdev: Use error_report() in hmp_commit()

2019-10-15 Thread Philippe Mathieu-Daudé
On 10/15/19 2:39 PM, Kevin Wolf wrote: Instead of using monitor_printf() to report errors, hmp_commit() should use error_report() like other places do. Signed-off-by: Kevin Wolf --- blockdev.c | 7 +++ 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/blockdev.c b/blockdev.c

Re: [PATCH] blockdev: Use error_report() in hmp_commit()

2019-10-15 Thread Eric Blake
On 10/15/19 7:39 AM, Kevin Wolf wrote: Instead of using monitor_printf() to report errors, hmp_commit() should use error_report() like other places do. Signed-off-by: Kevin Wolf --- blockdev.c | 7 +++ 1 file changed, 3 insertions(+), 4 deletions(-) Reviewed-by: Eric Blake -- Eric B

[PATCH] blockdev: Use error_report() in hmp_commit()

2019-10-15 Thread Kevin Wolf
Instead of using monitor_printf() to report errors, hmp_commit() should use error_report() like other places do. Signed-off-by: Kevin Wolf --- blockdev.c | 7 +++ 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/blockdev.c b/blockdev.c index f89e48fc79..e2358966c3 100644 --- a/b