Re: [PATCH] block-backend: per-device throttling of BLOCK_IO_ERROR reports

2023-11-16 Thread Vladimir Sementsov-Ogievskiy
On 15.11.23 16:46, Markus Armbruster wrote: Vladimir Sementsov-Ogievskiy writes: From: Leonid Kaplan BLOCK_IO_ERROR events comes from guest, so we must throttle them. Really? Can you describe how a guest can trigger these errors? When disk (for examaple vhost-user) is unavailable, every G

Re: [PATCH] block-backend: per-device throttling of BLOCK_IO_ERROR reports

2023-11-15 Thread Markus Armbruster
Vladimir Sementsov-Ogievskiy writes: > From: Leonid Kaplan > > BLOCK_IO_ERROR events comes from guest, so we must throttle them. Really? Can you describe how a guest can trigger these errors? > We still want per-device throttling, so let's use device id as a key. > > Signed-off-by: Leonid Kap

Re: [PATCH] block-backend: per-device throttling of BLOCK_IO_ERROR reports

2023-11-09 Thread Vladimir Sementsov-Ogievskiy
On 09.11.23 00:22, Eric Blake wrote: On Tue, Nov 07, 2023 at 11:58:42AM +0300, Vladimir Sementsov-Ogievskiy wrote: From: Leonid Kaplan BLOCK_IO_ERROR events comes from guest, so we must throttle them. We still want per-device throttling, so let's use device id as a key. Signed-off-by: Leonid

Re: [PATCH] block-backend: per-device throttling of BLOCK_IO_ERROR reports

2023-11-08 Thread Eric Blake
On Tue, Nov 07, 2023 at 11:58:42AM +0300, Vladimir Sementsov-Ogievskiy wrote: > From: Leonid Kaplan > > BLOCK_IO_ERROR events comes from guest, so we must throttle them. > We still want per-device throttling, so let's use device id as a key. > > Signed-off-by: Leonid Kaplan > Signed-off-by: Vla

[PATCH] block-backend: per-device throttling of BLOCK_IO_ERROR reports

2023-11-07 Thread Vladimir Sementsov-Ogievskiy
From: Leonid Kaplan BLOCK_IO_ERROR events comes from guest, so we must throttle them. We still want per-device throttling, so let's use device id as a key. Signed-off-by: Leonid Kaplan Signed-off-by: Vladimir Sementsov-Ogievskiy --- monitor/monitor.c | 10 ++ 1 file changed, 10 insert