Re: [PATCH] block: temporarily hold the new AioContext of bs_top in bdrv_append()

2023-02-14 Thread Stefano Garzarella
On Tue, Feb 14, 2023 at 3:06 PM Kevin Wolf wrote: > > Am 14.02.2023 um 13:22 hat Stefano Garzarella geschrieben: > > On Tue, Feb 14, 2023 at 12:56 PM Kevin Wolf wrote: > > > > > > Am 14.02.2023 um 11:51 hat Stefano Garzarella geschrieben: > > > > bdrv_append() is called with bs_top AioContext hel

Re: [PATCH] block: temporarily hold the new AioContext of bs_top in bdrv_append()

2023-02-14 Thread Kevin Wolf
Am 14.02.2023 um 13:22 hat Stefano Garzarella geschrieben: > On Tue, Feb 14, 2023 at 12:56 PM Kevin Wolf wrote: > > > > Am 14.02.2023 um 11:51 hat Stefano Garzarella geschrieben: > > > bdrv_append() is called with bs_top AioContext held, but > > > bdrv_attach_child_noperm() could change the AioCon

Re: [PATCH] block: temporarily hold the new AioContext of bs_top in bdrv_append()

2023-02-14 Thread Stefano Garzarella
On Tue, Feb 14, 2023 at 12:56 PM Kevin Wolf wrote: > > Am 14.02.2023 um 11:51 hat Stefano Garzarella geschrieben: > > bdrv_append() is called with bs_top AioContext held, but > > bdrv_attach_child_noperm() could change the AioContext of bs_top. > > > > bdrv_replace_node_noperm() calls bdrv_drained

[PATCH] block: temporarily hold the new AioContext of bs_top in bdrv_append()

2023-02-14 Thread Stefano Garzarella
bdrv_append() is called with bs_top AioContext held, but bdrv_attach_child_noperm() could change the AioContext of bs_top. bdrv_replace_node_noperm() calls bdrv_drained_begin() starting from commit 2398747128 ("block: Don't poll in bdrv_replace_child_noperm()"). bdrv_drained_begin() can call BDRV_

Re: [PATCH] block: temporarily hold the new AioContext of bs_top in bdrv_append()

2023-02-14 Thread Kevin Wolf
Am 14.02.2023 um 11:51 hat Stefano Garzarella geschrieben: > bdrv_append() is called with bs_top AioContext held, but > bdrv_attach_child_noperm() could change the AioContext of bs_top. > > bdrv_replace_node_noperm() calls bdrv_drained_begin() starting from > commit 2398747128 ("block: Don't poll