Re: [PATCH] block: nbd: Fix dirty bitmap context name

2019-12-25 Thread Nir Soffer
On Thu, Dec 19, 2019 at 5:55 PM Nir Soffer wrote: > > On Thu, Dec 19, 2019 at 5:17 PM Vladimir Sementsov-Ogievskiy > wrote: ... > > Note also, that client may use NBD_OPT_LIST_META_CONTEXT with query > > "qemu:dirty-bitmap:", to get list of all exported bitmaps. > > This is another option, I did

Re: [PATCH] block: nbd: Fix dirty bitmap context name

2019-12-20 Thread Vladimir Sementsov-Ogievskiy
20.12.2019 13:40, Peter Krempa wrote: > On Fri, Dec 20, 2019 at 10:06:17 +, Vladimir Sementsov-Ogievskiy wrote: >> 20.12.2019 12:56, Peter Krempa wrote: >>> On Fri, Dec 20, 2019 at 09:39:17 +, Vladimir Sementsov-Ogievskiy wrote: 19.12.2019 18:55, Nir Soffer wrote: > On Thu, Dec 19,

Re: [PATCH] block: nbd: Fix dirty bitmap context name

2019-12-20 Thread Peter Krempa
On Fri, Dec 20, 2019 at 10:06:17 +, Vladimir Sementsov-Ogievskiy wrote: > 20.12.2019 12:56, Peter Krempa wrote: > > On Fri, Dec 20, 2019 at 09:39:17 +, Vladimir Sementsov-Ogievskiy wrote: > >> 19.12.2019 18:55, Nir Soffer wrote: > >>> On Thu, Dec 19, 2019 at 5:17 PM Vladimir Sementsov-Ogiev

Re: [PATCH] block: nbd: Fix dirty bitmap context name

2019-12-20 Thread Vladimir Sementsov-Ogievskiy
20.12.2019 12:56, Peter Krempa wrote: > On Fri, Dec 20, 2019 at 09:39:17 +, Vladimir Sementsov-Ogievskiy wrote: >> 19.12.2019 18:55, Nir Soffer wrote: >>> On Thu, Dec 19, 2019 at 5:17 PM Vladimir Sementsov-Ogievskiy >>> wrote: 19.12.2019 17:59, Nir Soffer wrote: > On Thu, Dec 19,

Re: [PATCH] block: nbd: Fix dirty bitmap context name

2019-12-20 Thread Peter Krempa
On Fri, Dec 20, 2019 at 09:39:17 +, Vladimir Sementsov-Ogievskiy wrote: > 19.12.2019 18:55, Nir Soffer wrote: > > On Thu, Dec 19, 2019 at 5:17 PM Vladimir Sementsov-Ogievskiy > > wrote: > >> > >> 19.12.2019 17:59, Nir Soffer wrote: > >>> On Thu, Dec 19, 2019 at 4:04 PM Kevin Wolf wrote: > >>>

Re: [PATCH] block: nbd: Fix dirty bitmap context name

2019-12-20 Thread Vladimir Sementsov-Ogievskiy
19.12.2019 18:55, Nir Soffer wrote: > On Thu, Dec 19, 2019 at 5:17 PM Vladimir Sementsov-Ogievskiy > wrote: >> >> 19.12.2019 17:59, Nir Soffer wrote: >>> On Thu, Dec 19, 2019 at 4:04 PM Kevin Wolf wrote: Am 19.12.2019 um 14:41 hat Vladimir Sementsov-Ogievskiy geschrieben: > Ahh, I s

Re: [PATCH] block: nbd: Fix dirty bitmap context name

2019-12-19 Thread Nir Soffer
On Thu, Dec 19, 2019 at 5:17 PM Vladimir Sementsov-Ogievskiy wrote: > > 19.12.2019 17:59, Nir Soffer wrote: > > On Thu, Dec 19, 2019 at 4:04 PM Kevin Wolf wrote: > >> > >> Am 19.12.2019 um 14:41 hat Vladimir Sementsov-Ogievskiy geschrieben: > >>> Ahh, I see, it's documented as > >>> > >>> +# @bit

Re: [PATCH] block: nbd: Fix dirty bitmap context name

2019-12-19 Thread Vladimir Sementsov-Ogievskiy
19.12.2019 17:59, Nir Soffer wrote: > On Thu, Dec 19, 2019 at 4:04 PM Kevin Wolf wrote: >> >> Am 19.12.2019 um 14:41 hat Vladimir Sementsov-Ogievskiy geschrieben: >>> Ahh, I see, it's documented as >>> >>> +# @bitmap: Also export the dirty bitmap reachable from @device, so the >>> +# NBD

Re: [PATCH] block: nbd: Fix dirty bitmap context name

2019-12-19 Thread Vladimir Sementsov-Ogievskiy
19.12.2019 17:49, Nir Soffer wrote: > On Thu, Dec 19, 2019 at 3:42 PM Vladimir Sementsov-Ogievskiy > wrote: >> >> I'd not call it a "fix".. As it implies something broken. >> >> [edit: OK, now I see that something is broken, and why you called it "fix", >>see below] >> >> 19.12.2019 15:51, Nir

Re: [PATCH] block: nbd: Fix dirty bitmap context name

2019-12-19 Thread Nir Soffer
On Thu, Dec 19, 2019 at 4:04 PM Kevin Wolf wrote: > > Am 19.12.2019 um 14:41 hat Vladimir Sementsov-Ogievskiy geschrieben: > > Ahh, I see, it's documented as > > > > +# @bitmap: Also export the dirty bitmap reachable from @device, so the > > +# NBD client can use NBD_OPT_SET_META_CONTEXT

Re: [PATCH] block: nbd: Fix dirty bitmap context name

2019-12-19 Thread Nir Soffer
On Thu, Dec 19, 2019 at 3:42 PM Vladimir Sementsov-Ogievskiy wrote: > > I'd not call it a "fix".. As it implies something broken. > > [edit: OK, now I see that something is broken, and why you called it "fix", > see below] > > 19.12.2019 15:51, Nir Soffer wrote: > > When adding an export with a

Re: [PATCH] block: nbd: Fix dirty bitmap context name

2019-12-19 Thread Vladimir Sementsov-Ogievskiy
19.12.2019 17:04, Kevin Wolf wrote: > Am 19.12.2019 um 14:41 hat Vladimir Sementsov-Ogievskiy geschrieben: >> Ahh, I see, it's documented as >> >> +# @bitmap: Also export the dirty bitmap reachable from @device, so the >> +# NBD client can use NBD_OPT_SET_META_CONTEXT with >> +# "

Re: [PATCH] block: nbd: Fix dirty bitmap context name

2019-12-19 Thread Kevin Wolf
Am 19.12.2019 um 14:41 hat Vladimir Sementsov-Ogievskiy geschrieben: > Ahh, I see, it's documented as > > +# @bitmap: Also export the dirty bitmap reachable from @device, so the > +# NBD client can use NBD_OPT_SET_META_CONTEXT with > +# "qemu:dirty-bitmap:NAME" to inspect the bit

Re: [PATCH] block: nbd: Fix dirty bitmap context name

2019-12-19 Thread Vladimir Sementsov-Ogievskiy
I'd not call it a "fix".. As it implies something broken. [edit: OK, now I see that something is broken, and why you called it "fix", see below] 19.12.2019 15:51, Nir Soffer wrote: > When adding an export with a dirty bitmap, expose the bitmap at: > > qemu:dirty-bitmap:export-name export

[PATCH] block: nbd: Fix dirty bitmap context name

2019-12-19 Thread Nir Soffer
When adding an export with a dirty bitmap, expose the bitmap at: qemu:dirty-bitmap:export-name This matches qapi documentation, and user expectations. Without this, qemu leaks libvirt implementations details to clients by exposing the bitmap using the actual bitmap name: qemu:dirty-bitm