Re: [PATCH] block: drop BLK_PERM_GRAPH_MOD

2021-07-20 Thread Eric Blake
On Tue, Jul 20, 2021 at 05:22:29PM +0300, Vladimir Sementsov-Ogievskiy wrote: > First, this permission never protected node from being changed, as a node > generic child-replacing functions don't check it. > > Second, it's a strange thing: it presents a permission of parent node > to change its

Re: [PATCH] block: drop BLK_PERM_GRAPH_MOD

2021-07-20 Thread Vladimir Sementsov-Ogievskiy
Forget to mention in subject: for-6.2 20.07.2021 17:22, Vladimir Sementsov-Ogievskiy wrote: First, this permission never protected node from being changed, as generic child-replacing functions don't check it. Second, it's a strange thing: it presents a permission of parent node to change its ch

[PATCH] block: drop BLK_PERM_GRAPH_MOD

2021-07-20 Thread Vladimir Sementsov-Ogievskiy
First, this permission never protected node from being changed, as generic child-replacing functions don't check it. Second, it's a strange thing: it presents a permission of parent node to change its child. But generally, children are replaced by different mechanisms, like jobs or qmp commands, n