Re: [PATCH] block: bdrv_set_backing_hd(): use drained section

2022-02-01 Thread Vladimir Sementsov-Ogievskiy
28.01.2022 17:12, Emanuele Giuseppe Esposito wrote: On 27/01/2022 15:13, Kevin Wolf wrote: Am 25.01.2022 um 11:12 hat Vladimir Sementsov-Ogievskiy geschrieben: 25.01.2022 12:24, Paolo Bonzini wrote: On 1/24/22 18:37, Vladimir Sementsov-Ogievskiy wrote: Graph modifications should be done in

Re: [PATCH] block: bdrv_set_backing_hd(): use drained section

2022-01-28 Thread Emanuele Giuseppe Esposito
On 27/01/2022 15:13, Kevin Wolf wrote: > Am 25.01.2022 um 11:12 hat Vladimir Sementsov-Ogievskiy geschrieben: >> 25.01.2022 12:24, Paolo Bonzini wrote: >>> On 1/24/22 18:37, Vladimir Sementsov-Ogievskiy wrote: Graph modifications should be done in drained section. stream_prepare() hand

Re: [PATCH] block: bdrv_set_backing_hd(): use drained section

2022-01-27 Thread Kevin Wolf
Am 24.01.2022 um 18:37 hat Vladimir Sementsov-Ogievskiy geschrieben: > Graph modifications should be done in drained section. stream_prepare() > handler of block stream job call bdrv_set_backing_hd() without using > drained section and it's theoretically possible that some IO request > will interle

Re: [PATCH] block: bdrv_set_backing_hd(): use drained section

2022-01-27 Thread Kevin Wolf
Am 25.01.2022 um 11:12 hat Vladimir Sementsov-Ogievskiy geschrieben: > 25.01.2022 12:24, Paolo Bonzini wrote: > > On 1/24/22 18:37, Vladimir Sementsov-Ogievskiy wrote: > > > Graph modifications should be done in drained section. stream_prepare() > > > handler of block stream job call bdrv_set_backi

Re: [PATCH] block: bdrv_set_backing_hd(): use drained section

2022-01-25 Thread Vladimir Sementsov-Ogievskiy
25.01.2022 12:24, Paolo Bonzini wrote: On 1/24/22 18:37, Vladimir Sementsov-Ogievskiy wrote: Graph modifications should be done in drained section. stream_prepare() handler of block stream job call bdrv_set_backing_hd() without using drained section and it's theoretically possible that some IO r

Re: [PATCH] block: bdrv_set_backing_hd(): use drained section

2022-01-25 Thread Paolo Bonzini
On 1/24/22 18:37, Vladimir Sementsov-Ogievskiy wrote: Graph modifications should be done in drained section. stream_prepare() handler of block stream job call bdrv_set_backing_hd() without using drained section and it's theoretically possible that some IO request will interleave with graph modifi

[PATCH] block: bdrv_set_backing_hd(): use drained section

2022-01-24 Thread Vladimir Sementsov-Ogievskiy
Graph modifications should be done in drained section. stream_prepare() handler of block stream job call bdrv_set_backing_hd() without using drained section and it's theoretically possible that some IO request will interleave with graph modification and will use outdated pointers to removed block n