Re: [PATCH] block: Fix bdrv_activate() not to fail without medium

2025-03-20 Thread Kevin Wolf
Am 13.03.2025 um 12:53 hat Markus Armbruster geschrieben: > Kevin Wolf writes: > > > Am 12.03.2025 um 15:37 hat Markus Armbruster geschrieben: > >> bdrv_activate() returns failure without setting an error when > >> !bs->drv. This is suspicious. Turns out it used to succeed then, > >> until comm

Re: [PATCH] block: Fix bdrv_activate() not to fail without medium

2025-03-15 Thread Kevin Wolf
Am 12.03.2025 um 15:37 hat Markus Armbruster geschrieben: > bdrv_activate() returns failure without setting an error when > !bs->drv. This is suspicious. Turns out it used to succeed then, > until commit 5416645fcf82 changed it to return -ENOMEDIUM. > > Return zero instead. > > Fixes: 5416645fc

Re: [PATCH] block: Fix bdrv_activate() not to fail without medium

2025-03-13 Thread Markus Armbruster
Kevin Wolf writes: > Am 12.03.2025 um 15:37 hat Markus Armbruster geschrieben: >> bdrv_activate() returns failure without setting an error when >> !bs->drv. This is suspicious. Turns out it used to succeed then, >> until commit 5416645fcf82 changed it to return -ENOMEDIUM. >> >> Return zero in

Re: [PATCH] block: Fix bdrv_activate() not to fail without medium

2025-03-13 Thread Markus Armbruster
Butterfingers, please ignore this one. I'll send a real reply soon.

Re: [PATCH] block: Fix bdrv_activate() not to fail without medium

2025-03-13 Thread Markus Armbruster
Kevin Wolf writes: > Am 12.03.2025 um 15:37 hat Markus Armbruster geschrieben: >> bdrv_activate() returns failure without setting an error when >> !bs->drv. This is suspicious. Turns out it used to succeed then, >> until commit 5416645fcf82 changed it to return -ENOMEDIUM. >> >> Return zero in

[PATCH] block: Fix bdrv_activate() not to fail without medium

2025-03-12 Thread Markus Armbruster
bdrv_activate() returns failure without setting an error when !bs->drv. This is suspicious. Turns out it used to succeed then, until commit 5416645fcf82 changed it to return -ENOMEDIUM. Return zero instead. Fixes: 5416645fcf82 (block: return error-code from bdrv_invalidate_cache) Signed-off-by: