Re: [PATCH] block/replication.c: Avoid cancelling the job twice

2020-05-13 Thread Kevin Wolf
Am 11.05.2020 um 09:08 hat Lukas Straub geschrieben: > If qemu in colo secondary mode is stopped, it crashes because > s->backup_job is canceled twice: First with job_cancel_sync_all() > in qemu_cleanup() and then in replication_stop(). > > Fix this by assigning NULL to s->backup_job when the job

[PATCH] block/replication.c: Avoid cancelling the job twice

2020-05-11 Thread Lukas Straub
If qemu in colo secondary mode is stopped, it crashes because s->backup_job is canceled twice: First with job_cancel_sync_all() in qemu_cleanup() and then in replication_stop(). Fix this by assigning NULL to s->backup_job when the job completes so replication_stop() and replication_do_checkpoint()