Re: [PATCH] block/backup: fix memory leak in bdrv_backup_top_append()

2020-01-20 Thread Kevin Wolf
Am 23.12.2019 um 14:40 hat Eiichi Tsukata geschrieben: > > > On 2019/12/23 21:40, Vladimir Sementsov-Ogievskiy wrote: > > 23.12.2019 12:06, Eiichi Tsukata wrote: > >> bdrv_open_driver() allocates bs->opaque according to drv->instance_size. > >> There is no need to allocate it and overwrite opaque

Re: [PATCH] block/backup: fix memory leak in bdrv_backup_top_append()

2020-01-20 Thread Kevin Wolf
Am 23.12.2019 um 10:06 hat Eiichi Tsukata geschrieben: > bdrv_open_driver() allocates bs->opaque according to drv->instance_size. > There is no need to allocate it and overwrite opaque in > bdrv_backup_top_append(). > > Reproducer: > > $ QTEST_QEMU_BINARY=./x86_64-softmmu/qemu-system-x86_64 val

Re: [PATCH] block/backup: fix memory leak in bdrv_backup_top_append()

2020-01-18 Thread Eiichi Tsukata
ping On 2019/12/23 18:06, Eiichi Tsukata wrote: > bdrv_open_driver() allocates bs->opaque according to drv->instance_size. > There is no need to allocate it and overwrite opaque in > bdrv_backup_top_append(). > > Reproducer: > > $ QTEST_QEMU_BINARY=./x86_64-softmmu/qemu-system-x86_64 valgrind

Re: [PATCH] block/backup: fix memory leak in bdrv_backup_top_append()

2019-12-23 Thread Eiichi Tsukata
On 2019/12/23 21:40, Vladimir Sementsov-Ogievskiy wrote: > 23.12.2019 12:06, Eiichi Tsukata wrote: >> bdrv_open_driver() allocates bs->opaque according to drv->instance_size. >> There is no need to allocate it and overwrite opaque in >> bdrv_backup_top_append(). >> >> Reproducer: >> >>$ QTES

Re: [PATCH] block/backup: fix memory leak in bdrv_backup_top_append()

2019-12-23 Thread Vladimir Sementsov-Ogievskiy
23.12.2019 12:06, Eiichi Tsukata wrote: > bdrv_open_driver() allocates bs->opaque according to drv->instance_size. > There is no need to allocate it and overwrite opaque in > bdrv_backup_top_append(). > > Reproducer: > >$ QTEST_QEMU_BINARY=./x86_64-softmmu/qemu-system-x86_64 valgrind -q > --

[PATCH] block/backup: fix memory leak in bdrv_backup_top_append()

2019-12-23 Thread Eiichi Tsukata
bdrv_open_driver() allocates bs->opaque according to drv->instance_size. There is no need to allocate it and overwrite opaque in bdrv_backup_top_append(). Reproducer: $ QTEST_QEMU_BINARY=./x86_64-softmmu/qemu-system-x86_64 valgrind -q --leak-check=full tests/test-replication -p /replication/se