Re: [PATCH] bitops.h: Compile out asserts without --enable-debug

2023-06-05 Thread BALATON Zoltan
On Tue, 23 May 2023, Alex Bennée wrote: Richard Henderson writes: On 5/22/23 15:26, BALATON Zoltan wrote: On Mon, 22 May 2023, Alex Bennée wrote: (ajb: add Richard for his compiler-fu) BALATON Zoltan writes: On Mon, 22 May 2023, Alex Bennée wrote: BALATON Zoltan writes: The low level ex

Re: [PATCH] bitops.h: Compile out asserts without --enable-debug

2023-05-23 Thread Alex Bennée
Richard Henderson writes: > On 5/22/23 15:26, BALATON Zoltan wrote: >> On Mon, 22 May 2023, Alex Bennée wrote: >>> (ajb: add Richard for his compiler-fu) >>> BALATON Zoltan writes: On Mon, 22 May 2023, Alex Bennée wrote: > BALATON Zoltan writes: > >> The low level extract and

Re: [PATCH] bitops.h: Compile out asserts without --enable-debug

2023-05-22 Thread Richard Henderson
On 5/22/23 15:26, BALATON Zoltan wrote: On Mon, 22 May 2023, Alex Bennée wrote: (ajb: add Richard for his compiler-fu) BALATON Zoltan writes: On Mon, 22 May 2023, Alex Bennée wrote: BALATON Zoltan writes: The low level extract and deposit funtions provided by bitops.h are used in performan

Re: [PATCH] bitops.h: Compile out asserts without --enable-debug

2023-05-22 Thread BALATON Zoltan
On Mon, 22 May 2023, Alex Bennée wrote: (ajb: add Richard for his compiler-fu) BALATON Zoltan writes: On Mon, 22 May 2023, Alex Bennée wrote: BALATON Zoltan writes: The low level extract and deposit funtions provided by bitops.h are used in performance critical places. It crept into target/

Re: [PATCH] bitops.h: Compile out asserts without --enable-debug

2023-05-22 Thread Alex Bennée
(ajb: add Richard for his compiler-fu) BALATON Zoltan writes: > On Mon, 22 May 2023, Alex Bennée wrote: >> BALATON Zoltan writes: >> >>> The low level extract and deposit funtions provided by bitops.h are >>> used in performance critical places. It crept into target/ppc via >>> FIELD_EX64 and

Re: [PATCH] bitops.h: Compile out asserts without --enable-debug

2023-05-22 Thread BALATON Zoltan
On Mon, 22 May 2023, Alex Bennée wrote: BALATON Zoltan writes: The low level extract and deposit funtions provided by bitops.h are used in performance critical places. It crept into target/ppc via FIELD_EX64 and also used by softfloat so PPC code using a lot of FPU where hardfloat is also disa

Re: [PATCH] bitops.h: Compile out asserts without --enable-debug

2023-05-22 Thread Alex Bennée
BALATON Zoltan writes: > The low level extract and deposit funtions provided by bitops.h are > used in performance critical places. It crept into target/ppc via > FIELD_EX64 and also used by softfloat so PPC code using a lot of FPU > where hardfloat is also disabled is doubly affected. Most of

Re: [PATCH] bitops.h: Compile out asserts without --enable-debug

2023-05-22 Thread Peter Maydell
On Mon, 22 May 2023 at 13:00, BALATON Zoltan wrote: > On Mon, 22 May 2023, Peter Maydell wrote: > > Can we have some figures for performance improvements, > > please? General QEMU policy is that asserts remain, > > even in non-debug builds, so exceptions from that policy > > should come with justi

Re: [PATCH] bitops.h: Compile out asserts without --enable-debug

2023-05-22 Thread BALATON Zoltan
On Mon, 22 May 2023, Peter Maydell wrote: On Sat, 20 May 2023 at 21:55, BALATON Zoltan wrote: The low level extract and deposit funtions provided by bitops.h are used in performance critical places. It crept into target/ppc via FIELD_EX64 and also used by softfloat so PPC code using a lot of F

Re: [PATCH] bitops.h: Compile out asserts without --enable-debug

2023-05-22 Thread Peter Maydell
On Sat, 20 May 2023 at 21:55, BALATON Zoltan wrote: > > The low level extract and deposit funtions provided by bitops.h are > used in performance critical places. It crept into target/ppc via > FIELD_EX64 and also used by softfloat so PPC code using a lot of FPU > where hardfloat is also disabled

[PATCH] bitops.h: Compile out asserts without --enable-debug

2023-05-20 Thread BALATON Zoltan
The low level extract and deposit funtions provided by bitops.h are used in performance critical places. It crept into target/ppc via FIELD_EX64 and also used by softfloat so PPC code using a lot of FPU where hardfloat is also disabled is doubly affected. Normally asserts should be compiled out fr