Re: [PATCH] audio/dsound: fix invalid parameters error

2020-02-06 Thread Gerd Hoffmann
On Mon, Feb 03, 2020 at 12:02:23AM +0100, Kővágó, Zoltán wrote: > Windows (unlike wine) bails out when IDirectSoundBuffer8::Lock is called > with zero length. Also, hw->pos_emul handling was incorrect when > calling this function for the first time. > > Signed-off-by: Kővágó, Zoltán > Reported-b

Re: [PATCH] audio/dsound: fix invalid parameters error

2020-02-03 Thread Howard Spoelstra
Cher Philippe, On Mon, Feb 3, 2020 at 10:18 AM Philippe Mathieu-Daudé wrote: > Hi Howard, > > On 2/3/20 8:56 AM, Howard Spoelstra wrote: > > On Mon, Feb 3, 2020 at 12:02 AM Kővágó, Zoltán > > wrote: > > > > Windows (unlike wine) bails out when IDirectSoundBuff

Re: [PATCH] audio/dsound: fix invalid parameters error

2020-02-03 Thread Philippe Mathieu-Daudé
Hi Howard, On 2/3/20 8:56 AM, Howard Spoelstra wrote: On Mon, Feb 3, 2020 at 12:02 AM Kővágó, Zoltán > wrote: Windows (unlike wine) bails out when IDirectSoundBuffer8::Lock is called with zero length.  Also, hw->pos_emul handling was incorrect when cal

Re: [PATCH] audio/dsound: fix invalid parameters error

2020-02-02 Thread Howard Spoelstra
On Mon, Feb 3, 2020 at 12:02 AM Kővágó, Zoltán wrote: > Windows (unlike wine) bails out when IDirectSoundBuffer8::Lock is called > with zero length. Also, hw->pos_emul handling was incorrect when > calling this function for the first time. > > Signed-off-by: Kővágó, Zoltán > Reported-by: KJ Lie

[PATCH] audio/dsound: fix invalid parameters error

2020-02-02 Thread Kővágó, Zoltán
Windows (unlike wine) bails out when IDirectSoundBuffer8::Lock is called with zero length. Also, hw->pos_emul handling was incorrect when calling this function for the first time. Signed-off-by: Kővágó, Zoltán Reported-by: KJ Liew --- I've tested this patch on wine and a borrowed Windows 8.1 l

Re: [PATCH] audio/dsound: fix invalid parameters error

2020-02-01 Thread KJ Liew
On Mon, Jan 27, 2020 at 02:46:58AM +0100, Zoltán Kővágó wrote: > On 2020-01-18 07:30, Philippe Mathieu-Daudé wrote: > > On 1/17/20 7:26 PM, KJ Liew wrote: > > > QEMU Windows has broken dsound backend since the rewrite of audio API in > > > version 4.2.0. Both playback and capture buffers failed to

Re: [PATCH] audio/dsound: fix invalid parameters error

2020-01-30 Thread Gerd Hoffmann
On Mon, Jan 27, 2020 at 02:46:58AM +0100, Zoltán Kővágó wrote: > On 2020-01-18 07:30, Philippe Mathieu-Daudé wrote: > > On 1/17/20 7:26 PM, KJ Liew wrote: > > > QEMU Windows has broken dsound backend since the rewrite of audio API in > > > version 4.2.0. Both playback and capture buffers failed to

Re: [PATCH] audio/dsound: fix invalid parameters error

2020-01-26 Thread Zoltán Kővágó
On 2020-01-18 07:30, Philippe Mathieu-Daudé wrote: On 1/17/20 7:26 PM, KJ Liew wrote: QEMU Windows has broken dsound backend since the rewrite of audio API in version 4.2.0. Both playback and capture buffers failed to lock with invalid parameters error. Fixes: 7fa9754ac88 (dsoundaudio: port to

Re: [PATCH] audio/dsound: fix invalid parameters error

2020-01-17 Thread Philippe Mathieu-Daudé
On 1/17/20 7:26 PM, KJ Liew wrote: QEMU Windows has broken dsound backend since the rewrite of audio API in version 4.2.0. Both playback and capture buffers failed to lock with invalid parameters error. Fixes: 7fa9754ac88 (dsoundaudio: port to the new audio backend api) Cc'ing Zoltán who wrote