Re: [PATCH] ati-vga: Do not allow unaligned access via index register

2020-05-18 Thread Gerd Hoffmann
Hi, > > > Buglink: https://bugs.launchpad.net/qemu/+bug/1878134 > > Does this reply add that tag already or do I need to submit a v2 with it (or > the maintainer could add it when merging)? Patch added to vga queue. Buglink added too. Doesn't happen automatically though so having this in the

Re: [PATCH] ati-vga: Do not allow unaligned access via index register

2020-05-17 Thread Philippe Mathieu-Daudé
On 5/17/20 4:30 PM, BALATON Zoltan wrote: On Sun, 17 May 2020, Philippe Mathieu-Daudé wrote: On 5/17/20 12:40 PM, Philippe Mathieu-Daudé wrote: On 5/16/20 5:33 PM, BALATON Zoltan wrote: On Sat, 16 May 2020, Alexander Bulekov wrote: On 200516 1513, BALATON Zoltan wrote: Finally, there is a ta

Re: [PATCH] ati-vga: Do not allow unaligned access via index register

2020-05-17 Thread BALATON Zoltan
On Sun, 17 May 2020, Philippe Mathieu-Daudé wrote: On 5/17/20 12:40 PM, Philippe Mathieu-Daudé wrote: On 5/16/20 5:33 PM, BALATON Zoltan wrote: On Sat, 16 May 2020, Alexander Bulekov wrote: On 200516 1513, BALATON Zoltan wrote: Finally, there is a tag documented for bug fixes: https://wiki.qe

Re: [PATCH] ati-vga: Do not allow unaligned access via index register

2020-05-17 Thread Philippe Mathieu-Daudé
On 5/17/20 12:40 PM, Philippe Mathieu-Daudé wrote: On 5/16/20 5:33 PM, BALATON Zoltan wrote: On Sat, 16 May 2020, Alexander Bulekov wrote: On 200516 1513, BALATON Zoltan wrote: According to docs bits 1 and 0 of MM_INDEX are hard coded to 0 so unaligned access via this register should not be po

Re: [PATCH] ati-vga: Do not allow unaligned access via index register

2020-05-17 Thread Philippe Mathieu-Daudé
On 5/16/20 5:33 PM, BALATON Zoltan wrote: On Sat, 16 May 2020, Alexander Bulekov wrote: On 200516 1513, BALATON Zoltan wrote: According to docs bits 1 and 0 of MM_INDEX are hard coded to 0 so unaligned access via this register should not be possible. This also fixes problems reported in bug #18

Re: [PATCH] ati-vga: Do not allow unaligned access via index register

2020-05-16 Thread BALATON Zoltan
On Sat, 16 May 2020, Alexander Bulekov wrote: On 200516 1513, BALATON Zoltan wrote: According to docs bits 1 and 0 of MM_INDEX are hard coded to 0 so unaligned access via this register should not be possible. This also fixes problems reported in bug #1878134. Signed-off-by: BALATON Zoltan ---

Re: [PATCH] ati-vga: Do not allow unaligned access via index register

2020-05-16 Thread Alexander Bulekov
On 200516 1513, BALATON Zoltan wrote: > According to docs bits 1 and 0 of MM_INDEX are hard coded to 0 so > unaligned access via this register should not be possible. > This also fixes problems reported in bug #1878134. > > Signed-off-by: BALATON Zoltan > --- Hi Zoltan, I applied this patch and

[PATCH] ati-vga: Do not allow unaligned access via index register

2020-05-16 Thread BALATON Zoltan
According to docs bits 1 and 0 of MM_INDEX are hard coded to 0 so unaligned access via this register should not be possible. This also fixes problems reported in bug #1878134. Signed-off-by: BALATON Zoltan --- hw/display/ati.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/h