Re: [PATCH] arm/trace: Fix hex printing

2020-10-27 Thread Auger Eric
Hi Peter, On 10/27/20 11:38 AM, Peter Maydell wrote: > OK; I'll apply this patch to target-arm.next; feel free to send > a patch updating the other tracepoints to hex. sure, I will. Thanks Eric

Re: [PATCH] arm/trace: Fix hex printing

2020-10-27 Thread Peter Maydell
On Tue, 27 Oct 2020 at 09:24, Auger Eric wrote: > > Hi Peter, > > On 10/19/20 9:26 PM, Peter Maydell wrote: > > Eric, do we want to use hex here, or should we go for > > decimal the way we do with (almost) all the other > > tracing of stream IDs (eg mmuv3_cmdq_cfgi_ste in the line before)? > > > >

Re: [PATCH] arm/trace: Fix hex printing

2020-10-27 Thread Auger Eric
Hi Peter, On 10/19/20 9:26 PM, Peter Maydell wrote: > On Wed, 14 Oct 2020 at 20:36, Dr. David Alan Gilbert (git) > wrote: >> >> From: "Dr. David Alan Gilbert" >> >> Use of 0x%d - make up our mind as 0x%x >> >> Signed-off-by: Dr. David Alan Gilbert >> --- >> hw/arm/trace-events | 2 +- >> 1 fil

Re: [PATCH] arm/trace: Fix hex printing

2020-10-19 Thread Peter Maydell
On Wed, 14 Oct 2020 at 20:36, Dr. David Alan Gilbert (git) wrote: > > From: "Dr. David Alan Gilbert" > > Use of 0x%d - make up our mind as 0x%x > > Signed-off-by: Dr. David Alan Gilbert > --- > hw/arm/trace-events | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/hw/arm/t

Re: [PATCH] arm/trace: Fix hex printing

2020-10-15 Thread Auger Eric
Hi Dave, On 10/14/20 9:33 PM, Dr. David Alan Gilbert (git) wrote: > From: "Dr. David Alan Gilbert" > > Use of 0x%d - make up our mind as 0x%x > > Signed-off-by: Dr. David Alan Gilbert Acked-by: Eric Auger Thanks Eric > --- > hw/arm/trace-events | 2 +- > 1 file changed, 1 insertion(+), 1 d

Re: [PATCH] arm/trace: Fix hex printing

2020-10-14 Thread Philippe Mathieu-Daudé
On 10/14/20 9:33 PM, Dr. David Alan Gilbert (git) wrote: From: "Dr. David Alan Gilbert" Use of 0x%d - make up our mind as 0x%x Uh... Reviewed-by: Philippe Mathieu-Daudé (hw/arm/... in subject) Signed-off-by: Dr. David Alan Gilbert --- hw/arm/trace-events | 2 +- 1 file changed, 1 in

[PATCH] arm/trace: Fix hex printing

2020-10-14 Thread Dr. David Alan Gilbert (git)
From: "Dr. David Alan Gilbert" Use of 0x%d - make up our mind as 0x%x Signed-off-by: Dr. David Alan Gilbert --- hw/arm/trace-events | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hw/arm/trace-events b/hw/arm/trace-events index c8a4d80f6b..a335ee891d 100644 --- a/hw/arm/tra