Re: [PATCH] Update scripts/meson-buildoptions.sh

2023-01-08 Thread Richard Henderson
On 1/7/23 10:02, Paolo Bonzini wrote: On 1/3/23 20:31, Stefan Hajnoczi wrote: The other problem with this file is that it appears to be generated differently depending on the host distro (specifically the default value for the --libdir option). That also would seem to nudge towards "don't commit

Re: [PATCH] Update scripts/meson-buildoptions.sh

2023-01-07 Thread Paolo Bonzini
On 1/3/23 20:31, Stefan Hajnoczi wrote: The other problem with this file is that it appears to be generated differently depending on the host distro (specifically the default value for the --libdir option). That also would seem to nudge towards "don't commit a generated file". I wasn't aware of

Re: [PATCH] Update scripts/meson-buildoptions.sh

2023-01-04 Thread Stefan Hajnoczi
On Mon, Jan 02, 2023 at 11:41:13AM +0100, Alessandro Di Federico wrote: > Note: `Makefile` relies on modification dates in the source tree to > detect changes to `meson_options.txt`. However, git does not track > those. Therefore, the following was necessary to regenerate > `meson-buildoptions.sh`:

Re: [PATCH] Update scripts/meson-buildoptions.sh

2023-01-03 Thread Stefan Hajnoczi
On Tue, 3 Jan 2023 at 12:31, Peter Maydell wrote: > > On Tue, 3 Jan 2023 at 16:12, Alessandro Di Federico wrote: > > > > On Tue, 3 Jan 2023 10:51:36 -0500 > > Stefan Hajnoczi wrote: > > > > > QEMU's Makefile used to a use a technique where it generated > > > "timestamp" files and used cmp(1) to

Re: [PATCH] Update scripts/meson-buildoptions.sh

2023-01-03 Thread Peter Maydell
On Tue, 3 Jan 2023 at 16:12, Alessandro Di Federico wrote: > > On Tue, 3 Jan 2023 10:51:36 -0500 > Stefan Hajnoczi wrote: > > > QEMU's Makefile used to a use a technique where it generated > > "timestamp" files and used cmp(1) to check if rebuilding was > > necessary: > > 1. Always generate meson

Re: [PATCH] Update scripts/meson-buildoptions.sh

2023-01-03 Thread Alessandro Di Federico via
On Tue, 3 Jan 2023 10:51:36 -0500 Stefan Hajnoczi wrote: > QEMU's Makefile used to a use a technique where it generated > "timestamp" files and used cmp(1) to check if rebuilding was > necessary: > 1. Always generate meson-buildoptions.sh-timestamp. `meson-buildoptions.sh-timestamp` would be the

Re: [PATCH] Update scripts/meson-buildoptions.sh

2023-01-03 Thread Stefan Hajnoczi
On Tue, 3 Jan 2023 at 10:26, Alessandro Di Federico wrote: > > On Tue, 3 Jan 2023 09:37:51 -0500 > Stefan Hajnoczi wrote: > > > I don't understand the issue. Can you describe the steps that cause > > meson-buildoptions.sh to become out-of-sync with meson_options.txt? > > > > This will continue to

Re: [PATCH] Update scripts/meson-buildoptions.sh

2023-01-03 Thread Alessandro Di Federico via
On Tue, 3 Jan 2023 09:37:51 -0500 Stefan Hajnoczi wrote: > I don't understand the issue. Can you describe the steps that cause > meson-buildoptions.sh to become out-of-sync with meson_options.txt? > > This will continue to be a problem in the future. Is there a way to > fix it permanently? In M

Re: [PATCH] Update scripts/meson-buildoptions.sh

2023-01-03 Thread Stefan Hajnoczi
On Mon, 2 Jan 2023 at 05:42, Alessandro Di Federico via wrote: > > Note: `Makefile` relies on modification dates in the source tree to > detect changes to `meson_options.txt`. However, git does not track > those. Therefore, the following was necessary to regenerate > `meson-buildoptions.sh`: > >

Re: [PATCH] Update scripts/meson-buildoptions.sh

2023-01-03 Thread Thomas Huth
On 02/01/2023 11.41, Alessandro Di Federico wrote: Note: `Makefile` relies on modification dates in the source tree to detect changes to `meson_options.txt`. However, git does not track those. Therefore, the following was necessary to regenerate `meson-buildoptions.sh`: touch meson_options.

[PATCH] Update scripts/meson-buildoptions.sh

2023-01-02 Thread Alessandro Di Federico via
Note: `Makefile` relies on modification dates in the source tree to detect changes to `meson_options.txt`. However, git does not track those. Therefore, the following was necessary to regenerate `meson-buildoptions.sh`: touch meson_options.txt cd "$BUILD_DIR" make update-buildoptions