Re: [PATCH] Revert "hw/sparc64/niagara: Use blk_name() instead of open-coding it"

On 15/05/2023 16:11, Markus Armbruster wrote: This reverts commit 1881f336a33a8a99cb17ab1c57ed953682e8e107. This commit breaks "-drive if=pflash,readonly=on,file=image.iso". It claims to merely replace an open-coded version of blk_name() by a call, but that's not the case. Sorry for the incon

Re: [PATCH] Revert "hw/sparc64/niagara: Use blk_name() instead of open-coding it"

On 16/5/23 10:04, Markus Armbruster wrote: Mark Cave-Ayland writes: On 15/05/2023 16:11, Markus Armbruster wrote: This reverts commit 1881f336a33a8a99cb17ab1c57ed953682e8e107. This commit breaks "-drive if=pflash,readonly=on,file=image.iso". It claims to merely replace an open-coded version

Re: [PATCH] Revert "hw/sparc64/niagara: Use blk_name() instead of open-coding it"

Mark Cave-Ayland writes: > On 15/05/2023 16:11, Markus Armbruster wrote: > >> This reverts commit 1881f336a33a8a99cb17ab1c57ed953682e8e107. >> This commit breaks "-drive if=pflash,readonly=on,file=image.iso". It >> claims to merely replace an open-coded version of blk_name() by a >> call, but th

Re: [PATCH] Revert "hw/sparc64/niagara: Use blk_name() instead of open-coding it"

On 15/05/2023 16:11, Markus Armbruster wrote: This reverts commit 1881f336a33a8a99cb17ab1c57ed953682e8e107. This commit breaks "-drive if=pflash,readonly=on,file=image.iso". It claims to merely replace an open-coded version of blk_name() by a call, but that's not the case. Sorry for the incon

[PATCH] Revert "hw/sparc64/niagara: Use blk_name() instead of open-coding it"

This reverts commit 1881f336a33a8a99cb17ab1c57ed953682e8e107. This commit breaks "-drive if=pflash,readonly=on,file=image.iso". It claims to merely replace an open-coded version of blk_name() by a call, but that's not the case. Sorry for the inconvenience! Reported-by: Jakub Jermář Cc: qemu-st