Re: [PATCH] Revert "check-block: replace -makecheck with TAP output"

2022-03-07 Thread Thomas Huth
On 04/03/2022 17.57, Daniel P. Berrangé wrote: On Tue, Feb 08, 2022 at 07:44:32AM -0500, Paolo Bonzini wrote: This reverts commit d316859f4e28c74ab8b618895d2a5e0a865d3cf1. The TAP output is inferior in that it does not include the diff for failed tests. Reported-by: Peter Maydell Signed-off-b

Re: [PATCH] Revert "check-block: replace -makecheck with TAP output"

2022-03-04 Thread Daniel P . Berrangé
On Tue, Feb 08, 2022 at 07:44:32AM -0500, Paolo Bonzini wrote: > This reverts commit d316859f4e28c74ab8b618895d2a5e0a865d3cf1. The > TAP output is inferior in that it does not include the diff for > failed tests. > > Reported-by: Peter Maydell > Signed-off-by: Paolo Bonzini > --- > tests/check

Re: [PATCH] Revert "check-block: replace -makecheck with TAP output"

2022-02-08 Thread Thomas Huth
On 08/02/2022 17.21, Paolo Bonzini wrote: On 2/8/22 15:51, Thomas Huth wrote: On 08/02/2022 13.44, Paolo Bonzini wrote: This reverts commit d316859f4e28c74ab8b618895d2a5e0a865d3cf1.  The TAP output is inferior in that it does not include the diff for failed tests. What about dumping the outpu

Re: [PATCH] Revert "check-block: replace -makecheck with TAP output"

2022-02-08 Thread Paolo Bonzini
On 2/8/22 15:51, Thomas Huth wrote: On 08/02/2022 13.44, Paolo Bonzini wrote: This reverts commit d316859f4e28c74ab8b618895d2a5e0a865d3cf1.  The TAP output is inferior in that it does not include the diff for failed tests. What about dumping the output of meson-logs/testlog.txt instead? The d

Re: [PATCH] Revert "check-block: replace -makecheck with TAP output"

2022-02-08 Thread Peter Maydell
On Tue, 8 Feb 2022 at 12:44, Paolo Bonzini wrote: > > This reverts commit d316859f4e28c74ab8b618895d2a5e0a865d3cf1. The > TAP output is inferior in that it does not include the diff for > failed tests. > > Reported-by: Peter Maydell > Signed-off-by: Paolo Bonzini Thanks; I tested and confirmed

Re: [PATCH] Revert "check-block: replace -makecheck with TAP output"

2022-02-08 Thread Thomas Huth
On 08/02/2022 13.44, Paolo Bonzini wrote: This reverts commit d316859f4e28c74ab8b618895d2a5e0a865d3cf1. The TAP output is inferior in that it does not include the diff for failed tests. What about dumping the output of meson-logs/testlog.txt instead? The diff also shows up there! Thomas

[PATCH] Revert "check-block: replace -makecheck with TAP output"

2022-02-08 Thread Paolo Bonzini
This reverts commit d316859f4e28c74ab8b618895d2a5e0a865d3cf1. The TAP output is inferior in that it does not include the diff for failed tests. Reported-by: Peter Maydell Signed-off-by: Paolo Bonzini --- tests/check-block.sh | 6 ++-- tests/qemu-iotests/check | 6 ++-- te