Re: [PATCH] KVM: x86: do not fail if software breakpoint has already been removed

2021-03-12 Thread Maxim Levitsky
On Fri, 2021-03-12 at 12:59 +0100, Stefano Garzarella wrote: > On Thu, Mar 11, 2021 at 02:53:15PM +0200, Maxim Levitsky wrote: > > On Thu, 2021-03-04 at 11:15 +0100, Stefano Garzarella wrote: > > > On Wed, Mar 03, 2021 at 02:07:24PM +0200, Maxim Levitsky wrote: > > > > On Tue, 2021-03-02 at 15:52 +

Re: [PATCH] KVM: x86: do not fail if software breakpoint has already been removed

2021-03-12 Thread Stefano Garzarella
On Thu, Mar 11, 2021 at 02:53:15PM +0200, Maxim Levitsky wrote: On Thu, 2021-03-04 at 11:15 +0100, Stefano Garzarella wrote: On Wed, Mar 03, 2021 at 02:07:24PM +0200, Maxim Levitsky wrote: > On Tue, 2021-03-02 at 15:52 +0100, Stefano Garzarella wrote: > > On Mon, Mar 01, 2021 at 02:56:40PM +0200

Re: [PATCH] KVM: x86: do not fail if software breakpoint has already been removed

2021-03-11 Thread Maxim Levitsky
On Thu, 2021-03-04 at 11:15 +0100, Stefano Garzarella wrote: > On Wed, Mar 03, 2021 at 02:07:24PM +0200, Maxim Levitsky wrote: > > On Tue, 2021-03-02 at 15:52 +0100, Stefano Garzarella wrote: > > > On Mon, Mar 01, 2021 at 02:56:40PM +0200, Maxim Levitsky wrote: > > > > On Mon, 2021-03-01 at 12:17 +

Re: [PATCH] KVM: x86: do not fail if software breakpoint has already been removed

2021-03-04 Thread Stefano Garzarella
On Wed, Mar 03, 2021 at 02:07:24PM +0200, Maxim Levitsky wrote: On Tue, 2021-03-02 at 15:52 +0100, Stefano Garzarella wrote: On Mon, Mar 01, 2021 at 02:56:40PM +0200, Maxim Levitsky wrote: > On Mon, 2021-03-01 at 12:17 +0100, Paolo Bonzini wrote: > > If kvm_arch_remove_sw_breakpoint finds that a

Re: [PATCH] KVM: x86: do not fail if software breakpoint has already been removed

2021-03-03 Thread Maxim Levitsky
On Tue, 2021-03-02 at 15:52 +0100, Stefano Garzarella wrote: > On Mon, Mar 01, 2021 at 02:56:40PM +0200, Maxim Levitsky wrote: > > On Mon, 2021-03-01 at 12:17 +0100, Paolo Bonzini wrote: > > > If kvm_arch_remove_sw_breakpoint finds that a software breakpoint does not > > > have an INT3 instruction,

Re: [PATCH] KVM: x86: do not fail if software breakpoint has already been removed

2021-03-02 Thread Stefano Garzarella
On Mon, Mar 01, 2021 at 02:56:40PM +0200, Maxim Levitsky wrote: On Mon, 2021-03-01 at 12:17 +0100, Paolo Bonzini wrote: If kvm_arch_remove_sw_breakpoint finds that a software breakpoint does not have an INT3 instruction, it fails. This can happen if one sets a software breakpoint in a kernel mo

Re: [PATCH] KVM: x86: do not fail if software breakpoint has already been removed

2021-03-01 Thread Maxim Levitsky
On Mon, 2021-03-01 at 12:17 +0100, Paolo Bonzini wrote: > If kvm_arch_remove_sw_breakpoint finds that a software breakpoint does not > have an INT3 instruction, it fails. This can happen if one sets a > software breakpoint in a kernel module and then reloads it. gdb then > thinks the breakpoint c

[PATCH] KVM: x86: do not fail if software breakpoint has already been removed

2021-03-01 Thread Paolo Bonzini
If kvm_arch_remove_sw_breakpoint finds that a software breakpoint does not have an INT3 instruction, it fails. This can happen if one sets a software breakpoint in a kernel module and then reloads it. gdb then thinks the breakpoint cannot be deleted and there is no way to add it back. Suggested-