Re: [PATCH] Initialize Zynq7000 UART clocks on reset

2021-01-13 Thread Michael Peter
Damien, On Wed, 2021-01-13 at 11:19 +0100, Damien Hedde wrote: > This is ok but I'm afraid we may end up doing this kind of thing in a > lot of devices. So maybe we should consider changing the behavior of > device_is_in_reset() so that it returns false in the reset-exit case. > What do you think

Re: [PATCH] Initialize Zynq7000 UART clocks on reset

2021-01-13 Thread Edgar E. Iglesias
On Wed, 13 Jan 2021, 11:19 Damien Hedde, wrote: > > This is ok but I'm afraid we may end up doing this kind of thing in a > lot of devices. So maybe we should consider changing the behavior of > device_is_in_reset() so that it returns false in the reset-exit case. > What do you think ? (I've a pa

Re: [PATCH] Initialize Zynq7000 UART clocks on reset

2021-01-13 Thread Damien Hedde
This is ok but I'm afraid we may end up doing this kind of thing in a lot of devices. So maybe we should consider changing the behavior of device_is_in_reset() so that it returns false in the reset-exit case. What do you think ? (I've a patch for this, which make this one useless) But this patch

Re: [PATCH] Initialize Zynq7000 UART clocks on reset

2021-01-07 Thread Peter Maydell
Alistair/Edgar/Damien -- could I get a review from one of you for this Xilinx clock-gen related patch, please? thanks -- PMM On Tue, 24 Nov 2020 at 18:54, Michael Peter wrote: > > Pass an additional argument to zynq_slcr_compute_clocks that indicates > whether an reset-exit condition > applies.

Re: [PATCH] Initialize Zynq7000 UART clocks on reset

2020-11-24 Thread Philippe Mathieu-Daudé
Cc'ing qemu-arm list too. On 11/24/20 5:52 PM, Michael Peter wrote: > Pass an additional argument to zynq_slcr_compute_clocks that indicates > whether an reset-exit condition > applies. If called from zynq_slcr_reset_exit, external clocks are > assumed to be active, even if the > device state indi

[PATCH] Initialize Zynq7000 UART clocks on reset

2020-11-24 Thread Michael Peter
Pass an additional argument to zynq_slcr_compute_clocks that indicates whether an reset-exit condition applies. If called from zynq_slcr_reset_exit, external clocks are assumed to be active, even if the device state indicates a reset state. Signed-off-by: Michael Peter --- hw/misc/zynq_slcr.c