Re: [PATCH] Cadence: gem: fix wraparound in 64bit descriptors

2020-04-17 Thread Ramon Fried
On Fri, Apr 17, 2020 at 4:37 PM Peter Maydell wrote: > > On Thu, 16 Apr 2020 at 10:02, Ramon Fried wrote: > > > > Wraparound of TX descriptor cyclic buffer only updated > > the low 32 bits of the descriptor. > > Fix that by checking if we're working with 64bit descriptors. > > > > Signed-off-by:

Re: [PATCH] Cadence: gem: fix wraparound in 64bit descriptors

2020-04-17 Thread Edgar E. Iglesias
On Thu, Apr 16, 2020 at 12:02:47PM +0300, Ramon Fried wrote: > Wraparound of TX descriptor cyclic buffer only updated > the low 32 bits of the descriptor. > Fix that by checking if we're working with 64bit descriptors. Looks good to me, so with the indentation fix that Peter mentioned: Reviewed-b

Re: [PATCH] Cadence: gem: fix wraparound in 64bit descriptors

2020-04-17 Thread Peter Maydell
On Thu, 16 Apr 2020 at 10:02, Ramon Fried wrote: > > Wraparound of TX descriptor cyclic buffer only updated > the low 32 bits of the descriptor. > Fix that by checking if we're working with 64bit descriptors. > > Signed-off-by: Ramon Fried > --- > hw/net/cadence_gem.c | 9 - > 1 file cha

Re: [PATCH] Cadence: gem: fix wraparound in 64bit descriptors

2020-04-16 Thread Philippe Mathieu-Daudé
On 4/16/20 11:39 AM, no-re...@patchew.org wrote: Patchew URL: https://patchew.org/QEMU/20200416090247.353414-1-rfried@gmail.com/ [...] ERROR:/tmp/qemu-test/src/tests/qtest/migration-test.c:1229:test_migrate_auto_converge: 'got_stop' should be FALSE ERROR - Bail out! ERROR:/tmp/qemu-test

Re: [PATCH] Cadence: gem: fix wraparound in 64bit descriptors

2020-04-16 Thread no-reply
Patchew URL: https://patchew.org/QEMU/20200416090247.353414-1-rfried@gmail.com/ Hi, This series failed the asan build test. Please find the testing commands and their output below. If you have Docker installed, you can probably reproduce it locally. === TEST SCRIPT BEGIN === #!/bin/bash e

[PATCH] Cadence: gem: fix wraparound in 64bit descriptors

2020-04-16 Thread Ramon Fried
Wraparound of TX descriptor cyclic buffer only updated the low 32 bits of the descriptor. Fix that by checking if we're working with 64bit descriptors. Signed-off-by: Ramon Fried --- hw/net/cadence_gem.c | 9 - 1 file changed, 8 insertions(+), 1 deletion(-) diff --git a/hw/net/cadence_g