Re: [PATCH] COLO-compare: Fix incorrect `if` logic

OK, thank you all :) Jason Wang writes: > On 2019/9/24 下午11:35, Philippe Mathieu-Daudé wrote: >> Hi Fan, >> >> you forgot to Cc the maintainers (doing that for you): >> >> ./scripts/get_maintainer.pl -f net/colo-compare.c >> Zhang Chen (supporter:COLO Proxy) >> Li Zhijian (supporter:COLO Proxy

Re: [PATCH] COLO-compare: Fix incorrect `if` logic

On 2019/9/24 下午11:35, Philippe Mathieu-Daudé wrote: > Hi Fan, > > you forgot to Cc the maintainers (doing that for you): > > ./scripts/get_maintainer.pl -f net/colo-compare.c > Zhang Chen (supporter:COLO Proxy) > Li Zhijian (supporter:COLO Proxy) > Jason Wang (maintainer:Network device ba...)

Re: [PATCH] COLO-compare: Fix incorrect `if` logic

Hi Fan, you forgot to Cc the maintainers (doing that for you): ./scripts/get_maintainer.pl -f net/colo-compare.c Zhang Chen (supporter:COLO Proxy) Li Zhijian (supporter:COLO Proxy) Jason Wang (maintainer:Network device ba...) qemu-devel@nongnu.org (open list:All patches CC here) On 9/24/19 4:

[PATCH] COLO-compare: Fix incorrect `if` logic

'colo_mark_tcp_pkt' should return 'true' when packets are the same, and 'false' otherwise. However, it returns 'true' when 'colo_compare_packet_payload' returns non-zero while 'colo_compare_packet_payload' is just a 'memcmp'. The result is that COLO-compare reports inconsistent TCP packets when t