Re: [PATCH] Allow acpi-tmr size=2

2020-07-14 Thread Michael S. Tsirkin
On Tue, Jul 14, 2020 at 12:55:44PM +0200, Philippe Mathieu-Daudé wrote: > +Peter/Paolo > > On 7/13/20 1:14 PM, Michael S. Tsirkin wrote: > > On Mon, Jul 13, 2020 at 10:20:12AM +0300, Michael Tokarev wrote: > >> 12.07.2020 15:00, Simon John wrote: > >>> macos guests no longer boot after commit > >

Re: [PATCH] Allow acpi-tmr size=2

2020-07-14 Thread Philippe Mathieu-Daudé
+Peter/Paolo On 7/13/20 1:14 PM, Michael S. Tsirkin wrote: > On Mon, Jul 13, 2020 at 10:20:12AM +0300, Michael Tokarev wrote: >> 12.07.2020 15:00, Simon John wrote: >>> macos guests no longer boot after commit >>> 5d971f9e672507210e77d020d89e0e89165c8fc9 >>> >>> acpi-tmr needs 2 byte memory acces

Re: [PATCH] Allow acpi-tmr size=2

2020-07-14 Thread Michael S. Tsirkin
On Mon, Jul 13, 2020 at 10:20:12AM +0300, Michael Tokarev wrote: > 12.07.2020 15:00, Simon John wrote: > > macos guests no longer boot after commit > > 5d971f9e672507210e77d020d89e0e89165c8fc9 > > > > acpi-tmr needs 2 byte memory accesses, so breaks as that commit only allows > > 4 bytes. > > >

Re: [PATCH] Allow acpi-tmr size=2

2020-07-14 Thread Michael S. Tsirkin
On Mon, Jul 13, 2020 at 05:16:56PM +0300, Michael Tokarev wrote: > 13.07.2020 15:17, Michael S. Tsirkin пишет: > > On Mon, Jul 13, 2020 at 12:46:00PM +0100, Simon John wrote: > >> I don't profess to understand most of this, I am just a user who found > >> something didn't work and tracked down the

Re: [PATCH] Allow acpi-tmr size=2

2020-07-13 Thread Michael Tokarev
13.07.2020 15:17, Michael S. Tsirkin пишет: > On Mon, Jul 13, 2020 at 12:46:00PM +0100, Simon John wrote: >> I don't profess to understand most of this, I am just a user who found >> something didn't work and tracked down the cause with help from the people >> on the bugtracker. >> >> the min=1 and

Re: [PATCH] Allow acpi-tmr size=2

2020-07-13 Thread Simon John
On Mon, 13 Jul 2020 08:17:41 -0400, Michael S. Tsirkin wrote: Sounds good. And how about also adding: .impl.min_access_size = 4, ? Yes, this works too - what does that do? static const MemoryRegionOps acpi_pm_tmr_ops = { .read = acpi_pm_tmr_read, .write = acpi_pm_tmr_write,

Re: [PATCH] Allow acpi-tmr size=2

2020-07-13 Thread Simon John
I don't profess to understand most of this, I am just a user who found something didn't work and tracked down the cause with help from the people on the bugtracker. the min=1 and max=4 was chosen as it seems to be set that way in most other places in the source, and 2 fits in that range. so

Re: [PATCH] Allow acpi-tmr size=2

2020-07-13 Thread Michael S. Tsirkin
On Mon, Jul 13, 2020 at 12:46:00PM +0100, Simon John wrote: > I don't profess to understand most of this, I am just a user who found > something didn't work and tracked down the cause with help from the people > on the bugtracker. > > the min=1 and max=4 was chosen as it seems to be set that way i

Re: [PATCH] Allow acpi-tmr size=2

2020-07-13 Thread Michael S. Tsirkin
On Mon, Jul 13, 2020 at 10:20:12AM +0300, Michael Tokarev wrote: > 12.07.2020 15:00, Simon John wrote: > > macos guests no longer boot after commit > > 5d971f9e672507210e77d020d89e0e89165c8fc9 > > > > acpi-tmr needs 2 byte memory accesses, so breaks as that commit only allows > > 4 bytes. > > >

Re: [PATCH] Allow acpi-tmr size=2

2020-07-13 Thread Michael S. Tsirkin
On Mon, Jul 13, 2020 at 10:43:19AM +0300, Michael Tokarev wrote: > 13.07.2020 10:20, Michael Tokarev пишет: > > 12.07.2020 15:00, Simon John wrote: > >> macos guests no longer boot after commit > >> 5d971f9e672507210e77d020d89e0e89165c8fc9 > >> > >> acpi-tmr needs 2 byte memory accesses, so breaks

Re: [PATCH] Allow acpi-tmr size=2

2020-07-13 Thread Michael Tokarev
13.07.2020 10:20, Michael Tokarev пишет: > 12.07.2020 15:00, Simon John wrote: >> macos guests no longer boot after commit >> 5d971f9e672507210e77d020d89e0e89165c8fc9 >> >> acpi-tmr needs 2 byte memory accesses, so breaks as that commit only allows >> 4 bytes. >> >> Fixes: 5d971f9e672507210e7 (me

Re: [PATCH] Allow acpi-tmr size=2

2020-07-13 Thread Michael Tokarev
12.07.2020 15:00, Simon John wrote: > macos guests no longer boot after commit > 5d971f9e672507210e77d020d89e0e89165c8fc9 > > acpi-tmr needs 2 byte memory accesses, so breaks as that commit only allows 4 > bytes. > > Fixes: 5d971f9e672507210e7 (memory: Revert "memory: accept mismatching sizes

[PATCH] Allow acpi-tmr size=2

2020-07-12 Thread Simon John
macos guests no longer boot after commit 5d971f9e672507210e77d020d89e0e89165c8fc9 acpi-tmr needs 2 byte memory accesses, so breaks as that commit only allows 4 bytes. Fixes: 5d971f9e672507210e7 (memory: Revert "memory: accept mismatching sizes in memory_region_access_valid") Buglink: https: