Re: [PATCH] ACPI: Assert that we don't run out of the preallocated memory

2020-07-24 Thread Peter Maydell
On Fri, 24 Jul 2020 at 13:55, Michael S. Tsirkin wrote: > > On Thu, Jul 23, 2020 at 06:50:06PM +0100, Peter Maydell wrote: > > On Mon, 22 Jun 2020 at 12:30, Dongjiu Geng wrote: > > > > > > data_length is a constant value, so we use assert instead of > > > condition check. > > > > > > Signed-off-b

Re: [PATCH] ACPI: Assert that we don't run out of the preallocated memory

2020-07-24 Thread Michael S. Tsirkin
On Thu, Jul 23, 2020 at 06:50:06PM +0100, Peter Maydell wrote: > On Mon, 22 Jun 2020 at 12:30, Dongjiu Geng wrote: > > > > data_length is a constant value, so we use assert instead of > > condition check. > > > > Signed-off-by: Dongjiu Geng > > --- > > 1. Address Peter and Michael's comments to u

Re: [PATCH] ACPI: Assert that we don't run out of the preallocated memory

2020-07-23 Thread Peter Maydell
On Mon, 22 Jun 2020 at 12:30, Dongjiu Geng wrote: > > data_length is a constant value, so we use assert instead of > condition check. > > Signed-off-by: Dongjiu Geng > --- > 1. Address Peter and Michael's comments to use assert instead of if(). > https://lore.kernel.org/qemu-devel/ca79ea28-9ea9-1

[PATCH] ACPI: Assert that we don't run out of the preallocated memory

2020-06-22 Thread Dongjiu Geng
data_length is a constant value, so we use assert instead of condition check. Signed-off-by: Dongjiu Geng --- 1. Address Peter and Michael's comments to use assert instead of if(). https://lore.kernel.org/qemu-devel/ca79ea28-9ea9-18a5-99ad-25c3eb744...@huawei.com/ --- hw/acpi/ghes.c | 12 ---