Re: [PATC 7/9] Skipping drm build, unsupported

On Wed, 1 Jul 2020 at 16:15, Gerd Hoffmann wrote: > > > > Ah, that is the problem. Yes, DT_CHR is an non-posix optimization which > > > allows to get the file type directly, without another round-trip to the > > > kernel. If that isn't available you can stat() the file and check > > > ((st_mode

Re: [PATC 7/9] Skipping drm build, unsupported

Hi Gerd, On 7/1/20 5:15 PM, Gerd Hoffmann wrote: >>> Ah, that is the problem. Yes, DT_CHR is an non-posix optimization which >>> allows to get the file type directly, without another round-trip to the >>> kernel. If that isn't available you can stat() the file and check >>> ((st_mode & S_IFMT) =

Re: [PATC 7/9] Skipping drm build, unsupported

Yes it does. Regards. On Wed, 1 Jul 2020 at 16:15, Gerd Hoffmann wrote: > > > > Ah, that is the problem. Yes, DT_CHR is an non-posix optimization which > > > allows to get the file type directly, without another round-trip to the > > > kernel. If that isn't available you can stat() the file and

Re: [PATC 7/9] Skipping drm build, unsupported

> > Ah, that is the problem. Yes, DT_CHR is an non-posix optimization which > > allows to get the file type directly, without another round-trip to the > > kernel. If that isn't available you can stat() the file and check > > ((st_mode & S_IFMT) == S_IFCHR) instead. > > Even when d_type and DT_C

Re: [PATC 7/9] Skipping drm build, unsupported

On 6/30/20 11:53 AM, Gerd Hoffmann wrote: -util-obj-$(CONFIG_POSIX) += drm.o +util-obj-$(CONFIG_LINUX) += drm.o Can't see anything linux-specific there. Also note that FreeBSD (and possibly other *BSDs too) have drm support. So CONFIG_POSIX looks correct to me. This change was my suggestion

Re: [PATC 7/9] Skipping drm build, unsupported

> > > > -util-obj-$(CONFIG_POSIX) += drm.o > > > > +util-obj-$(CONFIG_LINUX) += drm.o > > > > Can't see anything linux-specific there. Also note that FreeBSD (and > > possibly other *BSDs too) have drm support. So CONFIG_POSIX looks > > correct to me. > > This change was my suggestion; I assumed

Re: [PATC 7/9] Skipping drm build, unsupported

Otherwise, if it is ok if not all patches are accepted (like this one) but at least most of them would be nice then Haikuport can decrease needed local patches. Regards. On Tue, 30 Jun 2020 at 16:55, David CARLIER wrote: > > 1/ It does not compile on Haiku has dirent does not contain d_type > fi

Re: [PATC 7/9] Skipping drm build, unsupported

1/ It does not compile on Haiku has dirent does not contain d_type field (among other things). 2/ does not support drm anyway. 3/ Haiku is less portable than a illumos or NetBSD system, even with the BSD compatibility layer. On Tue, 30 Jun 2020 at 16:48, Gerd Hoffmann wrote: > > On Tue, Jun 30, 2

Re: [PATC 7/9] Skipping drm build, unsupported

On Tue, 30 Jun 2020 at 09:24, Gerd Hoffmann wrote: > > On Tue, Jun 30, 2020 at 08:44:24AM +0200, Philippe Mathieu-Daudé wrote: > > +Gerd > > > > On 6/29/20 11:48 PM, David CARLIER wrote: > > > From 157a0374093371719de42e99364352d64190f52a Mon Sep 17 00:00:00 2001 > > > From: David Carlier > > > D

Re: [PATC 7/9] Skipping drm build, unsupported

On Tue, Jun 30, 2020 at 10:46:59AM +0200, Philippe Mathieu-Daudé wrote: > On 6/30/20 10:23 AM, Gerd Hoffmann wrote: > > On Tue, Jun 30, 2020 at 08:44:24AM +0200, Philippe Mathieu-Daudé wrote: > >> +Gerd > >> > >> On 6/29/20 11:48 PM, David CARLIER wrote: > >>> From 157a0374093371719de42e9936435

Re: [PATC 7/9] Skipping drm build, unsupported

On 6/30/20 10:23 AM, Gerd Hoffmann wrote: > On Tue, Jun 30, 2020 at 08:44:24AM +0200, Philippe Mathieu-Daudé wrote: >> +Gerd >> >> On 6/29/20 11:48 PM, David CARLIER wrote: >>> From 157a0374093371719de42e99364352d64190f52a Mon Sep 17 00:00:00 2001 >>> From: David Carlier >>> Date: Mon, 29 Jun 202

Re: [PATC 7/9] Skipping drm build, unsupported

On Tue, Jun 30, 2020 at 08:44:24AM +0200, Philippe Mathieu-Daudé wrote: > +Gerd > > On 6/29/20 11:48 PM, David CARLIER wrote: > > From 157a0374093371719de42e99364352d64190f52a Mon Sep 17 00:00:00 2001 > > From: David Carlier > > Date: Mon, 29 Jun 2020 22:20:06 + > > Subject: [PATCH 7/9] Skip

Re: [PATC 7/9] Skipping drm build, unsupported

+Gerd On 6/29/20 11:48 PM, David CARLIER wrote: > From 157a0374093371719de42e99364352d64190f52a Mon Sep 17 00:00:00 2001 > From: David Carlier > Date: Mon, 29 Jun 2020 22:20:06 + > Subject: [PATCH 7/9] Skipping drm build, unsupported. > > Signed-off-by: David Carlier Reviewed-by: Philippe

[PATC 7/9] Skipping drm build, unsupported

>From 157a0374093371719de42e99364352d64190f52a Mon Sep 17 00:00:00 2001 From: David Carlier Date: Mon, 29 Jun 2020 22:20:06 + Subject: [PATCH 7/9] Skipping drm build, unsupported. Signed-off-by: David Carlier --- util/Makefile.objs | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff