Re: [Bug Report] Possible Missing Endianness Conversion

2024-07-01 Thread Stefano Garzarella
On Fri, Jun 28, 2024 at 03:53:09PM GMT, Peter Maydell wrote: On Tue, 25 Jun 2024 at 08:18, Stefano Garzarella wrote: On Mon, Jun 24, 2024 at 04:19:52PM GMT, Peter Maydell wrote: >On Mon, 24 Jun 2024 at 16:11, Stefano Garzarella wrote: >> >> CCing Jason. >> >> On Mon, Jun 24, 2024 at 4:30 PM X

Re: [Bug Report] Possible Missing Endianness Conversion

2024-06-28 Thread Peter Maydell
On Tue, 25 Jun 2024 at 08:18, Stefano Garzarella wrote: > > On Mon, Jun 24, 2024 at 04:19:52PM GMT, Peter Maydell wrote: > >On Mon, 24 Jun 2024 at 16:11, Stefano Garzarella wrote: > >> > >> CCing Jason. > >> > >> On Mon, Jun 24, 2024 at 4:30 PM Xoykie wrote: > >> > > >> > The virtio packed virtq

Re: [Bug Report] Possible Missing Endianness Conversion

2024-06-25 Thread Stefano Garzarella
On Mon, Jun 24, 2024 at 04:19:52PM GMT, Peter Maydell wrote: On Mon, 24 Jun 2024 at 16:11, Stefano Garzarella wrote: CCing Jason. On Mon, Jun 24, 2024 at 4:30 PM Xoykie wrote: > > The virtio packed virtqueue support patch[1] suggests converting > endianness by lines: > > virtio_tswap16s(vdev

[Bug Report] Possible Missing Endianness Conversion

2024-06-24 Thread Xoykie
The virtio packed virtqueue support patch[1] suggests converting endianness by lines: virtio_tswap16s(vdev, &e->off_wrap); virtio_tswap16s(vdev, &e->flags); Though both of these conversion statements aren't present in the latest qemu code here[2] Is this intentional? [1]: https://mail.gnu.org/a

Re: [Bug Report] Possible Missing Endianness Conversion

2024-06-24 Thread Peter Maydell
On Mon, 24 Jun 2024 at 16:11, Stefano Garzarella wrote: > > CCing Jason. > > On Mon, Jun 24, 2024 at 4:30 PM Xoykie wrote: > > > > The virtio packed virtqueue support patch[1] suggests converting > > endianness by lines: > > > > virtio_tswap16s(vdev, &e->off_wrap); > > virtio_tswap16s(vdev, &e->f

Re: [Bug Report] Possible Missing Endianness Conversion

2024-06-24 Thread Stefano Garzarella
CCing Jason. On Mon, Jun 24, 2024 at 4:30 PM Xoykie wrote: > > The virtio packed virtqueue support patch[1] suggests converting > endianness by lines: > > virtio_tswap16s(vdev, &e->off_wrap); > virtio_tswap16s(vdev, &e->flags); > > Though both of these conversion statements aren't present in the