[Bug 1919036] Re: Assertion failure in fifo8_push_all() through am53c974

2021-04-30 Thread Thomas Huth
** Changed in: qemu Status: Fix Committed => Fix Released -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1919036 Title: Assertion failure in fifo8_push_all() through am53c974 Status in QEMU:

[Bug 1919036] Re: Assertion failure in fifo8_push_all() through am53c974

2021-04-18 Thread Thomas Huth
** Changed in: qemu Status: Fix Released => Fix Committed -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1919036 Title: Assertion failure in fifo8_push_all() through am53c974 Status in QEMU:

[Bug 1919036] Re: Assertion failure in fifo8_push_all() through am53c974

2021-04-14 Thread Mauro Matteo Cascella
I'm not able to change the status of this bug anymore. It should have been closed as "Fix committed" - QEMU 6.0.0 is not yet released. -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1919036 Title: A

[Bug 1919036] Re: Assertion failure in fifo8_push_all() through am53c974

2021-04-14 Thread Mauro Matteo Cascella
This is fixed now, thank you Mark. Patchset v4: https://lists.gnu.org/archive/html/qemu-devel/2021-04/msg01000.html Upstream commits: https://git.qemu.org/?p=qemu.git;a=commit;h=0db895361b8a82e1114372ff9f48 https://git.qemu.org/?p=qemu.git;a=commit;h=e392255766071c8cac480da3a9ae https://git.qemu.

[Bug 1919036] Re: Assertion failure in fifo8_push_all() through am53c974

2021-03-17 Thread Mark Cave-Ayland
Thank you both for the reproducers. Please see the proposed patchset here: https://lists.gnu.org/archive/html/qemu-devel/2021-03/msg06063.html -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1919036 T

[Bug 1919036] Re: Assertion failure in fifo8_push_all() through am53c974

2021-03-14 Thread Cheolwoo,Myung
Hello Mark, I tested on fixed version, and checked that it does not trigger the assertion failure. Thanks, - Cheolwoo Myung -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1919036 Title: Assertion

[Bug 1919036] Re: Assertion failure in fifo8_push_all() through am53c974

2021-03-14 Thread Alexander Bulekov
QTest Reproducer: /* * Autogenerated Fuzzer Test Case * * This work is licensed under the terms of the GNU GPL, version 2 or * later. See the COPYING file in the top-level directory. */ #include "qemu/osdep.h" #include "libqos/libqtest.h" /* * cat << EOF | ./qemu-system-i386 -display none

Re: [Bug 1919036] Re: Assertion failure in fifo8_push_all() through am53c974

2021-03-14 Thread no-reply
...@soybean.canonical.com Subject: [Bug 1919036] Re: Assertion failure in fifo8_push_all() through am53c974 === TEST SCRIPT BEGIN === #!/bin/bash git rev-parse base > /dev/null || exit 0 git config --local diff.renamelimit 0 git config --local diff.renames True git config --local diff.algorithm histogram ./scri

[Bug 1919036] Re: Assertion failure in fifo8_push_all() through am53c974

2021-03-14 Thread Mark Cave-Ayland
Thanks for the test case - looks like the problem occurs because a command hasn't been submitted before initiating a DMA transfer, and TC is set to a value higher than the size of cmdfifo. Can you confirm that the following fix works for you? diff --git a/hw/scsi/esp.c b/hw/scsi/esp.c index 507ab3