> -Original Message-
> From: Philippe Mathieu-Daudé
> Sent: Tuesday, December 14, 2021 6:18 PM
> To: Daniel P. Berrangé
> Cc: zhanghailiang ; qemu-devel@nongnu.org;
> Gonglei ; Wen Congyang
> ; dgilb...@redhat.com; quint...@redhat.com
> Subject: Re: [PATCH v2
Yes.
I'll tell Gonglei to help confirm this patch. 😉
Thanks.
-Original Message-
From: Philippe Mathieu-Daudé
Sent: Tuesday, December 14, 2021 5:04 PM
To: zhanghailiang ; qemu-devel@nongnu.org; Gonglei
; Wen Congyang
Cc: dgilb...@redhat.com; quint...@redhat.com
Subject: Re: [
Hi zhengchuan,
> -Original Message-
> From: zhengchuan
> Sent: Saturday, October 17, 2020 12:26 PM
> To: quint...@redhat.com; dgilb...@redhat.com
> Cc: Zhanghailiang ; Chenzhendong (alex)
> ; Xiexiangyou ; wanghao
> (O) ; yubihong ;
> fengzhim...@huawei.co
> -Original Message-
> From: Derek Su [mailto:jwsu1...@gmail.com]
> Sent: Thursday, August 13, 2020 6:28 PM
> To: Lukas Straub
> Cc: Derek Su ; qemu-devel@nongnu.org; Zhanghailiang
> ; chy...@qnap.com; quint...@redhat.com;
> dgilb...@redhat.com; ctch...@qnap.com
>
perfect enough
To be accepted as quickly as possible. ;)
Thanks,
Hailiang
> -Original Message-
> From: Dr. David Alan Gilbert [mailto:dgilb...@redhat.com]
> Sent: Tuesday, July 28, 2020 1:00 AM
> To: Denis Plotnikov ; da...@redhat.com;
> Zhanghailiang
> Cc: qemu-devel@
Hi Lukas Straub & Derek,
Sorry for the late reply, too busy these days ;)
> -Original Message-
> From: Lukas Straub [mailto:lukasstra...@web.de]
> Sent: Friday, July 31, 2020 3:52 PM
> To: Derek Su
> Cc: qemu-devel@nongnu.org; Zhanghailiang
> ; chy...@qnap.com;
Reviewed-by: zhanghailiang
> -Original Message-
> From: Markus Armbruster [mailto:arm...@redhat.com]
> Sent: Monday, June 22, 2020 6:43 PM
> To: qemu-devel@nongnu.org
> Cc: Michael Roth ; Zhanghailiang
>
> Subject: [PATCH 08/22] qga: Plug unlikely memory leak
> -Original Message-
> From: Markus Armbruster [mailto:arm...@redhat.com]
> Sent: Thursday, June 18, 2020 1:36 PM
> To: Zhanghailiang
> Cc: qemu-devel@nongnu.org; Michael Roth
> Subject: Memory leak in transfer_memory_block()?
>
> We appear to l
Reviewed-by: zhanghailiang
> -Original Message-
> From: Like Xu [mailto:like...@linux.intel.com]
> Sent: Sunday, June 14, 2020 4:45 PM
> To: qemu-devel@nongnu.org
> Cc: Like Xu ; Zhanghailiang
>
> Subject: [PATCH 1/2] migration/colo: fix typo in the COLO Frame
I have checked this patch in mail archive, it has no problem,
It seems that my email setup has some problem. It didn't show the right newline
In this patch.
> -Original Message-
> From: Like Xu [mailto:like...@linux.intel.com]
> Sent: Monday, June 15, 2020 10:24 AM
>
t; To: qemu-devel@nongnu.org
> Cc: Like Xu ; Zhanghailiang
>
> Subject: [PATCH 1/2] migration/colo: fix typo in the COLO Framework
> module
>
> Cc: Hailiang Zhang
> Signed-off-by: Like Xu
> ---
> docs/COLO-FT.txt | 8
> migration/colo.c | 2 +-
> 2 files changed,
> -Original Message-
> From: Zhang, Chen [mailto:chen.zh...@intel.com]
> Sent: Wednesday, June 3, 2020 5:11 PM
> To: Zhanghailiang ; Dr . David Alan
> Gilbert ; Juan Quintela ;
> qemu-dev
> Cc: Zhang Chen ; Jason Wang
>
> Subject: RE: [PATCH 3/3] migration/c
> -Original Message-
> From: Zhang Chen [mailto:chen.zh...@intel.com]
> Sent: Friday, May 15, 2020 12:28 PM
> To: Dr . David Alan Gilbert ; Juan Quintela
> ; Zhanghailiang ;
> qemu-dev
> Cc: Zhang Chen ; Jason Wang
> ; Zhang Chen
> Subject: [PATCH 3/3]
Reviewed-by: zhanghailiang
Hmm, How much time it spends on preparing before COLO process ?
> -Original Message-
> From: Zhang Chen [mailto:chen.zh...@intel.com]
> Sent: Friday, May 15, 2020 12:28 PM
> To: Dr . David Alan Gilbert ; Juan Quintela
> ; Zhanghailiang ;
&
Reviewed-by: zhanghailiang
> -Original Message-
> From: Zhang Chen [mailto:chen.zh...@intel.com]
> Sent: Friday, May 15, 2020 12:28 PM
> To: Dr . David Alan Gilbert ; Juan Quintela
> ; Zhanghailiang ;
> qemu-dev
> Cc: Zhang Chen ; Jason Wang
> ; Zhang Che
Hi,
I can't reproduce this issue with the qemu upstream either,
It works well.
Did you use an old version ?
Thanks,
Hailiang
> -Original Message-
> From: Lukas Straub [mailto:lukasstra...@web.de]
> Sent: Friday, May 15, 2020 3:12 PM
> To: Zhang, Chen
> Cc: Zhangh
Reviewed-by: zhanghailiang
> -Original Message-
> From: Lukas Straub [mailto:lukasstra...@web.de]
> Sent: Monday, May 11, 2020 7:11 PM
> To: qemu-devel
> Cc: Zhanghailiang ; Juan Quintela
> ; Dr. David Alan Gilbert
> Subject: [PATCH 4/6] migration/colo.c: Rela
Hi Zhang Chen,
>From your tracing log, it seems to be hanged in colo_flush_ram_cache()?
Does it come across a dead loop there ?
I'll test it by using the new qemu.
Thanks,
Hailiang
From: Zhang, Chen [mailto:chen.zh...@intel.com]
Sent: Friday, May 15, 2020 11:16 AM
To: Zhanghailiang ; Dr
Reviewed-by: zhanghailiang
> -Original Message-
> From: Lukas Straub [mailto:lukasstra...@web.de]
> Sent: Monday, May 11, 2020 7:11 PM
> To: qemu-devel
> Cc: Zhanghailiang ; Juan Quintela
> ; Dr. David Alan Gilbert
> Subject: [PATCH 6/6] m
> -Original Message-
> From: Lukas Straub [mailto:lukasstra...@web.de]
> Sent: Thursday, May 14, 2020 10:31 PM
> To: Zhanghailiang
> Cc: qemu-devel ; Zhang Chen
> ; Juan Quintela ; Dr. David
> Alan Gilbert
> Subject: Re: [PATCH 6/6] migration/colo.c: Move
> co
Cc: Zhang Chen
>
> If the secondary has to failover during checkpointing, it still is in the old
> state
> (i.e. different state than primary). Thus we can't expose the primary state
> until after the checkpoint is sent.
>
Hmm, do you mean we should not flush the net packages to client connec
> This causes the migration thread to hang if we failover during checkpoint. A
> shutdown fd won't cause network traffic anyway.
>
I'm not quite sure if this modification can take side effect on normal
migration process or not,
There are several places calling it.
Maybe Juan and Dave can help ;
Reviewed-by: zhanghailiang
>
> If we suceed in receiving ram state, but fail receiving the device state,
> there
> will be a mismatch between the two.
>
> Fix this by flushing the ram cache only after the vmstate has been received.
>
> Signed-off-by: Lukas Straub
&
> If multiple packets miscompare in a short timeframe, the semaphore value
> will be increased multiple times. This causes multiple checkpoints even if one
> would be sufficient.
>
You right, good catch ;)
Reviewed-by: zhanghailiang
> Fix this by using a event instead of
Reviewed-by: zhanghailiang
> -Original Message-
> From: Markus Armbruster [mailto:arm...@redhat.com]
> Sent: Monday, April 20, 2020 4:33 PM
> To: qemu-devel@nongnu.org
> Cc: Zhang Chen ; Zhanghailiang
>
> Subject: [PATCH 11/11] migration/colo: Fix qmp_xen_colo_do
M's ram,
so it should be double amount.
Thanks,
Hailiang
-邮件原件-
发件人: Lukas Straub [mailto:lukasstra...@web.de]
发送时间: 2020年4月12日 1:17
收件人: qemu-devel@nongnu.org
抄送: dgilb...@redhat.com; quint...@redhat.com; Zhanghailiang
; Zhang Chen
主题: colo: qemu 4.2.0 vs. qemu 5.0.0-rc2 pe
Hi,
> -Original Message-
> From: Daniel Cho [mailto:daniel...@qnap.com]
> Sent: Tuesday, February 25, 2020 10:53 AM
> To: Zhanghailiang
> Cc: qemu-devel@nongnu.org; quint...@redhat.com; Dr. David Alan Gilbert
>
> Subject: Re: [PATCH V2 4/8] COLO: Optimize memory ba
> -Original Message-
> From: Eric Blake [mailto:ebl...@redhat.com]
> Sent: Monday, February 24, 2020 11:19 PM
> To: Zhanghailiang ;
> qemu-devel@nongnu.org
> Cc: daniel...@qnap.com; dgilb...@redhat.com; quint...@redhat.com
> Subject: Re: [PATCH V2 7/8] COLO: Migra
Hi Daniel,
I have fixed this problem, and send V2, please refer to that series.
Thanks,
From: Daniel Cho [mailto:daniel...@qnap.com]
Sent: Thursday, February 20, 2020 11:52 AM
To: Zhang, Chen
Cc: Dr. David Alan Gilbert ; Zhanghailiang
; qemu-devel@nongnu.org; Jason Wang
Subject: Re: The
We can migrate some dirty pages during the gap of checkpointing,
by this way, we can reduce the amount of ram migrated during checkpointing.
Signed-off-by: zhanghailiang
---
migration/colo.c | 73 --
migration/migration.h | 1 +
migration/trace
After add migrating ram backgroud, we will call ram_load
for this process, but we should not flush ram cache during
this process. Move the flush action to the right place.
Signed-off-by: zhanghailiang
---
migration/colo.c | 1 +
migration/ram.c | 5 +
migration/ram.h | 1 +
3 files
, though it affects the speed of the
migration, but it obviously reduce the downtime of back-up all SVM'S
memory in COLO preparing stage.
Signed-off-by: zhanghailiang
---
migration/colo.c | 3 +++
migration/ram.c | 68 +++-
migration/ram.h | 1 +
3
This helper has been called twice which is wrong.
Left the one where called while get COLO enable message
from source side.
Signed-off-by: zhanghailiang
---
migration/migration.c | 5 -
1 file changed, 5 deletions(-)
diff --git a/migration/migration.c b/migration/migration.c
index
Split checkpoint incoming process into a helper.
Signed-off-by: zhanghailiang
Reviewed-by: Dr. David Alan Gilbert
---
migration/colo.c | 260 ---
1 file changed, 133 insertions(+), 127 deletions(-)
diff --git a/migration/colo.c b/migration/colo.c
This series try to tries to reduce VM's pause time while do checkpoint in COLO
state.
Here, we use two methods to reduce the downtime during COLO stage:
The first one is to reduce the time of backup PVM's memory into cache,
Instread of doing this once time backup all PVM's memory when VM is stop
ess as an exception,
Maybe we need a better way to fix it.
Cc: Juan Quintela
Signed-off-by: zhanghailiang
---
migration/migration.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/migration/migration.c b/migration/migration.c
index 8fb68795dc..06d1ff9d56 100644
--- a/migration/migratio
We will migrate parts of dirty pages backgroud lively during the gap time
of two checkpoints, without this modification, it will not work
because ram_save_iterate() will check it before send RAM_SAVE_FLAG_EOS
at the end of it.
Signed-off-by: zhanghailiang
---
migration/migration.c | 1 +
1 file
It is only need to record bitmap of dirty pages while goes
into COLO stage.
Signed-off-by: zhanghailiang
---
migration/ram.c | 9 +
1 file changed, 5 insertions(+), 4 deletions(-)
diff --git a/migration/ram.c b/migration/ram.c
index ebf9e6ba51..1b3f423351 100644
--- a/migration/ram.c
Hi Dave,
> -Original Message-
> From: Dr. David Alan Gilbert [mailto:dgilb...@redhat.com]
> Sent: Friday, February 21, 2020 2:25 AM
> To: Zhanghailiang
> Cc: qemu-devel@nongnu.org; quint...@redhat.com; chen.zh...@intel.com;
> daniel...@qnap.com
> Subject: Re: [PATC
> -Original Message-
> From: Dr. David Alan Gilbert [mailto:dgilb...@redhat.com]
> Sent: Thursday, February 20, 2020 2:51 AM
> To: Zhanghailiang
> Cc: qemu-devel@nongnu.org; quint...@redhat.com; chen.zh...@intel.com;
> daniel...@qnap.com
> Subject: Re: [PATCH 2/3
ruary 15, 2020 11:36 AM
To: Dr. David Alan Gilbert
Cc: Zhang, Chen ; Zhanghailiang
; qemu-devel@nongnu.org; Jason Wang
Subject: Re: The issues about architecture of the COLO checkpoint
Hi Dave,
Yes, I agree with you, it does need a timeout.
Hi Hailiang,
We base on qemu-4.1.0 for using COLO fe
SVM’s to compare before send this packets to client.
It depends on this to decide whether or not PVM and SVM are in same state.
Thanks,
hailiang
From: Daniel Cho [mailto:daniel...@qnap.com]
Sent: Wednesday, February 12, 2020 4:37 PM
To: Zhang, Chen
Cc: Zhanghailiang ; Dr. David Alan Gilbert
; qemu
Hi Zhang Chen,
> -Original Message-
> From: Zhang, Chen [mailto:chen.zh...@intel.com]
> Sent: Wednesday, February 12, 2020 1:45 PM
> To: Zhanghailiang ; Dr. David Alan
> Gilbert ; Daniel Cho
> Cc: qemu-devel@nongnu.org
> Subject: RE: The issues about architecture o
Hi,
Thank you Dave,
I'll reply here directly.
-Original Message-
From: Dr. David Alan Gilbert [mailto:dgilb...@redhat.com]
Sent: Wednesday, February 12, 2020 1:48 AM
To: Daniel Cho ; chen.zh...@intel.com; Zhanghailiang
Cc: qemu-devel@nongnu.org
Subject: Re: The issues
Hi，
We hit a bug in our test while run PCMark 10 in a windows 7 VM,
The VM got stuck and the wallclock was hang after several minutes running
PCMark 10 in it.
It is quite easily to reproduce the bug with the upstream KVM and Qemu.
We found that KVM can not inject any RTC irq to VM after it was ha
Signed-off-by: zhanghailiang
---
net/filter-rewriter.c | 39 +++
1 file changed, 39 insertions(+)
diff --git a/net/filter-rewriter.c b/net/filter-rewriter.c
index c9a6d43..0a90b11 100644
--- a/net/filter-rewriter.c
+++ b/net/filter-rewriter.c
@@ -22,6 +22,7
Filter needs to process the event of checkpoint/failover or
other event passed by COLO frame.
Cc: Jason Wang
Signed-off-by: zhanghailiang
---
include/net/filter.h | 5 +
net/filter.c | 16
net/net.c| 28
3 files changed, 49
all content of PVM's RAM cache into SVM's MEMORY,
we do this in a more efficient way:
Only flush any page that dirtied by PVM since last checkpoint.
In this way, we can ensure SVM's memory same with PVM's.
Besides, we must ensure flush RAM cache before load device state.
Cc
Don't need to flush all VM's ram from cache, only
flush the dirty pages since last checkpoint
Cc: Juan Quintela
Signed-off-by: Li Zhijian
Signed-off-by: Zhang Chen
Signed-off-by: zhanghailiang
---
v2:
- stop dirty log after exit from COLO state. (Dave)
---
migration/
is still necessary to notify users that we exited COLO mode.
Cc: Markus Armbruster
Cc: Michael Roth
Signed-off-by: zhanghailiang
Signed-off-by: Li Zhijian
Reviewed-by: Eric Blake
---
migration/colo.c | 19 +++
qapi-schema.json | 14 ++
qapi/event.json | 21 +++
Make sure master start block replication after slave's block
replication started.
Besides, we need to activate VM's blocks before goes into
COLO state.
Signed-off-by: zhanghailiang
Signed-off-by: Li Zhijian
Cc: Stefan Hajnoczi
Cc: Kevin Wolf
Cc: Max Reitz
Cc: Xie Changlong
---
While do checkpoint, we need to flush all the unhandled packets,
By using the filter notifier mechanism, we can easily to notify
every compare object to do this process, which runs inside
of compare threads as a coroutine.
Cc: Jason Wang
Signed-off-by: zhanghailiang
Signed-off-by: Zhang Chen
tate.
Cc: Dr. David Alan Gilbert
Signed-off-by: zhanghailiang
Signed-off-by: Li Zhijian
---
v2:
- Move colo_init_ram_cache() and colo_release_ram_cache() out of
incoming thread since both of them need the global lock, if we keep
colo_release_ram_cache() in incoming thread, there are potential
Notify all net filters about the checkpoint and failover event.
Cc: Jason Wang
Signed-off-by: zhanghailiang
---
migration/colo.c | 13 +
1 file changed, 13 insertions(+)
diff --git a/migration/colo.c b/migration/colo.c
index 66bb5b2..62f58c6 100644
--- a/migration/colo.c
+++ b
the dirty pages caused by PVM and SVM, we only flush those dirty
pages from RAM cache while do checkpoint.
Cc: Juan Quintela
Signed-off-by: zhanghailiang
Reviewed-by: Dr. David Alan Gilbert
---
migration/ram.c | 29 +
1 file changed, 29 insertions(+)
diff --git a
Quan
Cc: Jason Wang
zhanghailiang (18):
net/colo: Add notifier/callback related helpers for filter
colo-compare: implement the process of checkpoint
colo-compare: use notifier to notify packets comparing result
COLO: integrate colo compare with colo frame
COLO: Handle shutdown command
Wang
Signed-off-by: zhanghailiang
Reviewed-by: Dr. David Alan Gilbert
---
migration/colo.c | 42 --
migration/migration.c | 2 +-
2 files changed, 41 insertions(+), 3 deletions(-)
diff --git a/migration/colo.c b/migration/colo.c
index c19eb3f
It's a good idea to use notifier to notify COLO frame of
inconsistent packets comparing.
Cc: Jason Wang
Signed-off-by: Zhang Chen
Signed-off-by: zhanghailiang
---
net/colo-compare.c | 32
net/colo-compare.h | 2 ++
2 files changed, 30 insertions(
It's a good idea to use notifier to notify COLO frame of
inconsistent packets comparing.
Cc: Jason Wang
Signed-off-by: Zhang Chen
Signed-off-by: zhanghailiang
---
net/colo-compare.c | 32
net/colo-compare.h | 2 ++
2 files changed, 30 insertions(
: zhanghailiang
Signed-off-by: Li Zhijian
Reviewed-by: Dr. David Alan Gilbert
---
include/migration/colo.h | 1 +
include/sysemu/sysemu.h | 3 +++
migration/colo.c | 46 +-
qapi-schema.json | 4 +++-
vl.c | 19
data
transferring in the subsequent checkpoint.
Cc: Juan Quintela
Sgned-off-by: zhanghailiang
Signed-off-by: Li Zhijian
Reviewed-by: Dr. David Alan Gilbert
---
migration/colo.c | 51 ---
1 file changed, 36 insertions(+), 15 deletions(-)
diff
_main() and qemu_save_device_state()
public, and simplify the codes of qemu_save_device_state() by calling the
wrapper qemu_savevm_state_header().
Cc: Juan Quintela
Signed-off-by: zhanghailiang
Signed-off-by: Li Zhijian
Reviewed-by: Dr. David Alan Gilbert
---
v2:
- Use the wr
is still necessary to notify users that we exited COLO mode.
Cc: Markus Armbruster
Cc: Michael Roth
Signed-off-by: zhanghailiang
Signed-off-by: Li Zhijian
Reviewed-by: Eric Blake
---
migration/colo.c | 19 +++
qapi-schema.json | 14 ++
qapi/event.json | 21 +++
Notify all net filters about the checkpoint and failover event.
Cc: Jason Wang
Signed-off-by: zhanghailiang
---
migration/colo.c | 13 +
1 file changed, 13 insertions(+)
diff --git a/migration/colo.c b/migration/colo.c
index 66bb5b2..62f58c6 100644
--- a/migration/colo.c
+++ b
ad to memory leak.
To fix it, we split the process of saving and finding section entry into two
helper functions, we will check if section info was exist in loadvm_handlers
list before save it.
This modifications have no side effect for normal migration.
Cc: Juan Quintela
Signed-off-by: zhanghai
was used during checkpoint.
Besides, we move the colo_flush_ram_cache to the proper position after the
above change.
Cc: Juan Quintela
Signed-off-by: zhanghailiang
Signed-off-by: Li Zhijian
Reviewed-by: Dr. David Alan Gilbert
---
migration/colo.c | 49
Filter needs to process the event of checkpoint/failover or
other event passed by COLO frame.
Cc: Jason Wang
Signed-off-by: zhanghailiang
---
include/net/filter.h | 5 +
net/filter.c | 16
net/net.c| 28
3 files changed, 49
tate.
Cc: Dr. David Alan Gilbert
Signed-off-by: zhanghailiang
Signed-off-by: Li Zhijian
---
v2:
- Move colo_init_ram_cache() and colo_release_ram_cache() out of
incoming thread since both of them need the global lock, if we keep
colo_release_ram_cache() in incoming thread, there are potential
: zhanghailiang
Signed-off-by: Li Zhijian
Reviewed-by: Dr. David Alan Gilbert
---
include/migration/colo.h | 1 +
include/sysemu/sysemu.h | 3 +++
migration/colo.c | 46 +-
qapi-schema.json | 4 +++-
vl.c | 19
We will use this notifier to help COLO to notify filter object
to do something, like do checkpoint, or process failover event.
Cc: Jason Wang
Signed-off-by: zhanghailiang
Signed-off-by: Zhang Chen
Signed-off-by: Li Zhijian
---
net/colo.c | 105
We will use this notifier to help COLO to notify filter object
to do something, like do checkpoint, or process failover event.
Cc: Jason Wang
Signed-off-by: zhanghailiang
Signed-off-by: Zhang Chen
Signed-off-by: Li Zhijian
---
net/colo.c | 105
Signed-off-by: zhanghailiang
---
net/filter-rewriter.c | 39 +++
1 file changed, 39 insertions(+)
diff --git a/net/filter-rewriter.c b/net/filter-rewriter.c
index c9a6d43..0a90b11 100644
--- a/net/filter-rewriter.c
+++ b/net/filter-rewriter.c
@@ -22,6 +22,7
While do checkpoint, we need to flush all the unhandled packets,
By using the filter notifier mechanism, we can easily to notify
every compare object to do this process, which runs inside
of compare threads as a coroutine.
Cc: Jason Wang
Signed-off-by: zhanghailiang
Signed-off-by: Zhang Chen
Don't need to flush all VM's ram from cache, only
flush the dirty pages since last checkpoint
Cc: Juan Quintela
Signed-off-by: Li Zhijian
Signed-off-by: Zhang Chen
Signed-off-by: zhanghailiang
---
v2:
- stop dirty log after exit from COLO state. (Dave)
---
migration/
was used during checkpoint.
Besides, we move the colo_flush_ram_cache to the proper position after the
above change.
Cc: Juan Quintela
Signed-off-by: zhanghailiang
Signed-off-by: Li Zhijian
Reviewed-by: Dr. David Alan Gilbert
---
migration/colo.c | 49
Make sure master start block replication after slave's block
replication started.
Besides, we need to activate VM's blocks before goes into
COLO state.
Signed-off-by: zhanghailiang
Signed-off-by: Li Zhijian
Cc: Stefan Hajnoczi
Cc: Kevin Wolf
Cc: Max Reitz
Cc: Xie Changlong
---
data
transferring in the subsequent checkpoint.
Cc: Juan Quintela
Sgned-off-by: zhanghailiang
Signed-off-by: Li Zhijian
Reviewed-by: Dr. David Alan Gilbert
---
migration/colo.c | 51 ---
1 file changed, 36 insertions(+), 15 deletions(-)
diff
ad to memory leak.
To fix it, we split the process of saving and finding section entry into two
helper functions, we will check if section info was exist in loadvm_handlers
list before save it.
This modifications have no side effect for normal migration.
Cc: Juan Quintela
Signed-off-by: zhanghai
_main() and qemu_save_device_state()
public, and simplify the codes of qemu_save_device_state() by calling the
wrapper qemu_savevm_state_header().
Cc: Juan Quintela
Signed-off-by: zhanghailiang
Signed-off-by: Li Zhijian
Reviewed-by: Dr. David Alan Gilbert
---
v2:
- Use the wr
all content of PVM's RAM cache into SVM's MEMORY,
we do this in a more efficient way:
Only flush any page that dirtied by PVM since last checkpoint.
In this way, we can ensure SVM's memory same with PVM's.
Besides, we must ensure flush RAM cache before load device state.
Cc
0/3] colo-compare: fix three bugs'
series.
For the neweset version, please refer to:
https://github.com/coloft/qemu/tree/colo-for-qemu-2.10-2017-4-22
Please review, thanks.
Cc: Dong eddie
Cc: Jiang yunhong
Cc: Xu Quan
Cc: Jason Wang
zhanghailiang (18):
net/colo: Add notifier/c
the dirty pages caused by PVM and SVM, we only flush those dirty
pages from RAM cache while do checkpoint.
Cc: Juan Quintela
Signed-off-by: zhanghailiang
Reviewed-by: Dr. David Alan Gilbert
---
migration/ram.c | 29 +
1 file changed, 29 insertions(+)
diff --git a
Wang
Signed-off-by: zhanghailiang
Reviewed-by: Dr. David Alan Gilbert
---
migration/colo.c | 42 --
migration/migration.c | 2 +-
2 files changed, 41 insertions(+), 3 deletions(-)
diff --git a/migration/colo.c b/migration/colo.c
index c19eb3f
Hi,
This series fixes three bugs found in our test, please review.
Thanks.
zhanghailiang (3):
colo-compare: serialize compare thread's initialization with main
thread
colo-compare: Check main_loop value before call g_main_loop_quit
colo-compare: fix a memory leak
net/colo-comp
unref().
Signed-off-by: zhanghailiang
---
net/colo-compare.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/net/colo-compare.c b/net/colo-compare.c
index d6a5e4c..97bf0e5 100644
--- a/net/colo-compare.c
+++ b/net/colo-compare.c
@@ -562,7 +562,9 @@ static void *colo_compare_thread(void *o
->src == ((void *)0)'
failed."
Fix it by serializing compare thread's initialization with main thread.
Signed-off-by: zhanghailiang
---
net/colo-compare.c | 6 ++
1 file changed, 6 insertions(+)
diff --git a/net/colo-compare.c b/net/colo-compare.c
index 54e6d40..a6bf41
;loop != NULL'
failed".
We need to check if main_loop is NULL or not before call g_main_loop_quit().
Signed-off-by: zhanghailiang
---
net/colo-compare.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/net/colo-compare.c b/net/colo-compare.c
index a6bf419..d6a5e4
We tried to fix the related codes in commit
b43decb015a6efeb9e3cdbdb80f6547ad7248a4c,
but it didn't fix the bug completely, because we still have some codes didn't
pass
*right* context parameter for remove_fd_in_watch().
Let's fix it by record the GSource directly instead of fd_in
We tried to fix the related codes in commit b43dec, but it didn't
fix the bug completely, because we still have some codes didn't pass *right*
context parameter for remove_fd_in_watch().
Let's fix it by record the GSource directly instead of fd_in_tag.
Signed-off-by: zhanghailiang
---
. We tied to fix the related codes in commit b43dec, but it didn't
fix the bug completely, because we still have some codes didn't pass *right*
context parameter for remove_fd_in_watch().
Let's fix it by record the GSource directly instead of fd_in_tag.
Signed-off-by: zhanghailia
Hi,
-邮件原件-
发件人: kvm-ow...@vger.kernel.org [mailto:kvm-ow...@vger.kernel.org] 代表 Xiao
Guangrong
发送时间: 2017年4月13日 16:53
收件人: Paolo Bonzini; m...@redhat.com; mtosa...@redhat.com
抄送: qemu-devel@nongnu.org; k...@vger.kernel.org; yunfang...@tencent.com; Xiao
Guangrong
主题: Re: [PATCH 0/5] mc146
Call bdrv_invalidate_cache() while do checkpoint for shared disk in patch 5
v3:
- Fix some comments from Stefan and Eric
v2:
- Drop the patch which add a blk_root() helper
- Fix some comments from Changlong
zhanghailiang (6):
docs/block-replication: Add description for shared-disk case
replication
.
Reviewed-by: Stefan Hajnoczi
Reviewed-by: Changlong Xie
Signed-off-by: zhanghailiang
---
block/replication.c | 36 +++-
1 file changed, 19 insertions(+), 17 deletions(-)
diff --git a/block/replication.c b/block/replication.c
index 418b81b..b021215 100644
--- a
Some code logic only be needed in non-shared disk, here
we adjust these codes to prepare for shared disk scenario.
Reviewed-by: Stefan Hajnoczi
Signed-off-by: zhanghailiang
---
block/replication.c | 73 ++---
1 file changed, 41 insertions(+), 32
Introuduce the scenario of shared-disk block replication
and how to use it.
Reviewed-by: Changlong Xie
Reviewed-by: Stefan Hajnoczi
Signed-off-by: zhanghailiang
Signed-off-by: Wen Congyang
Signed-off-by: Zhang Chen
---
docs/block-replication.txt | 139
ver, it doesn't have cluster size, so here we return
a fake value for it.
This patch should be dropped if Eric's nbd patch be merged.
https://lists.gnu.org/archive/html/qemu-block/2017-02/msg00825.html
'[PATCH v4 7/8] nbd: Implement NBD_INFO_BLOCK_SIZE on server'.
Cc: Eric Blake
S
d in the active disk and it
will overwrite the existing sector content in the buffer.
Signed-off-by: zhanghailiang
Signed-off-by: Wen Congyang
Signed-off-by: Zhang Chen
---
v4:
- Call bdrv_invalidate_cache() while do checkpoint for shared disk
--
We use these two options to identify which disk is
shared
Signed-off-by: zhanghailiang
Signed-off-by: Wen Congyang
Signed-off-by: Zhang Chen
---
v4:
- Add proper comment for primary_disk (Stefan)
v2:
- Move g_free(s->shared_disk_id) to the common fail process place (Stefan)
- Fix comments
Signed-off-by: zhanghailiang
---
hw/char/virtio-serial-bus.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/hw/char/virtio-serial-bus.c b/hw/char/virtio-serial-bus.c
index d544cd9..d797a67 100644
--- a/hw/char/virtio-serial-bus.c
+++ b/hw/char/virtio-serial-bus.c
@@ -724,6 +724,7 @@ static
The 'primary_list' and 'secondary_list' members of struct Connection
is not allocated through dynamically g_queue_new(), but we free it by using
g_queue_free(), which will lead to a double-free bug.
Reviewed-by: Zhang Chen
Signed-off-by: zhanghailiang
---
net/colo.c | 4 ++-
1 - 100 of 1429 matches
Mail list logo
