Re: [PATCH v3] dbus-vmstate: Restrict error checks to registered proxies in dbus_get_proxies

2022-08-17 Thread Priyankar Jain
Hi Marc, Could you please merge this in master? I see this commit is missing in master, although it was approved long back. Thanks, Priyankar Jain On 26/11/21 7:45 pm, Priyankar Jain wrote: The purpose of dbus_get_proxies to construct the proxies corresponding to the IDs registered to dbus

[PATCH v3] dbus-vmstate: Restrict error checks to registered proxies in dbus_get_proxies

2021-11-26 Thread Priyankar Jain
r if it is not able to find and validate the proxies of interest(the IDs registered during the dbus-vmstate instantiation). Signed-off-by: Priyankar Jain Reviewed-by: Marc-André Lureau --- backends/dbus-vmstate.c | 13 + 1 file changed, 9 insertions(+), 4 deletions(-) diff --git a/bac

[PATCH v2] dbus-vmstate: Restrict error checks to registered proxies in dbus_get_proxies

2021-11-26 Thread Priyankar Jain
r if it is not able to find and validate the proxies of interest(the IDs registered during the dbus-vmstate instantiation). Signed-off-by: Priyankar Jain --- backends/dbus-vmstate.c | 13 + 1 file changed, 9 insertions(+), 4 deletions(-) diff --git a/backends/dbus-vmstate.c b/bac

[PATCH] dbus-vmstate: Restrict error checks to registered proxies in dbus_get_proxies

2021-11-25 Thread Priyankar Jain
r if it is not able to find and validate the proxies of interest(the IDs registered during the dbus-vmstate instantiation). Signed-off-by: Priyankar Jain --- backends/dbus-vmstate.c | 7 +++ 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/backends/dbus-vmstate.c b/backends/dbus

Re: [PATCH v2] dbus-vmstate: Increase the size of input stream buffer used during load

2021-02-10 Thread priyankar jain
Hi Marc, Requesting you to please pull these changes. Without this fix, migration is failing in case any helper has more than 4KiB of data. Thanks and Regards, Priyankar Jain On 02/02/21 7:24 pm, Priyankar Jain wrote: This commit fixes an issue where migration is failing in the load phase

[PATCH v2] dbus-vmstate: Increase the size of input stream buffer used during load

2021-02-02 Thread Priyankar Jain
("Add dbus-vmstate object") Signed-off-by: Priyankar Jain Reviewed-by: Marc-André Lureau --- backends/dbus-vmstate.c | 20 +--- 1 file changed, 17 insertions(+), 3 deletions(-) diff --git a/backends/dbus-vmstate.c b/backends/dbus-vmstate.c index bd050e8..3b8a116 100644

[PATCH] dbus-vmstate: Increase the size of input stream buffer used during load

2021-02-02 Thread Priyankar Jain
ng load to DBUS_VMSTATE_SIZE_LIMIT which is the maximum amount of data a helper can send during save phase. Secondly, this commit makes sure that the input stream buffer is loaded before checking the size of the data available in it, rectifying the false alarm about data unavailability. Signed-off-by: Priy

Re: [RFC] dbus-vmstate: Connect to the dbus only during the migration phase

2020-12-02 Thread priyankar jain
On 02/12/20 9:46 pm, Daniel P. Berrangé wrote: On Wed, Dec 02, 2020 at 09:25:27PM +0530, priyankar jain wrote: On 20/11/20 12:17 am, Daniel P. Berrangé wrote: On Thu, Nov 19, 2020 at 06:28:55PM +, Priyankar Jain wrote: Today, dbus-vmstate maintains a constant connection to the dbus. This

Re: [RFC] dbus-vmstate: Connect to the dbus only during the migration phase

2020-12-02 Thread priyankar jain
On 20/11/20 12:17 am, Daniel P. Berrangé wrote: On Thu, Nov 19, 2020 at 06:28:55PM +, Priyankar Jain wrote: Today, dbus-vmstate maintains a constant connection to the dbus. This is problematic for a number of reasons: 1. If dbus-vmstate is attached during power-on, then the device holds

[RFC] dbus-vmstate: Connect to the dbus only during the migration phase

2020-11-19 Thread Priyankar Jain
migration phase, inside dbus_vmstate_pre_save() and dbus_vmstate_post_load(). The change also adds a helper, clear_dbus_connection(), and calls it in the appropriate places to ensure dbus-vmstate closes the connection properly post migration. Signed-off-by: Priyankar Jain Signed-off-by: Peter Turschmid