Re: [Qemu-devel] [PATCH 1/3] qapi.py: Move common code to evaluate()

On Mon, Jun 24, 2013 at 05:17:35PM +0200, Kevin Wolf wrote: > Am 21.06.2013 um 18:39 hat mdroth geschrieben: > > On Wed, Jun 19, 2013 at 06:28:05PM +0200, Kevin Wolf wrote: > > > Don't duplicate more code than is really necessary. > > > > > > Signed-off

Re: [Qemu-devel] [PATCH 1/3] qapi.py: Move common code to evaluate()

On Wed, Jun 19, 2013 at 06:28:05PM +0200, Kevin Wolf wrote: > Don't duplicate more code than is really necessary. > > Signed-off-by: Kevin Wolf > --- > scripts/qapi.py | 24 ++-- > 1 file changed, 10 insertions(+), 14 deletions(-) > > diff --git a/scripts/qapi.py b/scripts/q

Re: [Qemu-devel] qemu-ga behavior on virtio-serial unplug

On Thu, Jun 20, 2013 at 10:12:30AM -0500, mdroth wrote: > On Wed, Jun 19, 2013 at 01:17:57PM +0200, Laszlo Ersek wrote: > > Hello Michael, > > > > this is with reference to > > <https://bugzilla.redhat.com/show_bug.cgi?id=907733>. > > > > Ever since t

Re: [Qemu-devel] qemu-ga behavior on virtio-serial unplug

On Wed, Jun 19, 2013 at 01:17:57PM +0200, Laszlo Ersek wrote: > Hello Michael, > > this is with reference to > . > > Ever since the initial qemu-ga commit AFAICS an exception for > virtio-serial has existed, when reading EOF from the channel. >

Re: [Qemu-devel] [PATCH v2 2/2] QEMUBH: make AioContext's bh re-entrant

On Tue, Jun 18, 2013 at 09:20:26PM +0200, Paolo Bonzini wrote: > Il 18/06/2013 17:14, mdroth ha scritto: > > Could we possibly simplify this by introducing a recursive mutex that we > > could use to protect the whole list loop and hold even during the cb? > > If it is poss

Re: [Qemu-devel] [Qemu-stable] [PATCH] acl: acl_add can't insert before last list element, fix

On Tue, Jun 18, 2013 at 10:05:23AM +0200, Markus Armbruster wrote: > Watch this: > > $ upstream-qemu -nodefaults -S -vnc :0,acl,sasl -monitor stdio > QEMU 1.5.50 monitor - type 'help' for more information > (qemu) acl_add vnc.username drei allow > acl: added rule at position 1 >

Re: [Qemu-devel] [PATCH v2] wdt_i6300esb: fix vmstate versioning

On Tue, Jun 11, 2013 at 04:53:51PM -0500, mdroth wrote: > On Wed, May 22, 2013 at 11:32:51AM -0500, Michael Roth wrote: > > When this VMSD was introduced it's version fields were set to > > sizeof(I6300State), making them essentially random from build to build, > > versi

Re: [Qemu-devel] [PATCH v2 2/2] QEMUBH: make AioContext's bh re-entrant

On Tue, Jun 18, 2013 at 10:14:38AM -0500, mdroth wrote: > On Sun, Jun 16, 2013 at 07:21:21PM +0800, Liu Ping Fan wrote: > > BH will be used outside big lock, so introduce lock to protect > > between the writers, ie, bh's adders and deleter. > > Note that the lock only af

Re: [Qemu-devel] [PATCH v2 2/2] QEMUBH: make AioContext's bh re-entrant

;cb(bh->opaque); Could we possibly simplify this by introducing a recursive mutex that we could use to protect the whole list loop and hold even during the cb? I assume we can't hold the lock during the cb currently since we might try to reschedule, but if it's a re

Re: [Qemu-devel] [Qemu-stable] [PATCH v2 0/6] Some -smbios work

me. 5/6 was certainly a good candidate. I was going to cherry-pick it but I agree the other patches looked safe to I went ahead and applied the series: https://github.com/mdroth/qemu/commits/stable-1.5-staging > > Markus Armbruster writes: > > > Better error messages, a bit of cod

Re: [Qemu-devel] Patch Round-up for stable 1.5.1, freeze on 2013-06-19

On Mon, Jun 17, 2013 at 04:04:31PM -0700, Richard Henderson wrote: > On 06/17/2013 03:56 PM, mdroth wrote: > > On Wed, Jun 12, 2013 at 04:41:12PM -0500, Michael Roth wrote: > >> Hi everyone, > >> > >> The following new patches are queued for QEMU stable v1.5.1:

Re: [Qemu-devel] Patch Round-up for stable 1.5.1, freeze on 2013-06-19

On Wed, Jun 12, 2013 at 04:41:12PM -0500, Michael Roth wrote: > Hi everyone, > > The following new patches are queued for QEMU stable v1.5.1: > > https://github.com/mdroth/qemu/commits/stable-1.5-staging Repo updated with everything I'm tracking that's been committ

Re: [Qemu-devel] Patch Round-up for stable 1.5.1, freeze on 2013-06-19

On Thu, Jun 13, 2013 at 02:36:20PM +0200, Andreas Färber wrote: > Am 13.06.2013 14:27, schrieb Paolo Bonzini: > > Il 12/06/2013 17:41, Michael Roth ha scritto: > >> Hi everyone, > >> > >> The following new patches are queued for QEMU stable v1.5.1: > >>

Re: [Qemu-devel] Patch Round-up for stable 1.5.1, freeze on 2013-06-19

ollowing new patches are queued for QEMU stable v1.5.1: > >>> > >>>https://github.com/mdroth/qemu/commits/stable-1.5-staging > >>> > >>>The release is planned for 2013-06-26: > >>> > >>>http://wiki.qemu.org/Planning/1.5 > >&

Re: [Qemu-devel] Patch Round-up for stable 1.5.1, freeze on 2013-06-19

On Thu, Jun 13, 2013 at 02:36:20PM +0200, Andreas Färber wrote: > Am 13.06.2013 14:27, schrieb Paolo Bonzini: > > Il 12/06/2013 17:41, Michael Roth ha scritto: > >> Hi everyone, > >> > >> The following new patches are queued for QEMU stable v1.5.1: > >>

Re: [Qemu-devel] [PATCH] wdt_i6300esb: fix vmstate versioning

On Wed, Jun 12, 2013 at 04:17:53PM -0500, Anthony Liguori wrote: > mdroth writes: > > > On Tue, May 21, 2013 at 05:32:57PM -0500, Michael Roth wrote: > >> When this VMSD was introduced it's version fields were set to > >> sizeof(I6300State), making them ess

Re: [Qemu-devel] [PATCH] wdt_i6300esb: fix vmstate versioning

On Wed, Jun 12, 2013 at 09:42:14PM +0100, Peter Maydell wrote: > On 12 June 2013 21:11, mdroth wrote: > > On Tue, May 21, 2013 at 05:32:57PM -0500, Michael Roth wrote: > >> When this VMSD was introduced it's version fields were set to > >> sizeof(I6300State), mak

Re: [Qemu-devel] [PATCH v2] virtio-rng: Fix crash with non-default backend

On Fri, May 31, 2013 at 02:12:48PM -0400, Cole Robinson wrote: > 'default_backend' isn't always set, but 'rng' is, so use that. > > $ ./x86_64-softmmu/qemu-system-x86_64 -object > rng-random,id=rng0,filename=/dev/random -device virtio-rng-pci,rng=rng0 > Segmentation fault (core dumped) > > Regre

Re: [Qemu-devel] [PATCH] wdt_i6300esb: fix vmstate versioning

On Tue, May 21, 2013 at 05:32:57PM -0500, Michael Roth wrote: > When this VMSD was introduced it's version fields were set to > sizeof(I6300State), making them essentially random from build to build, > version to version. > > To fix this, we lock in a high version id and low minimum version id to

Re: [Qemu-devel] [Qemu-stable] [PATCH 3/3] savevm: avoid leaking popen(3) file pointer

On Thu, May 30, 2013 at 04:14:46PM +0200, Stefan Hajnoczi wrote: > I'm not sure why we check the mode only after invoking popen(3) but we > need to close the file pointer. > > Spotted by Coverity. > > Cc: Juan Quintela > Cc: qemu-sta...@nongnu.org > Signed-off-by: Stefan Hajnoczi Ping, looking

Re: [Qemu-devel] [PATCH 1/3] vhost-scsi: fix k->set_guest_notifiers() NULL dereference

On Thu, May 30, 2013 at 04:14:44PM +0200, Stefan Hajnoczi wrote: > Coverity picked up a copy-paste bug. In vhost_scsi_start() we check for > !k->set_guest_notifiers and error out. The check probably got copied > but instead of erroring we actually use the function pointer! > > Cc: Nicholas Belli

Re: [Qemu-devel] [PULL 0/2] update seabios to release 1.7.2.2

On Tue, Jun 11, 2013 at 05:05:59PM -0500, mdroth wrote: > On Tue, May 28, 2013 at 12:28:50PM +0200, Gerd Hoffmann wrote: > > Hi, > > > > This pull updates seabios to the 1.7.2.2 release tagged yesterday, > > bringing some fixes which unfortunaly missed the qemu 1.5

Re: [Qemu-devel] [PULL 0/2] update seabios to release 1.7.2.2

On Tue, May 28, 2013 at 12:28:50PM +0200, Gerd Hoffmann wrote: > Hi, > > This pull updates seabios to the 1.7.2.2 release tagged yesterday, > bringing some fixes which unfortunaly missed the qemu 1.5 boat. > > please pull, > Gerd > > The following changes since commit 6a4e17711442849bf2cc731

Re: [Qemu-devel] [PATCH v2] wdt_i6300esb: fix vmstate versioning

On Wed, May 22, 2013 at 11:32:51AM -0500, Michael Roth wrote: > When this VMSD was introduced it's version fields were set to > sizeof(I6300State), making them essentially random from build to build, > version to version. > > To fix this, we lock in a high version id and low minimum version id to

Re: [Qemu-devel] [Qemu-stable] [PATCH for-1.5] ppc: do not register IABR SPR twice for 603e

On Mon, May 20, 2013 at 08:17:47PM +0200, Hervé Poussineau wrote: > Ping. > This should be IMO committed to stable, as it fixes a crash with > qemu-system-ppc -M prep -cpu 603e Ping^2. Looking to pull this in for 1.5.1 > > Hervé > > Hervé Poussineau a écrit : > >IABR SPR is already registered i

Re: [Qemu-devel] [PATCH] ide-test: fix failure for test_flush

On Tue, Jun 11, 2013 at 12:05:20PM +0200, Andreas Färber wrote: > Am 10.06.2013 20:23, schrieb Michael Roth: > > bd07684aacfb61668ae2c25b7dd00b64f3d7c7f3 added a test to ensure BSY > > flag is set when a flush request is in flight. It does this by setting > > a blkdebug breakpoint on flush_to_os be

Re: [Qemu-devel] [PATCHv2 2/2] migration: do not overwrite zero pages

On Mon, Jun 10, 2013 at 11:10:29AM -0500, mdroth wrote: > On Mon, Jun 10, 2013 at 12:14:20PM +0200, Peter Lieven wrote: > > on incoming migration do not memset pages to zero if they already read as > > zero. > > this will allocate a new zero page and consume memory unnecess

Re: [Qemu-devel] [PATCHv2 2/2] migration: do not overwrite zero pages

On Mon, Jun 10, 2013 at 12:14:20PM +0200, Peter Lieven wrote: > on incoming migration do not memset pages to zero if they already read as > zero. > this will allocate a new zero page and consume memory unnecessarily. even > if we madvise a MADV_DONTNEED later this will only deallocate the memory >

Re: [Qemu-devel] [PATCHv2 1/2] Revert "migration: do not sent zero pages in bulk stage"

On Mon, Jun 10, 2013 at 12:14:19PM +0200, Peter Lieven wrote: > Not sending zero pages breaks migration if a page is zero > at the source but not at the destination. This can e.g. happen > if different BIOS versions are used at source and destination. > It has also been reported that migration on p

Re: [Qemu-devel] [PATCH v4] qemu-char: don't issue CHR_EVENT_OPEN in a BH

On Fri, Jun 07, 2013 at 11:36:16AM -0400, Luiz Capitulino wrote: > On Fri, 7 Jun 2013 09:56:00 -0500 > mdroth wrote: > > > On Fri, Jun 07, 2013 at 09:50:39AM -0400, Luiz Capitulino wrote: > > > On Tue, 4 Jun 2013 16:35:09 -0500 > > > Michael Roth wrote: > &g

Re: [Qemu-devel] [PATCH v4] qemu-char: don't issue CHR_EVENT_OPEN in a BH

On Fri, Jun 07, 2013 at 09:50:39AM -0400, Luiz Capitulino wrote: > On Tue, 4 Jun 2013 16:35:09 -0500 > Michael Roth wrote: > > > When CHR_EVENT_OPENED was initially added, it was CHR_EVENT_RESET, > > and it was issued as a bottom-half: > > > > 86e94dea5b740dad65446c857f6959eae43e0ba6 > > > > W

Re: [Qemu-devel] [PATCH v3] qemu-char: don't issue CHR_EVENT_OPEN in a BH

On Tue, Jun 04, 2013 at 11:58:12AM +0200, Hans de Goede wrote: > Hi, > > On 06/03/2013 10:25 PM, Michael Roth wrote: > > > > >To fix these, let's just drop the BH. > > > >Since the initial reasoning for using it still applies to an extent, > >work around that by deferring the delivery of CHR_EV

Re: [Qemu-devel] [PATCH 2/2] MAINTAINERS: split Monitor (QMP/HMP) entry

On Mon, Jun 03, 2013 at 03:54:48PM -0400, Luiz Capitulino wrote: > On Mon, 03 Jun 2013 21:13:30 +0200 > Paolo Bonzini wrote: > > > Il 03/06/2013 19:17, Luiz Capitulino ha scritto: > > > This entry doesn't reflect reality for a few years now. This commit > > > splits it into Human Monitor (HMP), Q

Re: [Qemu-devel] [PATCH v2] qemu-char: don't issue CHR_EVENT_OPEN in a BH

On Mon, Jun 03, 2013 at 12:17:00PM -0500, Anthony Liguori wrote: > Michael Roth writes: > > > When CHR_EVENT_OPEN was initially added, it was CHR_EVENT_RESET, > > and it was issued as a bottom-half: > > > > 86e94dea5b740dad65446c857f6959eae43e0ba6 > > > > Which we basically used to print out a gr

Re: [Qemu-devel] [PATCH] qemu-char: don't issue CHR_EVENT_OPEN in a BH

On Thu, May 30, 2013 at 03:24:14PM -0500, Anthony Liguori wrote: > mdroth writes: > > > On Thu, May 30, 2013 at 02:35:37PM -0500, Anthony Liguori wrote: > >> mdroth writes: > >> > >> > On Thu, May 30, 2013 at 11:55:56AM -0500, Anthony L

Re: [Qemu-devel] [PATCH] qemu-char: don't issue CHR_EVENT_OPEN in a BH

On Thu, May 30, 2013 at 02:35:37PM -0500, Anthony Liguori wrote: > mdroth writes: > > > On Thu, May 30, 2013 at 11:55:56AM -0500, Anthony Liguori wrote: > >> Michael Roth writes: > >> > >> > When CHR_EVENT_OPEN was initially added, it was CHR_EVENT_R

Re: [Qemu-devel] [PATCH] qemu-char: don't issue CHR_EVENT_OPEN in a BH

On Thu, May 30, 2013 at 11:55:56AM -0500, Anthony Liguori wrote: > Michael Roth writes: > > > When CHR_EVENT_OPEN was initially added, it was CHR_EVENT_RESET, and > > it was issued as a bottom-half: > > > > 86e94dea5b740dad65446c857f6959eae43e0ba6 > > > > AFAICT the only reason this was ever done

Re: [Qemu-devel] [PATCH v2] monitor: work around delayed CHR_EVENT_OPENED events

On Wed, May 29, 2013 at 01:27:33PM -0400, Luiz Capitulino wrote: > On Mon, 27 May 2013 12:59:25 -0500 > mdroth wrote: > > > On Mon, May 27, 2013 at 11:16:01AM -0500, Anthony Liguori wrote: > > > Luiz Capitulino writes: > > > > > > > On Sun, 26

Re: [Qemu-devel] [PATCH v2] monitor: work around delayed CHR_EVENT_OPENED events

On Wed, May 29, 2013 at 01:27:33PM -0400, Luiz Capitulino wrote: > On Mon, 27 May 2013 12:59:25 -0500 > mdroth wrote: > > > On Mon, May 27, 2013 at 11:16:01AM -0500, Anthony Liguori wrote: > > > Luiz Capitulino writes: > > > > > > > On Sun, 26

Re: [Qemu-devel] [PATCH] qapi: pad GenericList value fields to 64 bits

On Wed, May 29, 2013 at 01:32:52PM -0400, Luiz Capitulino wrote: > On Sun, 26 May 2013 22:20:58 -0500 > Michael Roth wrote: > > > With the introduction of native list types, we now have types such as > > int64List where the 'value' field is not a pointer, but the actual > > 64-bit value. > > > >

Re: [Qemu-devel] [PATCH v2] monitor: work around delayed CHR_EVENT_OPENED events

lities' for a subsequent session, > >> since we reset capabilities in response to CHR_EVENT_OPENED, which may > >> not yet have been delivered. This can be reproduced with the following > >> command, generally within 50 or so iterations: > >> > >> mdrot

Re: [Qemu-devel] [PATCH] qapi: pad GenericList value fields to 64 bits

On Mon, May 27, 2013 at 06:38:35AM +0200, Stefan Weil wrote: > Am 27.05.2013 05:20, schrieb Michael Roth: > > With the introduction of native list types, we now have types such as > > int64List where the 'value' field is not a pointer, but the actual > > 64-bit value. > > > > On 32-bit architecture

Re: [Qemu-devel] make check breakage on 32 bit hosts

On Sun, May 26, 2013 at 10:26:48AM -0500, mdroth wrote: > On Sun, May 26, 2013 at 12:00:57PM +, Blue Swirl wrote: > > I get this on i386 chroot for make check: > > > > GTESTER tests/test-qmp-output-visitor > > ** > > ERROR:/src/qemu/tests/test-qmp-outpu

Re: [Qemu-devel] [Qemu-stable] qmp commands get rejected

On Sun, May 26, 2013 at 05:13:36PM +0200, Stefan Priebe wrote: > Am 26.05.2013 03:23, schrieb mdroth: > >On Sat, May 25, 2013 at 01:09:50PM +0200, Stefan Priebe wrote: > >>Am 25.05.2013 00:32, schrieb mdroth: > >>>On Sat, May 25, 2013 at 12:12:22AM +0200, Stefan Pri

Re: [Qemu-devel] make check breakage on 32 bit hosts

On Sun, May 26, 2013 at 12:00:57PM +, Blue Swirl wrote: > I get this on i386 chroot for make check: > > GTESTER tests/test-qmp-output-visitor > ** > ERROR:/src/qemu/tests/test-qmp-output-visitor.c:595:check_native_list: > assertion failed: (tmp) > GTester: last random seed: R02S559792e7c8d0762

Re: [Qemu-devel] [Qemu-stable] qmp commands get rejected

On Sat, May 25, 2013 at 01:09:50PM +0200, Stefan Priebe wrote: > Am 25.05.2013 00:32, schrieb mdroth: > >On Sat, May 25, 2013 at 12:12:22AM +0200, Stefan Priebe wrote: > >>Am 25.05.2013 00:09, schrieb mdroth: > >>>>>>>I would try to create a small exampl

Re: [Qemu-devel] [Qemu-stable] qmp commands get rejected

On Sat, May 25, 2013 at 12:12:22AM +0200, Stefan Priebe wrote: > Am 25.05.2013 00:09, schrieb mdroth: > >>>>>I would try to create a small example script. > >>>> > >>>>I use qmp-shell and other little scripts very often. > >>>> &

Re: [Qemu-devel] [Qemu-stable] qmp commands get rejected

On Fri, May 24, 2013 at 11:37:46PM +0200, Stefan Priebe wrote: > >Am 24.05.2013 17:21, schrieb Luiz Capitulino: > >>On Fri, 24 May 2013 16:36:26 +0200 > >>Stefan Priebe - Profihost AG wrote: > >> > >>>Am 24.05.2013 um 16:02 schrieb Luiz Capitulino : > >>> > On Fri, 24 May 2013 15:57:59 +0200 >

[Qemu-devel] [ANNOUNCE] QEMU 1.4.2 Stable released

Hi everyone, I am pleased to announce that the QEMU v1.4.2 stable release is now available at: http://wiki.qemu.org/download/qemu-1.4.2.tar.bz2 The official stable-1.4 repository has also been updated to v1.4.2: http://git.qemu.org/?p=qemu-stable-1.4.git;a=summary This release contains 25 buil

Re: [Qemu-devel] (Another) 1.4.1 -> 1.5.0 migration failure

On Tue, May 21, 2013 at 10:16:48PM +0100, Peter Maydell wrote: > On 21 May 2013 21:43, mdroth wrote: > > Makes sense, but apparently version IDs for incoming device state are > > not allowed to exceed the destination's version, so we can't bump it > > beyond th

Re: [Qemu-devel] (Another) 1.4.1 -> 1.5.0 migration failure

On Tue, May 21, 2013 at 06:50:23PM +0100, Peter Maydell wrote: > On 21 May 2013 18:26, mdroth wrote: > > static const VMStateDescription vmstate_i6300esb = { > > .name = "i6300esb_wdt", > > .version_id = sizeof(I6300State), > > .m

Re: [Qemu-devel] (Another) 1.4.1 -> 1.5.0 migration failure

On Tue, May 21, 2013 at 11:55:56AM -0500, mdroth wrote: > On Tue, May 21, 2013 at 12:33:38PM +0100, Nicholas Thomas wrote: > > Hi all, > > > > Migrating from: > > > > /opt/qemu-1.4.1/bin/qemu-system-x86_64 -M pc -watchdog i6300esb > > -watchdog-action reset

Re: [Qemu-devel] (Another) 1.4.1 -> 1.5.0 migration failure

On Tue, May 21, 2013 at 12:33:38PM +0100, Nicholas Thomas wrote: > Hi all, > > Migrating from: > > /opt/qemu-1.4.1/bin/qemu-system-x86_64 -M pc -watchdog i6300esb > -watchdog-action reset [...] > > to: > > /opt/qemu-1.5.0/bin/qemu-system-x86_64 -M pc-i440fx-1.4 -watchdog > i6300esb -watchdog-a

Re: [Qemu-devel] [PATCH 0/6] local state directory fixes for win32 qga

On Sat, May 18, 2013 at 06:31:47AM +0200, Laszlo Ersek wrote: > Qouting patch 2/6: > > > Since commit 39097daf ("qemu-ga: use key-value store to avoid > > recycling fd handles after restart") we've relied on the state > > directory for the fd handles' key-value store. Even though we don't > > supp

Re: [Qemu-devel] [Qemu-stable] Patch Round-up for stable 1.4.2, freeze on Monday

On Fri, May 17, 2013 at 01:43:28PM -0700, Josh Durgin wrote: > On 05/17/2013 12:08 PM, mdroth wrote: > >On Fri, May 17, 2013 at 10:46:15AM -0500, Doug Goldstein wrote: > >>On Tue, May 14, 2013 at 4:52 PM, Michael Roth > >>wrote: > >> > >>>Hi ev

Re: [Qemu-devel] [PATCH v3 00/11] qapi: add support for lists of native types

On Thu, May 16, 2013 at 12:38:30PM +0200, Laszlo Ersek wrote: > On 05/15/13 21:13, mdroth wrote: > > On Wed, May 15, 2013 at 02:05:58PM -0400, Luiz Capitulino wrote: > >> On Wed, 15 May 2013 12:42:24 -0500 > >> mdroth wrote: > > >>> The only way I&#

Re: [Qemu-devel] Patch Round-up for stable 1.4.2, freeze on Monday

On Fri, May 17, 2013 at 10:46:15AM -0500, Doug Goldstein wrote: > On Tue, May 14, 2013 at 4:52 PM, Michael Roth > wrote: > > > Hi everyone, > > > > The following new patches are queued for QEMU stable v1.4.2: > > > > https://github.com/mdroth/qemu/commits

Re: [Qemu-devel] [PATCH for-1.5] virtio: add virtio_bus_get_dev_path.'

On Thu, May 16, 2013 at 07:06:07PM +0200, fred.kon...@greensocs.com wrote: > From: KONRAD Frederic > > This adds virtio_bus_get_dev_path to fix migration id string which is wrong > since the virtio refactoring. > > Signed-off-by: KONRAD Frederic > Reviewed-by: Paolo Bonzi

Re: [Qemu-devel] Patch Round-up for stable 1.4.2, freeze on Monday

On Wed, May 15, 2013 at 05:48:14PM -0400, Cole Robinson wrote: > On 05/14/2013 05:52 PM, Michael Roth wrote: > > Hi everyone, > > > > The following new patches are queued for QEMU stable v1.4.2: > > > > https://github.com/mdroth/qemu/commits/stable-1.4-staging &g

Re: [Qemu-devel] [ANNOUNCE] QEMU 1.5.0-rc2 is now available

On Thu, May 16, 2013 at 06:34:09PM +0200, KONRAD Frédéric wrote: > On 16/05/2013 18:07, Paolo Bonzini wrote: > >Il 16/05/2013 17:54, KONRAD Frédéric ha scritto: > >>I think this can do the job, any better idea? > >> > >>diff --git a/hw/pci/pci.c b/hw/pci/pci.c > >>index d5257ed..e033b53 100644 > >>

Re: [Qemu-devel] [ANNOUNCE] QEMU 1.5.0-rc2 is now available

On Thu, May 16, 2013 at 06:07:12PM +0200, Paolo Bonzini wrote: > Il 16/05/2013 17:54, KONRAD Frédéric ha scritto: > > I think this can do the job, any better idea? > > > > diff --git a/hw/pci/pci.c b/hw/pci/pci.c > > index d5257ed..e033b53 100644 > > --- a/hw/pci/pci.c > > +++ b/hw/pci/pci.c > > @

Re: [Qemu-devel] [ANNOUNCE] QEMU 1.5.0-rc2 is now available

On Wed, May 15, 2013 at 06:53:47PM -0500, Anthony Liguori wrote: > Hi, > > On behalf of the QEMU Team, I'd like to announce the availability of the > third release candidate for the QEMU 1.5 release. This release is meant > for testing purposes and should not be used in a production environment.

Re: [Qemu-devel] [PATCH v3 00/11] qapi: add support for lists of native types

On Wed, May 15, 2013 at 02:05:58PM -0400, Luiz Capitulino wrote: > On Wed, 15 May 2013 12:42:24 -0500 > mdroth wrote: > > > On Wed, May 15, 2013 at 11:04:27AM -0400, Luiz Capitulino wrote: > > > On Wed, 15 May 2013 09:32:37 -0500 > > > mdroth wrote: > > &

Re: [Qemu-devel] [PATCH v3 00/11] qapi: add support for lists of native types

On Wed, May 15, 2013 at 11:04:27AM -0400, Luiz Capitulino wrote: > On Wed, 15 May 2013 09:32:37 -0500 > mdroth wrote: > > > On Wed, May 15, 2013 at 09:17:46AM -0400, Luiz Capitulino wrote: > > > On Fri, 10 May 2013 17:45:59 -0500 > > > Michael Roth wrote: >

Re: [Qemu-devel] Patch Round-up for stable 1.4.2, freeze on Monday

On Wed, May 15, 2013 at 10:09:32AM -0400, Brad Smith wrote: > On Tue, May 14, 2013 at 04:52:57PM -0500, Michael Roth wrote: > > Hi everyone, > > > > The following new patches are queued for QEMU stable v1.4.2: > > > > https://github.com/mdroth/qemu/commits/stable

Re: [Qemu-devel] [PATCH for-1.5?] ide-test: Fix endianness problems

On Wed, May 15, 2013 at 10:37:43AM -0500, Anthony Liguori wrote: > Paolo Bonzini writes: > > > Il 15/05/2013 15:24, Kevin Wolf ha scritto: > >> Am 15.05.2013 um 15:15 hat Paolo Bonzini geschrieben: > >>> Il 15/05/2013 15:00, Kevin Wolf ha scritto: > The test case passes on big endian hosts n

Re: [Qemu-devel] [PATCH v3 00/11] qapi: add support for lists of native types

On Wed, May 15, 2013 at 09:17:46AM -0400, Luiz Capitulino wrote: > On Fri, 10 May 2013 17:45:59 -0500 > Michael Roth wrote: > > > These patches apply on top of qemu.git master, and can also be obtained > > from: > > git://github.com/mdroth/qemu.git qapi-native-list

Re: [Qemu-devel] [PATCH v2 0/2] qga umask fix addenda

On Sun, May 12, 2013 at 06:47:05PM +0200, Andreas Färber wrote: > Am 10.05.2013 22:09, schrieb mdroth: > > On Fri, May 10, 2013 at 09:53:27PM +0200, Laszlo Ersek wrote: > >> On 05/10/13 21:30, mdroth wrote: > >>> On Wed, May 08, 2013 at 05:31:34PM +0200, Laszlo Ers

Re: [Qemu-devel] [PATCH 04/10] qapi: enable generation of native list code

On Fri, May 10, 2013 at 11:32:48AM -0500, mdroth wrote: > On Fri, May 10, 2013 at 10:10:03AM -0400, Luiz Capitulino wrote: > > On Thu, 9 May 2013 21:20:56 -0500 > > Michael Roth wrote: > > > > > Also, fix a dependency issue with libqemuutil: qemu-sockets.c needs &

Re: [Qemu-devel] [PATCH v2 0/2] qga umask fix addenda

On Fri, May 10, 2013 at 09:53:27PM +0200, Laszlo Ersek wrote: > On 05/10/13 21:30, mdroth wrote: > > On Wed, May 08, 2013 at 05:31:34PM +0200, Laszlo Ersek wrote: > >> I should have paid more attention to portability and error path cleanup > >> in the CVE-2013-2007 fix

Re: [Qemu-devel] [PATCH v2 0/2] qga umask fix addenda

be a reasonable > assumption when the input fd is valid.) > > Laszlo Ersek (2): > qga: distinguish binary modes in "guest_file_open_modes" map > qga: unlink just created guest-file if fchmod() or fdopen() fails on > it Thanks, applied to qga branch: https://gi

Re: [Qemu-devel] [PATCH 04/10] qapi: enable generation of native list code

On Fri, May 10, 2013 at 10:10:03AM -0400, Luiz Capitulino wrote: > On Thu, 9 May 2013 21:20:56 -0500 > Michael Roth wrote: > > > Also, fix a dependency issue with libqemuutil: qemu-sockets.c needs > > qapi-types.c/qapi-visit.c > > > > Signed-off-by: Michael Roth > > --- > > Makefile |6 ++

Re: [Qemu-devel] [PATCH 06/10] json-parser: fix handling of large whole number values

On Fri, May 10, 2013 at 11:17:17AM -0400, Luiz Capitulino wrote: > On Thu, 9 May 2013 21:20:58 -0500 > Michael Roth wrote: > > > Currently our JSON parser assumes that numbers lacking a mantissa are > > integers and attempts to store them as QInt/int64 values. This breaks in > > the case where t

Re: [Qemu-devel] [PATCH 01/10] qapi: qapi-types.py, native list support

On Fri, May 10, 2013 at 10:07:45AM -0400, Luiz Capitulino wrote: > On Thu, 9 May 2013 21:20:53 -0500 > Michael Roth wrote: > > > Teach type generators about native types so they can generate the > > appropriate linked list types. > > > > Signed-off-by: Michael Roth > > --- > > scripts/qapi-ty

Re: [Qemu-devel] [PATCH 06/10] json-parser: fix handling of large whole number values

his triggering the change is if they did something like: obj = qobject_from_jsonf("{'myInt': %f}", whole_valued_float); which would be evil, and thankfully such cases don't appear to exist: mdroth@loki:~/w/qemu.git$ ack-grep qobject_from_json | grep "%f" tests/

Re: [Qemu-devel] [PATCH 06/10] json-parser: fix handling of large whole number values

On Fri, May 10, 2013 at 02:47:18PM +0200, Laszlo Ersek wrote: > On 05/10/13 14:22, Eric Blake wrote: > > On 05/09/2013 08:20 PM, Michael Roth wrote: > >> Currently our JSON parser assumes that numbers lacking a mantissa are > >> integers and attempts to store them as QInt/int64 values. This breaks

Re: [Qemu-devel] [PATCH 01/10] qapi: qapi-types.py, native list support

On Fri, May 10, 2013 at 11:04:22AM +0800, Amos Kong wrote: > On Thu, May 09, 2013 at 09:20:53PM -0500, Michael Roth wrote: > > Teach type generators about native types so they can generate the > > appropriate linked list types. > > > > Signed-off-by: Michael Roth > > --- > > scripts/qapi-types.p

Re: [Qemu-devel] [PATCH 0/8] qapi: add support for lists of native types

On Thu, May 09, 2013 at 03:31:08PM +0200, Laszlo Ersek wrote: > On 05/09/13 01:33, Michael Roth wrote: > > These patches apply on top of qemu.git master, and can also be obtained > > from: > > git://github.com/mdroth/qemu.git qapi-native-lists > > > > Sending

Re: [Qemu-devel] [PATCH 6/8] qapi: add native list coverage for visitor serialization tests

On Thu, May 09, 2013 at 02:31:03PM +0200, Laszlo Ersek wrote: > On 05/09/13 01:33, Michael Roth wrote: > > > +case PTYPE_NUMBER: { > > +numberList *ptr; > > +char *double1, *double2; > > +if (cur_head) { > > +ptr = cur_head; > > +

Re: [Qemu-devel] [PATCH] qga: set umask 0077 when daemonizing (CVE-2013-2007)

On Tue, May 07, 2013 at 09:55:06AM -0600, Eric Blake wrote: > On 05/07/2013 05:47 AM, Anthony Liguori wrote: > > From: Laszlo Ersek > > > > The qemu guest agent creates a bunch of files with insecure permissions > > when started in daemon mode. For example: > > > > -rw-rw-rw- 1 root root /var/

Re: [Qemu-devel] [PATCH 1/2] qga: distinguish binary modes in "guest_file_open_modes" map

On Tue, May 07, 2013 at 11:27:03AM -0600, Eric Blake wrote: > On 05/07/2013 10:56 AM, Laszlo Ersek wrote: > > In Windows guests this may make a difference. > > > > Suggested-by: Eric Blake > > Signed-off-by: Laszlo Ersek > > --- > > qga/commands-posix.c | 22 -- > > 1 file

Re: [Qemu-devel] [PATCH 9/9] dataplane: use a QContext event loop in place of custom thread

On Mon, May 06, 2013 at 09:54:03AM +0200, Paolo Bonzini wrote: > Il 03/05/2013 18:03, Michael Roth ha scritto: > > virtio-blk dataplane currently creates/manages it's own thread to > > offload work to a separate event loop. > > > > This patch insteads allows us to specify a QContext-based event lo

Re: [Qemu-devel] [PATCH 7/9] iohandler: associate with main event loop via a QSource

On Mon, May 06, 2013 at 09:53:12AM +0200, Paolo Bonzini wrote: > Il 03/05/2013 18:03, Michael Roth ha scritto: > > This introduces a GlibQContext wrapper around the main GMainContext > > event loop, and associates iohandlers with it via a QSource (which > > GlibQContext creates a GSource from so th

Re: [Qemu-devel] [PATCH 1/9] qom: add qom_init_completion

On Mon, May 06, 2013 at 09:45:22AM +0200, Paolo Bonzini wrote: > Il 03/05/2013 18:03, Michael Roth ha scritto: > > This is similar in concept to "realize", though semantics are a > > bit more open-ended: > > > > And object might in some cases need a number of properties to be > > specified before

Re: [Qemu-devel] [PATCH 2/9] qom: add object_property_add_unnamed_child

On Mon, May 06, 2013 at 09:44:13AM +0200, Paolo Bonzini wrote: > Il 03/05/2013 18:03, Michael Roth ha scritto: > > This interface allows us to add a child property without specifying a > > name. Instead, a unique name is created and passed back after adding > > the property. > > > > Signed-off-by:

Re: [Qemu-devel] [RFC 0/9] QContext: QOM class to support multiple event loops

On Mon, May 06, 2013 at 11:26:06AM +0800, liu ping fan wrote: > On Sat, May 4, 2013 at 12:03 AM, Michael Roth > wrote: > > These patches apply on top of qemu.git master, and can also be obtained > > from: > > git://github.com/mdroth/qemu.git qcontext > > &g

Re: [Qemu-devel] [RFC 0/9] QContext: QOM class to support multiple event loops

On Mon, May 06, 2013 at 07:25:24AM -0500, Anthony Liguori wrote: > Paolo Bonzini writes: > > > Il 03/05/2013 18:03, Michael Roth ha scritto: > >> These patches apply on top of qemu.git master, and can also be obtained > >> from: > >> git://github.com/mdrot

Re: [Qemu-devel] [RFC 0/9] QContext: QOM class to support multiple event loops

On Mon, May 06, 2013 at 09:54:14AM +0200, Paolo Bonzini wrote: > Il 03/05/2013 18:03, Michael Roth ha scritto: > > These patches apply on top of qemu.git master, and can also be obtained > > from: > > git://github.com/mdroth/qemu.git qcontext > > > > OVERVIEW

Re: [Qemu-devel] [PATCH v2] qapi: add struct strList and visit_type_strList()

7;bool') and have them handle code generation for these like they would for any user-defined type. This approach works too, but I think this solution is more complete. I'm still working out some bits with the unit tests but I've pushed my WIP here for reference: https://github.co

Re: [Qemu-devel] [qapi] Cannot use list of strings

works, the same approach can probably be taken for all "native" qapi types: str, bool, [u]int[(8|16|32|64)] > > akong just hit this too. > > I think it's a question for aliguori, luiz, or mdroth. > > Stefan >

[Qemu-devel] [ANNOUNCE] QEMU 1.4.1 Stable released

Hi everyone, I am pleased to announce that the QEMU v1.4.1 stable release is now available at: http://wiki.qemu.org/download/qemu-1.4.1.tar.bz2 The official stable-1.4 repository has also been updated to v1.4.1: http://git.qemu.org/?p=qemu-stable-1.4.git;a=summary This release includes 57 buil

Re: [Qemu-devel] Patch Round-up for stable 1.4.1, freeze next Tuesday

On Tue, Apr 02, 2013 at 04:45:05PM -0500, Michael Roth wrote: > Hi everyone, > > The following new patches are queued for QEMU stable v1.4.1: > > https://github.com/mdroth/qemu/commits/stable-1.4-staging > > The release is planned for 04-15-2013: > > http:/

Re: [Qemu-devel] Patch Round-up for stable 1.4.1, freeze next Tuesday

On Thu, Apr 04, 2013 at 07:55:02AM +0200, Peter Lieven wrote: > On 02.04.2013 23:45, Michael Roth wrote: > >Hi everyone, > > > >The following new patches are queued for QEMU stable v1.4.1: > > > >https://github.com/mdroth/qemu/commits/stable-1.4-staging > > &

Re: [Qemu-devel] [PATCH stable-1.4 v2 0/4] monitor: do not rely on O_NONBLOCK for passed file descriptors

ions. Applied to the 1.4.1 staging tree: https://github.com/mdroth/qemu/commits/stable-1.4-staging Thanks for the backport! > > Stefan Hajnoczi (4): > oslib-posix: rename socket_set_nonblock() to qemu_set_nonblock() > net: ensure "socket" backend uses non-blocking fds

Re: [Qemu-devel] Patch Round-up for stable 1.4.1, freeze next Tuesday

On Wed, Apr 03, 2013 at 11:51:31PM +0200, Aurelien Jarno wrote: > On Tue, Apr 02, 2013 at 04:45:05PM -0500, Michael Roth wrote: > > Hi everyone, > > > > The following new patches are queued for QEMU stable v1.4.1: > > > > https://github.com/mdroth/qemu/commit

Re: [Qemu-devel] [PATCH v2 0/4] monitor: do not rely on O_NONBLOCK for passed file descriptors

On Wed, Mar 27, 2013 at 09:17:30AM -0400, Luiz Capitulino wrote: > On Wed, 27 Mar 2013 10:10:42 +0100 > Stefan Hajnoczi wrote: > > > There are several places where QEMU accidentally relies on the O_NONBLOCK > > state > > of passed file descriptors. Exposing O_NONBLOCK state makes it part of the

Re: [Qemu-devel] [PATCH] help: add docs for missing 'queues' option of tap

On Fri, Feb 22, 2013 at 10:57:52PM +0800, Jason Wang wrote: > Cc: Markus Armbruster > Cc: qemu-sta...@nongnu.org > Signed-off-by: Jason Wang Reviewed-by: Michael Roth Documentation is still missing upstream. Looking to pull this in for stable. > --- > qapi-schema.json |2 ++ > qemu-optio

Re: [Qemu-devel] [PATCH] fix wrong output with 'info chardev' for tcp socket.

On Thu, Feb 21, 2013 at 04:28:27PM -0600, mdroth wrote: > On Fri, Feb 22, 2013 at 12:29:44AM +0400, Michael Tokarev wrote: > > 22.02.2013 00:20, Serge E. Hallyn wrote: > > > The snprintf format isn't taking into account the new 'left' and > > > '

Re: [Qemu-devel] [PATCH] hw/mc146818rtc.c: Fix reading and writing of time registers

On Thu, Feb 14, 2013 at 08:54:20AM +0100, Antoine Mathys wrote: > This patch consolidates the bit twidling involved in reading and > writing the time registers to four functions that are used consistently. > > This also has the effect of fixing bug 1090558. > > Signed-off-by: Antoine Mathys Thi

Re: [Qemu-devel] [RFC PATCH v2 0/4] port network layer onto glib

On Thu, Mar 28, 2013 at 03:55:52PM +0100, Stefan Hajnoczi wrote: > On Thu, Mar 28, 2013 at 03:55:51PM +0800, Liu Ping Fan wrote: > > From: Liu Ping Fan > > > > These series aim to make the whole network re-entrant, here only apply > > backend and frontend, > > and for the netcore, separated patc

  1   2   3   >