[PATCH v3] net: vhost-user: add QAPI events to report connection state

2025-02-14 Thread Laurent Vivier
t;: { "netdev-id": "netdev0" } } [automatic reconnection with reconnect-ms] { "timestamp": { "seconds": 1739538638, "microseconds": 354181 }, "event": "NETDEV_VHOST_USER_CONNECTED", "data": { "netdev-id": &qu

Re: [PATCH] net: vhost-user: add QAPI events to report connection state

2025-02-14 Thread Laurent Vivier
On 14/02/2025 11:06, Markus Armbruster wrote: Laurent Vivier writes: The netdev reports NETDEV_VHOST_USER_CONNECTED event when the chardev is connected, and NETDEV_VHOST_USER_DISCONNECTED when it is disconnected. The NETDEV_VHOST_USER_CONNECTED event includes the ChardevInfo (label, filename

[PATCH v2] net: vhost-user: add QAPI events to report connection state

2025-02-14 Thread Laurent Vivier
"data": { "netdev-id": "netdev0", "info": { "frontend-open": true, "filename": "unix:", "label": "chr0" } } } Tested-by: Stefano Brivio Signed-off-by: Laur

[PATCH] net: vhost-user: add QAPI events to report connection state

2025-02-13 Thread Laurent Vivier
"data": { "netdev-id": "netdev0", "info": { "frontend-open": true, "filename": "unix:", "label": "chr0" } } } Signed-off-by: Laurent Vivier --- qapi/char.

Re: [PATCH 0/2] net: Fix announce_self with vhost

2025-02-02 Thread Laurent Vivier
Le 01/02/2025 à 20:36, Michael Tokarev a écrit : 17.01.2025 17:05, Laurent Vivier wrote: CC: qemu-stable and qemu-trivial. On 17/01/2025 12:17, Laurent Vivier wrote: announce_self that sends a RARP packet after migration or with announce_self QMP/HMP command doesn't work with vhost becau

Re: [PATCH 0/2] net: Fix announce_self with vhost

2025-01-30 Thread Laurent Vivier
On 18/01/2025 21:20, Michael Tokarev wrote: 17.01.2025 14:17, Laurent Vivier wrote: announce_self that sends a RARP packet after migration or with announce_self QMP/HMP command doesn't work with vhost because of the vnet headers. announce_self is the only user of QEMU_NET_PACKET_FLAG_RA

Re: [PATCH v4 1/7] linux-user: netlink: Add missing IFA_PROTO to host_to_target_data_addr_rtattr()

2025-01-23 Thread Laurent Vivier
Le 22/01/2025 à 22:20, Helge Deller a écrit : * Laurent Vivier : [...] It would be cleaner to replace all the IFA_XXX by their QEMU_IFA_XXX. Thanks for review, Laurent! Below I've merged patch #1 and #7, as suggested by you. Is this OK? Yes, thanks Can you review? Reviewed-by: La

Re: [PATCH] vhost-user: Silence unsupported VHOST_USER_PROTOCOL_F_RARP error

2025-01-22 Thread Laurent Vivier
On 22/01/2025 17:51, Stefano Garzarella wrote: On Wed, Jan 22, 2025 at 05:41:15PM +0100, Laurent Vivier wrote: On 22/01/2025 17:20, Stefano Garzarella wrote: On Wed, Jan 22, 2025 at 08:59:22AM -0500, Michael S. Tsirkin wrote: On Wed, Jan 22, 2025 at 02:42:14PM +0100, Stefano Garzarella wrote

Re: [PATCH v4 1/7] linux-user: netlink: Add missing IFA_PROTO to host_to_target_data_addr_rtattr()

2025-01-22 Thread Laurent Vivier
and use those instead. Already existing IFA_XXX usages are converted to QEMU_IFA_XXX in a followup-patch. Signed-off-by: Helge Deller Reviewed-by: Laurent Vivier --- linux-user/fd-trans.c | 17 + 1 file changed, 17 insertions(+) diff --git a/linux-user/fd-trans.c b/linux-user/fd

Re: [PATCH v4 7/7] linux-user: netlink: Use QEMU_IFA_XXX values instead of IFA_XXX

2025-01-22 Thread Laurent Vivier
Le 20/01/2025 à 22:33, del...@kernel.org a écrit : From: Helge Deller Convert existing places to use QEMU_IFA_XXX values. Signed-off-by: Helge Deller --- linux-user/fd-trans.c | 16 1 file changed, 8 insertions(+), 8 deletions(-) diff --git a/linux-user/fd-trans.c b/linux

Re: [PATCH] vhost-user: Silence unsupported VHOST_USER_PROTOCOL_F_RARP error

2025-01-22 Thread Laurent Vivier
On 22/01/2025 17:20, Stefano Garzarella wrote: On Wed, Jan 22, 2025 at 08:59:22AM -0500, Michael S. Tsirkin wrote: On Wed, Jan 22, 2025 at 02:42:14PM +0100, Stefano Garzarella wrote: On Tue, Jan 21, 2025 at 11:00:29AM +0100, Laurent Vivier wrote: > In vhost_user_receive()

[PATCH] vhost-user: Silence unsupported VHOST_USER_PROTOCOL_F_RARP error

2025-01-21 Thread Laurent Vivier
pport VHOST_USER_PROTOCOL_F_RARP. Don't report the error if vhost_net_notify_migration_done() returns -ENOTSUP (from vhost_user_migration_done()) Update vhost_net-stub.c to return -ENOTSUP too. Signed-off-by: Laurent Vivier --- hw/net/vhost_net-stub.c | 2 +- net/vhost-user.c| 2 +- 2 files

Re: [PATCH] hw/virtio/vhost: Disable IOTLB callbacks when IOMMU gets disabled

2025-01-21 Thread Laurent Vivier
On 20/01/2025 18:33, Eric Auger wrote: When a guest exposed with a vhost device and protected by an intel IOMMU gets rebooted, we sometimes observe a spurious warning: Fail to lookup the translated address e000 We observe that the IOMMU gets disabled through a write to the global command re

Re: [PATCH v3 1/6] linux-user: netlink: Add missing IFA_PROTO to host_to_target_data_addr_rtattr()

2025-01-20 Thread Laurent Vivier
Le 19/01/2025 à 05:41, del...@kernel.org a écrit : From: Helge Deller Fixes this warning: Unknown host IFA type: 11 Signed-off-by: Helge Deller Reviewed-by: Laurent Vivier --- linux-user/fd-trans.c | 1 + 1 file changed, 1 insertion(+) diff --git a/linux-user/fd-trans.c b/linux-user

Re: [PATCH v3 4/6] linux-user: netlink: Add emulation of IP_MULTICAST_IF

2025-01-20 Thread Laurent Vivier
), the argument is an in_addr structure. Signed-off-by: Helge Deller v2: (based on feedback by Laurent Vivier) - refined commit message and restructure the copying of ip_mreqn fields diff --git a/linux-user/syscall.c b/linux-user/syscall.c index bbe2560927..4360543e20 100644 --- a/linux-user

Re: [PATCH v3 3/6] linux-user: netlink: Add IP_PKTINFO cmsg parsing

2025-01-20 Thread Laurent Vivier
Le 19/01/2025 à 05:41, del...@kernel.org a écrit : From: Helge Deller Fixes those warnings: Unsupported host ancillary data: 0/8 Signed-off-by: Helge Deller v2: (based on feedback by Laurent Vivier) - add target_in_pktinfo struct and fix copying target_in_addr fields --- linux-user

Re: [PATCH 0/2] net: Fix announce_self with vhost

2025-01-17 Thread Laurent Vivier
CC: qemu-stable and qemu-trivial. On 17/01/2025 12:17, Laurent Vivier wrote: announce_self that sends a RARP packet after migration or with announce_self QMP/HMP command doesn't work with vhost because of the vnet headers. announce_self is the only user of QEMU_NET_PACKET_FLAG_RAW and

[PATCH 2/2] net/dump: Correctly compute Ethernet packet offset

2025-01-17 Thread Laurent Vivier
..@daynix.com Signed-off-by: Laurent Vivier --- net/dump.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/net/dump.c b/net/dump.c index d7dd2ce461de..140215aa1054 100644 --- a/net/dump.c +++ b/net/dump.c @@ -155,7 +155,8 @@ static ssize_t filter_dump_receive_iov(NetFi

[PATCH 1/2] net: Fix announce_self

2025-01-17 Thread Laurent Vivier
010: 9a2b 2c2d 2e2f 0x0020: Reported-by: Xiaohui Li Bug: https://issues.redhat.com/browse/RHEL-73891 Fixes: b9ad513e1876 ("net: Remove receive_raw()") Cc: akihiko.od...@daynix.com Signed-off-by: Laurent Vivier ---

[PATCH 0/2] net: Fix announce_self with vhost

2025-01-17 Thread Laurent Vivier
ilter-dump and in qemu_deliver_packet_iov(). Laurent Vivier (2): net: Fix announce_self net/dump: Correctly compute Ethernet packet offset net/dump.c | 3 ++- net/net.c | 1 + 2 files changed, 3 insertions(+), 1 deletion(-) -- 2.47.1

[PATCH v2 0/2] virtio-net: vhost-user: Implement internal migration

2025-01-15 Thread Laurent Vivier
Add support of VHOST_USER_PROTOCOL_F_DEVICE_STATE in virtio-net with vhost-user backend. v2: - Add stubs for the migration state transfer interface Laurent Vivier (2): vhost: Add stubs for the migration state transfer interface virtio-net: vhost-user: Implement internal migration include

[PATCH v2 2/2] virtio-net: vhost-user: Implement internal migration

2025-01-15 Thread Laurent Vivier
Add support of VHOST_USER_PROTOCOL_F_DEVICE_STATE in virtio-net with vhost-user backend. Cc: Hanna Czenczek Signed-off-by: Laurent Vivier --- hw/net/virtio-net.c | 135 1 file changed, 112 insertions(+), 23 deletions(-) diff --git a/hw/net/virtio

[PATCH v2 1/2] vhost: Add stubs for the migration state transfer interface

2025-01-15 Thread Laurent Vivier
vhost_supports_device_state(), vhost_save_backend_state() and vhost_load_backend_state(). Cc: Hanna Czenczek Signed-off-by: Laurent Vivier --- include/hw/virtio/vhost.h | 23 +++ 1 file changed, 23 insertions(+) diff --git a/include/hw/virtio/vhost.h b/include/hw/virtio/vhost.h

Re: [PATCH] virtio-net: vhost-user: Implement internal migration

2025-01-15 Thread Laurent Vivier
On 15/01/2025 11:10, Michael S. Tsirkin wrote: On Wed, Dec 18, 2024 at 03:34:53PM +0100, Laurent Vivier wrote: Add support of VHOST_USER_PROTOCOL_F_DEVICE_STATE in virtio-net with vhost-user backend. Cc: Hanna Czenczek Signed-off-by: Laurent Vivier Breaks windows builds: https

Re: [PATCH v2 5/6] linux-user: netlink: add netlink neighbour emulation

2025-01-10 Thread Laurent Vivier
tr(NDM_RTA(ndm), nlh->nlmsg_len - + NLMSG_LENGTH(sizeof(*ndm))); +} +break; case RTM_NEWROUTE: case RTM_DELROUTE: case RTM_GETROUTE: Reviewed-by: Laurent Vivier

Re: [PATCH v2 6/6] linux-user: netlink: Add missing QEMU_IFLA entries

2025-01-10 Thread Laurent Vivier
uot;Unknown host QEMU_IFLA type: %d\n", rtattr->rta_type); Reviewed-by: Laurent Vivier

Re: [PATCH v2 4/6] linux-user: netlink: Add emulation of IP_MULTICAST_IF

2025-01-10 Thread Laurent Vivier
Le 27/12/2024 à 21:54, del...@kernel.org a écrit : From: Helge Deller Share code with IP_ADD_MEMBERSHIP/IP_DROP_MEMBERSHIP. Signed-off-by: Helge Deller --- linux-user/syscall.c | 13 +++-- 1 file changed, 11 insertions(+), 2 deletions(-) diff --git a/linux-user/syscall.c b/linux-u

Re: [PATCH v2 3/6] linux-user: netlink: Add IP_PKTINFO cmsg parsing

2025-01-10 Thread Laurent Vivier
Le 27/12/2024 à 21:54, del...@kernel.org a écrit : From: Helge Deller Fixes those warnings: Unsupported host ancillary data: 0/8 Signed-off-by: Helge Deller --- linux-user/syscall.c | 12 1 file changed, 12 insertions(+) diff --git a/linux-user/syscall.c b/linux-user/syscal

Re: [PATCH v2 1/6] linux-user: netlink: Add missing IFA_PROTO to host_to_target_data_addr_rtattr()

2025-01-10 Thread Laurent Vivier
; /* string */ case IFA_LABEL: Reviewed-by: Laurent Vivier

Re: [PATCH] virtio-net: vhost-user: Implement internal migration

2025-01-08 Thread Laurent Vivier
On 18/12/2024 15:34, Laurent Vivier wrote: Add support of VHOST_USER_PROTOCOL_F_DEVICE_STATE in virtio-net with vhost-user backend. Cc: Hanna Czenczek Signed-off-by: Laurent Vivier --- hw/net/virtio-net.c | 135 1 file changed, 112 insertions

Re: [PULL 2/6] linux-user: Use unique error messages for cmsg parsing

2024-12-24 Thread Laurent Vivier
og_mask(LOG_UNIMP, "Unsupported host ancillary data: %d/%d\n", cmsg->cmsg_level, cmsg->cmsg_type); memcpy(target_data, data, MIN(len, tgt_len)); if (tgt_len > len) { Reviewed-by: Laurent Vivier

Re: [PULL 1/6] linux-user: netlink: Add missing IFA_PROTO to host_to_target_data_addr_rtattr()

2024-12-24 Thread Laurent Vivier
Le 18/12/2024 à 20:52, del...@kernel.org a écrit : From: Helge Deller Fixes this warning: Unknown host IFA type: 11 Signed-off-by: Helge Deller --- linux-user/fd-trans.c | 1 + 1 file changed, 1 insertion(+) diff --git a/linux-user/fd-trans.c b/linux-user/fd-trans.c index c04a97c73a..61

[PATCH] virtio-net: vhost-user: Implement internal migration

2024-12-18 Thread Laurent Vivier
Add support of VHOST_USER_PROTOCOL_F_DEVICE_STATE in virtio-net with vhost-user backend. Cc: Hanna Czenczek Signed-off-by: Laurent Vivier --- hw/net/virtio-net.c | 135 1 file changed, 112 insertions(+), 23 deletions(-) diff --git a/hw/net/virtio

[PATCH] qmp: update vhost-user protocol feature maps

2024-12-16 Thread Laurent Vivier
e for migration state transfer") Cc: hre...@redhat.com Signed-off-by: Laurent Vivier --- hw/virtio/virtio-qmp.c | 6 ++ 1 file changed, 6 insertions(+) diff --git a/hw/virtio/virtio-qmp.c b/hw/virtio/virtio-qmp.c index 6fe76183..8a32a3b1052c 100644 --- a/hw/virtio/virtio-qmp.c ++

Re: [PATCH] binfmt: Don't consider riscv{32,64} part of the same family

2024-12-05 Thread Laurent Vivier
Le 04/12/2024 à 11:17, Daniel P. Berrangé a écrit : On Tue, Dec 03, 2024 at 07:57:14AM -0600, Richard Henderson wrote: On 12/3/24 04:35, Peter Maydell wrote: On Tue, 3 Dec 2024 at 10:19, Daniel P. Berrangé wrote: Separatley this from patch, we should also consider whether it is time to do the

Re: [PATCH] binfmt: Don't consider riscv{32,64} part of the same family

2024-12-04 Thread Laurent Vivier
ff\xff\xff\xff\xff\xff\xff\xfe\xff\xff\xff' @@ -168,9 +168,6 @@ qemu_get_family() { sparc*) echo "sparc" ;; -riscv*) -echo "riscv" - ;; loongarch*) echo "loongarch" ;; Reviewed-by: Laurent Vivier

Re: [PULL 0/6] Net patches

2024-11-25 Thread Laurent Vivier
Hi Jason, "[PATCH] virtio-net: Add queues before loading them" is missing from this PR. Thanks, Laurent On 25/11/2024 07:08, Jason Wang wrote: The following changes since commit 6b99bb046dd36a6dd5525b8f88c2dcddae49222a: Merge tag 'pull-lu-20241122' of https://gitlab.com/rth7680/qemu into s

Re: [PATCH] virtio-net: Add queues before loading them

2024-11-13 Thread Laurent Vivier
elements in them will not be processed. Cc: qemu-sta...@nongnu.org Fixes: 8c49756825da ("virtio-net: Add only one queue pair when realizing") Reported-by: Laurent Vivier Signed-off-by: Akihiko Odaki Acked-by: Michael S. Tsirkin Jason, your queue? Yes, queued. Is this

Re: [PATCH] linux-user: Fix build failure caused by missing __u64 on musl

2024-10-22 Thread Laurent Vivier
_t mode; +uint64_t resolve; }; struct target_open_how_ver0 { abi_ullong flags; Reviewed-by: Laurent Vivier

Re: [PULL 08/20] virtio-net: Add only one queue pair when realizing

2024-10-17 Thread Laurent Vivier
On 17/10/2024 11:07, Akihiko Odaki wrote: On 2024/10/17 16:32, Laurent Vivier wrote: On 17/10/2024 08:59, Jason Wang wrote: On Mon, Oct 14, 2024 at 11:16 PM Laurent Vivier wrote: On 14/10/2024 10:30, Laurent Vivier wrote: Hi Akihiko, On 04/06/2024 09:37, Jason Wang wrote: From: Akihiko

Re: [PULL 08/20] virtio-net: Add only one queue pair when realizing

2024-10-17 Thread Laurent Vivier
On 17/10/2024 08:59, Jason Wang wrote: On Mon, Oct 14, 2024 at 11:16 PM Laurent Vivier wrote: On 14/10/2024 10:30, Laurent Vivier wrote: Hi Akihiko, On 04/06/2024 09:37, Jason Wang wrote: From: Akihiko Odaki Multiqueue usage is not negotiated yet when realizing. If more than one queue is

Re: [PATCH] linux-user: Emulate /proc/self/maps under mmap_lock

2024-10-15 Thread Laurent Vivier
} +mmap_unlock(); return 0; } Reviewed-by: Laurent Vivier

Re: [PULL 08/20] virtio-net: Add only one queue pair when realizing

2024-10-14 Thread Laurent Vivier
On 14/10/2024 10:30, Laurent Vivier wrote: Hi Akihiko, On 04/06/2024 09:37, Jason Wang wrote: From: Akihiko Odaki Multiqueue usage is not negotiated yet when realizing. If more than one queue is added and the guest never requests to enable multiqueue, the extra queues will not be deleted

Re: [PULL 08/20] virtio-net: Add only one queue pair when realizing

2024-10-14 Thread Laurent Vivier
Hi Akihiko, On 04/06/2024 09:37, Jason Wang wrote: From: Akihiko Odaki Multiqueue usage is not negotiated yet when realizing. If more than one queue is added and the guest never requests to enable multiqueue, the extra queues will not be deleted when unrealizing and leak. Fixes: f9d6dbf0bf6e

Re: [PATCH] MAINTAINERS: A new maintainer for the qtests

2024-10-11 Thread Laurent Vivier
https://repo.or.cz/qemu/armbru.git qapi-next qtest -M: Thomas Huth +M: Fabiano Rosas M: Laurent Vivier R: Paolo Bonzini S: Maintained @@ -3268,7 +3268,7 @@ M: Alexander Bulekov R: Paolo Bonzini R: Bandan Das R: Stefan Hajnoczi -R: Thomas Huth +R: Fabiano Rosas R: Darren Kenny

Re: [PATCH] sched_attr: Do not define for glibc >= 2.41

2024-10-11 Thread Laurent Vivier
/trunk [1] https://sourceware.org/git/? p=glibc.git;a=commitdiff;h=21571ca0d70302909cf72707b2a7736cf12190a0;hp=298bc488fdc047da37482f4003023cb9adef78f8 Signed-off-by: Khem Raj Cc: Laurent Vivier (m Hi, I think it would be better to test in meson.build (with cc.has_type), as is already done in

[PATCH] MAINTAINERS: remove gensyscalls.sh from the linux-user section

2024-10-03 Thread Laurent Vivier
The file has been removed by c52e40596834 ("linux-user,loongarch: move to syscalltbl file"). Signed-off-by: Laurent Vivier --- MAINTAINERS | 1 - 1 file changed, 1 deletion(-) diff --git a/MAINTAINERS b/MAINTAINERS index ffacd60f4075..4a6b6ce6006f 100644 --- a/MAINTAINERS +++ b/M

Re: [PATCH v1] linux-user: Add option to run `execve`d programs through QEMU

2024-10-02 Thread Laurent Vivier
Le 02/10/2024 à 16:53, Ilya Leoshkevich a écrit : On Wed, 2024-10-02 at 09:44 -0500, Noah Goldstein wrote: On Wed, Oct 2, 2024 at 9:38 AM Ilya Leoshkevich wrote: On Wed, 2024-10-02 at 16:08 +0200, Laurent Vivier wrote: Le 02/10/2024 à 10:08, Ilya Leoshkevich a écrit : On Fri, 2024-08-30 at

Re: [PATCH v1] linux-user: Add option to run `execve`d programs through QEMU

2024-10-02 Thread Laurent Vivier
Le 02/10/2024 à 10:08, Ilya Leoshkevich a écrit : On Fri, 2024-08-30 at 15:36 -0700, Noah Goldstein wrote: The new option '-qemu-children' makes it so that on `execve` the child process will be launch by the same `qemu` executable that is currently running along with its current commandline argu

Re: [PATCH] linux-user/elfload.c: keep GNU0_MAGIC in host byte order

2024-10-02 Thread Laurent Vivier
| 'N' << 8 | 'U' << 16, NOTE_DATA_SZ = 1 * KiB, NOTE_NAME_SZ = 4, ELF_GNU_PROPERTY_ALIGN = ELF_CLASS == ELFCLASS32 ? 4 : 8, Reviewed-by: Laurent Vivier Thanks, Laurent

Re: [PATCH v9 2/2] linux-user: add strace support for openat2

2024-10-01 Thread Laurent Vivier
/syscall.c | 8 +-- linux-user/syscall_defs.h | 5 + meson.build | 1 + 6 files changed, 63 insertions(+), 7 deletions(-) Reviewed-by: Laurent Vivier

Re: [PATCH v9 1/2] linux-user: add openat2 support in linux-user

2024-10-01 Thread Laurent Vivier
t Buglink: https://github.com/osbuild/bootc-image-builder/issues/619 --- linux-user/syscall.c | 105 +- linux-user/syscall_defs.h | 13 + 2 files changed, 116 insertions(+), 2 deletions(-) Reviewed-by: Laurent Vivier

Re: [PATCH v8 2/2] linux-user: add strace support for openat2

2024-10-01 Thread Laurent Vivier
Le 30/09/2024 à 19:07, Michael Vogt a écrit : This commit adds support for the `openat2()` to `QEMU_STRACE`. It will use the `openat2.h` header if available to create user readable flags for the `resolve` argument but does not require the header otherwise. It also makes `copy_struct_from_user()`

Re: [PATCH v8 1/2] linux-user: add openat2 support in linux-user

2024-10-01 Thread Laurent Vivier
t Buglink: https://github.com/osbuild/bootc-image-builder/issues/619 --- linux-user/syscall.c | 105 +- linux-user/syscall_defs.h | 13 + 2 files changed, 116 insertions(+), 2 deletions(-) Reviewed-by: Laurent Vivier

Re: [PATCH v3 15/22] linux-user/hppa: fix -Werror=maybe-uninitialized false-positive

2024-10-01 Thread Laurent Vivier
Le 30/09/2024 à 15:26, Marc-André Lureau a écrit : Hi Laurent On Mon, Sep 30, 2024 at 4:19 PM Laurent Vivier wrote: CC Helge Deller Le 30/09/2024 à 10:14, marcandre.lur...@redhat.com a écrit : From: Marc-André Lureau ../linux-user/hppa/cpu_loop.c: In function ‘hppa_lws’: ../linux-user

Re: [PATCH v3 15/22] linux-user/hppa: fix -Werror=maybe-uninitialized false-positive

2024-09-30 Thread Laurent Vivier
CC Helge Deller Le 30/09/2024 à 10:14, marcandre.lur...@redhat.com a écrit : From: Marc-André Lureau ../linux-user/hppa/cpu_loop.c: In function ‘hppa_lws’: ../linux-user/hppa/cpu_loop.c:106:17: error: ‘ret’ may be used uninitialized [-Werror=maybe-uninitialized] 106 | env->gr[28] = ret

Re: [PATCH v7 1/2] linux-user: add openat2 support in linux-user

2024-09-28 Thread Laurent Vivier
ze); +} +return ret; +} +pathname = lock_user_string(guest_pathname); +if (!pathname) { +return -TARGET_EFAULT; +} + +how.flags = target_to_host_bitmask(how.flags, fcntl_flags_tbl); I think you need also a tswap64(how.flags) here. Otherwise: Reviewed-by: Laurent Vivier Thanks, Laurent

Re: [PATCH v7 2/2] linux-user: add strace support for openat2

2024-09-28 Thread Laurent Vivier
Le 23/09/2024 à 21:37, Michael Vogt a écrit : This commit adds support for the `openat2()` to `QEMU_STRACE`. It will use the `openat2.h` header if available to create user readable flags for the `resolve` argument but does not require the header otherwise. It also makes `copy_struct_from_user()`

[PATCH 2/6] linux-user,openrisc: move to syscalltbl file

2024-09-20 Thread Laurent Vivier
from linux v6.11 using updated scripts/update-syscalltbl.sh Signed-off-by: Laurent Vivier --- configs/targets/or1k-linux-user.mak | 2 + linux-user/meson.build | 1 + linux-user/openrisc/meson.build | 5 + linux-user/openrisc/syscall.tbl | 405

[PATCH 6/6] linux-user: update syscall.tbl to Linux v6.11

2024-09-20 Thread Laurent Vivier
Updated running scripts/update-syscalltbl.sh Signed-off-by: Laurent Vivier --- linux-user/arm/syscall.tbl | 1 + linux-user/i386/syscall_32.tbl | 7 --- linux-user/x86_64/syscall_64.tbl | 8 +--- 3 files changed, 10 insertions(+), 6 deletions(-) diff --git a/linux-user/arm

[PATCH 3/6] linux-user,riscv: move to syscalltbl file

2024-09-20 Thread Laurent Vivier
6.11 using updated scripts/update-syscalltbl.sh Signed-off-by: Laurent Vivier --- configs/targets/riscv32-linux-user.mak | 3 + configs/targets/riscv64-linux-user.mak | 3 + linux-user/riscv/cpu_loop.c| 2 +- linux-user/riscv/meson.build | 6 + linux-user/riscv/s

[PATCH 4/6] linux-user,hexagon: move to syscalltbl file

2024-09-20 Thread Laurent Vivier
6.11 using updated scripts/update-syscalltbl.sh Signed-off-by: Laurent Vivier --- configs/targets/hexagon-linux-user.mak | 2 + linux-user/hexagon/meson.build | 6 + linux-user/hexagon/syscall.tbl | 405 + linux-user/hexagon/syscall_nr.h

[PATCH 1/6] linux-user,aarch64: move to syscalltbl file

2024-09-20 Thread Laurent Vivier
from linux v6.11 using updated scripts/update-syscalltbl.sh Signed-off-by: Laurent Vivier --- configs/targets/aarch64-linux-user.mak| 2 + configs/targets/aarch64_be-linux-user.mak | 2 + linux-user/aarch64/meson.build| 6 + linux-user/aarch64/syscall_64.tbl

[PATCH 0/6] linux-user: move all remaining archs to syscalltbl

2024-09-20 Thread Laurent Vivier
linux v6.11 has moved all the remaining archs to syscalltbl, update QEMU accordingly. Remove scripts/gensyscalls.sh that is now useless. Update headers to v6.11 Based-on: <20240918074256.720617-1-laur...@vivier.eu> Laurent Vivier (6): linux-user,aarch64: move to syscalltbl file linu

[PATCH 5/6] linux-user,loongarch: move to syscalltbl file

2024-09-20 Thread Laurent Vivier
inux v6.11 using updated scripts/update-syscalltbl.sh Remove scripts/gensyscalls.sh that is now useless. Signed-off-by: Laurent Vivier --- configs/targets/loongarch64-linux-user.mak | 2 + linux-user/loongarch64/meson.build | 7 + linux-user/loongarch64/syscall.tbl

Re: [PATCH v6 1/1] linux-user: add openat2 support in linux-user

2024-09-20 Thread Laurent Vivier
ned-off-by: Michael Vogt Buglink: https://github.com/osbuild/bootc-image-builder/issues/619 --- linux-user/syscall.c | 108 +- linux-user/syscall_defs.h | 7 +++ 2 files changed, 113 insertions(+), 2 deletions(-) Reviewed-by: Laurent Vivier

Re: [PATCH v5 1/1] linux-user: add openat2 support in linux-user

2024-09-19 Thread Laurent Vivier
Le 19/09/2024 à 21:46, Michael Vogt a écrit : This commit adds support for the `openat2()` syscall in the `linux-user` userspace emulator. It is implemented by extracting a new helper `maybe_do_fake_open()` out of the exiting `do_guest_openat()` and share that with the new `do_guest_openat2()`.

Re: [PATCH v5 1/1] linux-user: add openat2 support in linux-user

2024-09-19 Thread Laurent Vivier
Hi, your PATCH 1/1 doesn't appear to be a reply of PATCH 0/1 (mail header tag "In-Reply-To:"/"Reference") so it is not correctly collected by patchew.org. Do you have the 'thread' parameter for git-send-email? See my comments below: Le 19/09/2024 à 21:46, Michael Vogt a écrit : This commit

Re: [PATCH v4 1/1] linux-user: add openat2 support in linux-user

2024-09-19 Thread Laurent Vivier
Le 06/09/2024 à 09:39, Michael Vogt a écrit : This commit adds support for the `openat2()` syscall in the `linux-user` userspace emulator. It is implemented by extracting a new helper `maybe_do_fake_open()` out of the exiting `do_guest_openat()` and share that with the new `do_guest_openat2()`.

Re: [PATCH 1/3] linux-user: update syscall_nr.h to Linux v6.10

2024-09-19 Thread Laurent Vivier
Le 18/09/2024 à 17:41, Brian Cain a écrit : On 9/18/2024 2:42 AM, Laurent Vivier wrote: Automatically generated using scripts/gensyscalls.sh Signed-off-by: Laurent Vivier ---   linux-user/aarch64/syscall_nr.h | 19 ++-   linux-user/hexagon/syscall_nr.h | 20

[PATCH 1/3] linux-user: update syscall_nr.h to Linux v6.10

2024-09-18 Thread Laurent Vivier
Automatically generated using scripts/gensyscalls.sh Signed-off-by: Laurent Vivier --- linux-user/aarch64/syscall_nr.h | 19 ++- linux-user/hexagon/syscall_nr.h | 20 ++-- linux-user/loongarch64/syscall_nr.h | 14 +- linux-user/openrisc

[PATCH 2/3] linux-user, mips: update syscall-args-o32.c.inc to Linux v6.10

2024-09-18 Thread Laurent Vivier
Updated running scripts/update-mips-syscall-args.sh Signed-off-by: Laurent Vivier --- linux-user/mips/syscall-args-o32.c.inc | 20 1 file changed, 20 insertions(+) diff --git a/linux-user/mips/syscall-args-o32.c.inc b/linux-user/mips/syscall-args-o32.c.inc index

[PATCH 3/3] linux-user: update syscall.tbl to Linux v6.10

2024-09-18 Thread Laurent Vivier
Updated running scripts/update-syscalltbl.sh Signed-off-by: Laurent Vivier --- linux-user/alpha/syscall.tbl | 28 +--- linux-user/arm/syscall.tbl| 24 +-- linux-user/hppa/syscall.tbl | 41 -- linux-user/i386/syscall_32.tbl| 28

[PATCH 0/3] linux-user: Update syscall numbers

2024-09-18 Thread Laurent Vivier
Run scripts/gensyscalls.sh, scripts/update-mips-syscall-args.sh and scripts/update-syscalltbl.sh to update syscall numbers to linux v6.10 Laurent Vivier (3): linux-user: update syscall_nr.h to Linux v6.10 linux-user, mips: update syscall-args-o32.c.inc to Linux v6.10 linux-user: update

Re: [PATCH] virtio-rng: block max-bytes=0

2024-07-30 Thread Laurent Vivier
On 24/07/2024 12:51, Michael S. Tsirkin wrote: with max-bytes set to 0, quota is 0 and so device does not work. block this to avoid user confusion Signed-off-by: Michael S. Tsirkin --- hw/virtio/virtio-rng.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/hw/virtio/v

Re: [PATCH v2 0/4] net: update netdev stream/dgram man page

2024-07-24 Thread Laurent Vivier
On 04/07/2024 14:48, Laurent Vivier wrote: Add the description of "-netdev stream" and "-netdev dgram" in the QEMU manpage. Add some examples on how to use them, including a way to use "-netdev stream" and "passt" in place of "-netdev user&quo

Re: [PATCH] virtio-rng: block max-bytes=0

2024-07-24 Thread Laurent Vivier
error_setg(errp, "'max-bytes' parameter must be positive, " "and less than 2^63"); return; } Reviewed-by: Laurent Vivier

[PATCH v2 2/4] net: update netdev stream man page with unix socket

2024-07-04 Thread Laurent Vivier
d translation proxy between layer-2, like "-netdev stream", and layer-4 on host, like TCP, UDP, ICMP/ICMPv6 echo) Fixes: 13c6be96618c ("net: stream: add unix socket") Signed-off-by: Laurent Vivier --- qemu-options.hx | 40 1 file changed,

[PATCH v2 3/4] net: update netdev dgram man page with unix socket

2024-07-04 Thread Laurent Vivier
Add the description of "-netdev dgram" with a unix domain socket. The code has been added but the man page has not been updated. Fixes: 784e7a253104 ("net: dgram: add unix socket") Signed-off-by: Laurent Vivier --- qemu-options.hx | 23 +++ 1 file ch

[PATCH v2 4/4] net: update netdev stream man page with the reconnect parameter

2024-07-04 Thread Laurent Vivier
"-netdev stream" supports a reconnect parameter that attempts to reconnect automatically the socket if it is disconnected. The code has been added but the man page has not been updated. Fixes: 148fbf0d58a6 ("net: stream: add a new option to automatically reconnect" Signed-of

[PATCH v2 0/4] net: update netdev stream/dgram man page

2024-07-04 Thread Laurent Vivier
on proxy between layer-2, like "-netdev stream", and layer-4 on host, like TCP, UDP, ICMP/ICMPv6 echo) v2: - split patch - update unix socket description with stream and datagram words. Laurent Vivier (4): net: update netdev stream/dgram man page net: update netdev stream m

[PATCH v2 1/4] net: update netdev stream/dgram man page

2024-07-04 Thread Laurent Vivier
Add the description of "-netdev stream" and "-netdev dgram" in the QEMU manpage. Add some examples on how to use them. Fixes: 5166fe0ae46d ("qapi: net: add stream and dgram netdevs") Signed-off-by: Laurent Vivier --- qemu-options.hx | 114 +

Re: [PATCH] net: update netdev stream/dgram man page

2024-07-04 Thread Laurent Vivier
Hi Marc-André, thank you for your comments, you're right I should not mix TCP/UDP and unix socket. I'm going to fix that. Thanks, Laurent On 02/07/2024 09:39, Marc-André Lureau wrote: Hi On Wed, Jun 26, 2024 at 7:53 PM Laurent Vivier <mailto:lviv...@redhat.com>> w

Re: [PATCH] net: update netdev stream/dgram man page

2024-07-02 Thread Laurent Vivier
On 02/07/2024 10:08, Marc-André Lureau wrote: Hi On Wed, Jun 26, 2024 at 7:53 PM Laurent Vivier <mailto:lviv...@redhat.com>> wrote: Add the description of "-netdev stream" and "-netdev dgram" in the QEMU manpage. Add some examples on how to use

[PATCH] net: update netdev stream/dgram man page

2024-06-26 Thread Laurent Vivier
socket") Fixes: 148fbf0d58a6 ("net: stream: add a new option to automatically reconnect" Signed-off-by: Laurent Vivier --- qemu-options.hx | 189 1 file changed, 189 insertions(+) diff --git a/qemu-options.hx b/qemu-options.hx in

Re: [PATCH 0/4] hw/m68k/virt: Add some devices

2024-06-20 Thread Laurent Vivier
Le 27/05/2024 à 19:15, Jiaxun Yang a écrit : Hi all, This series added some devices that I found lacking when I was trying to port U-Boot to m68k virt machine. I have a branch with a bootloader based on petitboot. See https://github.com/vivier/qemu-m68k/commits/m68k-virt/ Thanks Laurent P

Re: [PULL 0/4] Trivial patches for 2024-04-02

2024-04-02 Thread Laurent Vivier
Le 02/04/2024 à 12:41, Michael Tokarev a écrit : Author: Stefan Weil via *SIGH*  This happened *again*. (you'll need to tell git log "--no-mailmap" to not get confused by the mapping we have for the last time one of these slipped through...) Now this is interesting.  And this is exactly

[PULL 1/1] virt: set the CPU type in BOOTINFO

2024-03-11 Thread Laurent Vivier
ned-off-by: Laurent Vivier Reviewed-by: Mark Cave-Ayland Message-ID: <20240223155742.2790252-1-laur...@vivier.eu> --- hw/m68k/virt.c | 17 ++--- 1 file changed, 14 insertions(+), 3 deletions(-) diff --git a/hw/m68k/virt.c b/hw/m68k/virt.c index e2792ef46d93..b8e5e102e6b9 100644 ---

[PULL 0/1] M68k for 9.0 patches

2024-03-11 Thread Laurent Vivier
k 20240311 ---- Laurent Vivier (1): virt: set the CPU type in BOOTINFO hw/m68k/virt.c | 17 ++--- 1 file changed, 14 insertions(+), 3 deletions(-) -- 2.43.2

Re: [PATCH v3 2/2] e1000e: fix link state on resume

2024-03-08 Thread Laurent Vivier
On 3/8/24 09:56, Laurent Vivier wrote: On resume e1000e_vm_state_change() always calls e1000e_autoneg_resume() that sets link_down to false, and thus activates the link even if we have disabled it. The problem can be reproduced starting qemu in paused state (-S) and then set the link to down

[PATCH v3 1/2] igb: fix link state on resume

2024-03-08 Thread Laurent Vivier
ecute": "cont" } To fix the problem, merge the content of igb_vm_state_change() into igb_core_post_load() as e1000 does. Buglink: https://issues.redhat.com/browse/RHEL-21867 Suggested-by: Akihiko Odaki Signed-off-by: Laurent Vivier --- hw/net/igb_core.c | 47 +++

[PATCH v3 2/2] e1000e: fix link state on resume

2024-03-08 Thread Laurent Vivier
te": "cont" } To fix the problem, merge the content of e1000e_vm_state_change() into e1000e_core_post_load() as e1000 does. Buglink: https://issues.redhat.com/browse/RHEL-21867 Suggested-by: Akihiko Odaki Signed-off-by: Laurent Vivier --- hw/net/e1000e_core.c | 56 +++-

Re: [PATCH v2 2/2] e1000e: fix link state on resume

2024-03-08 Thread Laurent Vivier
On 3/8/24 09:09, Jason Wang wrote: On Tue, Mar 5, 2024 at 6:07 PM Laurent Vivier wrote: On 2/1/24 06:45, Jason Wang wrote: On Wed, Jan 24, 2024 at 6:40 PM Laurent Vivier wrote: On resume e1000e_vm_state_change() always calls e1000e_autoneg_resume() that sets link_down to false, and thus

Re: [PATCH v2 2/2] e1000e: fix link state on resume

2024-03-05 Thread Laurent Vivier
On 2/1/24 06:45, Jason Wang wrote: On Wed, Jan 24, 2024 at 6:40 PM Laurent Vivier wrote: On resume e1000e_vm_state_change() always calls e1000e_autoneg_resume() that sets link_down to false, and thus activates the link even if we have disabled it. The problem can be reproduced starting qemu

[PATCH] virt: set the CPU type in BOOTINFO

2024-02-23 Thread Laurent Vivier
ned-off-by: Laurent Vivier --- hw/m68k/virt.c | 17 ++--- 1 file changed, 14 insertions(+), 3 deletions(-) diff --git a/hw/m68k/virt.c b/hw/m68k/virt.c index e2792ef46d93..b8e5e102e6b9 100644 --- a/hw/m68k/virt.c +++ b/hw/m68k/virt.c @@ -239,9 +239,20 @@ static void virt_init(MachineStat

Re: [PATCH v3 0/3] nubus: add nubus-virtio-mmio device

2024-02-23 Thread Laurent Vivier
, 154 insertions(+), 5 deletions(-) create mode 100644 hw/nubus/nubus-virtio-mmio.c create mode 100644 include/hw/nubus/nubus-virtio-mmio.h Series Reviewed-by: Laurent Vivier

Re: [PATCH] target/m68k: Fix exception frame format for 68010

2024-02-23 Thread Laurent Vivier
RMAT_VEC)) { /* all except 68000 */ CPUState *cs = env_cpu(env); switch (format) { Reviewed-by: Laurent Vivier

Re: [PATCH] iothread: Simplify expression in qemu_in_iothread()

2024-02-08 Thread Laurent Vivier
: true; +return qemu_get_current_aio_context() != qemu_get_aio_context(); } Reviewed-by: Laurent Vivier

Re: [PATCH trivial 1/2] close_all_open_fd(): move to oslib-posix.c

2024-01-25 Thread Laurent Vivier
Le 25/01/2024 à 23:29, Michael Tokarev a écrit : Initially in async-teardown.c, but the same construct is used elsewhere too. Signed-off-by: Michael Tokarev --- include/sysemu/os-posix.h | 1 + system/async-teardown.c | 37 + util/oslib-posix.c

[PATCH v2 2/2] e1000e: fix link state on resume

2024-01-24 Thread Laurent Vivier
te": "cont" } To fix the problem, merge the content of e1000e_vm_state_change() into e1000e_core_post_load() as e1000 does. Buglink: https://issues.redhat.com/browse/RHEL-21867 Fixes: 6f3fbe4ed06a ("net: Introduce e1000e device emulation") Suggested-by: Akihiko Odaki Sig

  1   2   3   4   5   6   7   8   9   10   >