From: Blue Swirl
The qemu_irq for Terminal Count (TC) line between FDC and Slavio misc
device was created only after use, spotted by Clang compiler. Also,
it was not created if the FDC didn't exist.
Rearrange code to fix order. Always create the TC line.
Signed-off-by: Blue Swirl
---
hw/sun4m
From: Blue Swirl
Clang compiler warns about a few constructs in QEMU code. It's possible
to avoid those but that needs more work.
Suppress some warnings for Clang compiler. -Wno-unused-value would
conflict with GCC.
Signed-off-by: Blue Swirl
---
configure |5 -
1 files changed, 4 inse
From: Blue Swirl
err was uninitalized, it's not OK to use |=. Spotted by Clang
compiler.
Fix by replacing |= by =.
Signed-off-by: Blue Swirl
---
linux-user/signal.c |2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/linux-user/signal.c b/linux-user/signal.c
index 97f30d
From: Blue Swirl
Global register AREG0 was always assumed to be usable in user-exec.c,
but this is incorrect for several targets.
Fix with #ifdeffery and by using other variables.
Signed-off-by: Blue Swirl
---
user-exec.c | 17 -
1 files changed, 12 insertions(+), 5 deletion
From: Blue Swirl
Clang compiler complained about use of reserved word 'restrict' in SLIRP
and QAPI.
Rename 'restrict' to 'restricted' which also matches other SLIRP code.
Signed-off-by: Blue Swirl
---
net/slirp.c |6 +++---
qapi-schema.json |4 ++--
2 files changed, 5 insertions(
From: Blue Swirl
With this patch set, I'm able to compile AREG0 free softmmu targets.
Blue Swirl (5):
sparc: fix floppy TC line setup
sparc: fix expression with uninitialized initial value
qapi: avoid reserved word restrict
user: fix accidental AREG0 use
configure: disable a few Clang
From: Blue Swirl
Use 'unsigned int' for bit numbers instead of 'unsigned long' or
'int'. Adjust asserts.
Signed-off-by: Blue Swirl
---
bitops.h | 46 ++
1 files changed, 26 insertions(+), 20 deletions(-)
diff --git a/bitops.h b/bitops.h
index b967
From: Blue Swirl
Use 'bool' type for return value of bit test functions.
Signed-off-by: Blue Swirl
---
bitops.h |8
1 files changed, 4 insertions(+), 4 deletions(-)
diff --git a/bitops.h b/bitops.h
index bc99727..1cecf00 100644
--- a/bitops.h
+++ b/bitops.h
@@ -153,7 +153,7 @@ st
From: Blue Swirl
Qualifier 'volatile' is not useful for applications, it's too strict
for single threaded code but does not give the real atomicity guarantees
needed for multithreaded code.
Drop them.
Signed-off-by: Blue Swirl
---
bitops.h | 18 +++---
1 files changed, 7 inserti
From: Blue Swirl
Improve bit operations.
v1->v2
Split from single patch.
Blue Swirl (3):
bitops: fix types
bitops: drop volatile qualifier
bitops: use bool
bitops.h | 42 ++
1 files changed, 22 insertions(+), 20 deletions(-)
--
1.7.2.5
From: Blue Swirl
Replace %m format with explicit call to standard strerror().
Signed-off-by: Blue Swirl
---
kvm-all.c |3 ++-
main-loop.c |2 +-
net/tap-linux.c |8 +---
qemu-nbd.c |3 +--
4 files changed, 9 insertions(+), 7 deletions(-)
diff --git a/kvm-all
From: Blue Swirl
Replace expr1 ?: expr2 with expr1 ? expr1 : expr2 as K&R intended.
If expr1 has side effects, introduce a temporary variable.
Signed-off-by: Blue Swirl
---
block.c |6 --
block/qcow2.c|6 --
bt-vhci.c|2 +-
hw/bt-hci.c
From: Blue Swirl
Replace asm and __asm with __asm__.
Signed-off-by: Blue Swirl
---
bswap.h | 40
cache-utils.h | 10 +-
exec-all.h|6 +++---
qemu-barrier.h| 14 +++---
qemu-timer.h
From: Blue Swirl
It's silly and non-conforming to standards to return void,
don't do it.
Signed-off-by: Blue Swirl
---
block.c|2 +-
dma.h |6 +++---
hw/bt-l2cap.c | 11 +++
hw/eepro100.c | 15 +++
hw/ide/cmd646
From: Blue Swirl
System headers (e.g. gutils.h) may define 'inline', #undefine it
before #defining.
Signed-off-by: Blue Swirl
---
osdep.h |2 ++
1 files changed, 2 insertions(+), 0 deletions(-)
diff --git a/osdep.h b/osdep.h
index 3ea4af0..1e15a4b 100644
--- a/osdep.h
+++ b/osdep.h
@@ -70
From: Blue Swirl
I entertained myself by compiling QEMU with -std=c99 -pedantic and
fixing some issues found with that.
v1->v2:
Fix copypasta in 1/5 (Anders Schwab)
Resent with correct address
Blue Swirl (5):
Avoid GCC extension ?:
Avoid returning void
Use __asm__ instead of asm or __asm
From: Blue Swirl
Use 'unsigned int' for bit numbers. Return 'bool' for test functions. QEMU is
not the kernel, we don't need 'volatile'. Adjust asserts.
Signed-off-by: Blue Swirl
---
bitops.h | 47 ---
1 files changed, 24 insertions(+), 23 deletion
From: Blue Swirl
Replace %m format with explicit call to standard strerror().
Signed-off-by: Blue Swirl
---
kvm-all.c |3 ++-
main-loop.c |2 +-
net/tap-linux.c |8 +---
qemu-nbd.c |3 +--
4 files changed, 9 insertions(+), 7 deletions(-)
diff --git a/kvm-all
From: Blue Swirl
Replace expr1 ?: expr2 with expr1 ? expr1 : expr2 as K&R intended.
If expr1 has side effects, introduce a temporary variable.
Signed-off-by: Blue Swirl
---
block.c |6 --
block/qcow2.c|6 --
bt-vhci.c|2 +-
hw/bt-hci.c
From: Blue Swirl
System headers (e.g. gutils.h) may define 'inline', #undefine it
before #defining.
Signed-off-by: Blue Swirl
---
osdep.h |2 ++
1 files changed, 2 insertions(+), 0 deletions(-)
diff --git a/osdep.h b/osdep.h
index 3ea4af0..1e15a4b 100644
--- a/osdep.h
+++ b/osdep.h
@@ -70
From: Blue Swirl
Replace asm and __asm with __asm__.
Signed-off-by: Blue Swirl
---
bswap.h | 40
cache-utils.h | 10 +-
exec-all.h|6 +++---
qemu-barrier.h| 14 +++---
qemu-timer.h
From: Blue Swirl
It's silly and non-conforming to standards to return void,
don't do it.
Signed-off-by: Blue Swirl
---
block.c|2 +-
dma.h |6 +++---
hw/bt-l2cap.c | 11 +++
hw/eepro100.c | 15 +++
hw/ide/cmd646
From: Blue Swirl
I entertained myself by compiling QEMU with -std=c99 -pedantic and
fixing some issues found with that.
Blue Swirl (5):
Avoid GCC extension ?:
Avoid returning void
Use __asm__ instead of asm or __asm
Avoid unportable %m format
Avoid redefining inline
block.c
23 matches
Mail list logo
