Peter Maydell writes:
> On Mon, 16 Jun 2025 at 21:10, Alex Bennée wrote:
>>
>> If the user writes a large value to the register but with the bottom
>> bits unset we could end up with something illegal. By clamping ahead
>> of the check we at least assure we won
ndex 012970f6cc..6fdc1142fb 100644
> --- a/scripts/tracetool/backend/syslog.py
> +++ b/scripts/tracetool/backend/syslog.py
> @@ -30,11 +30,7 @@ def generate_h(event, group):
> if len(event.args) > 0:
> argnames = ", " + argnames
>
> -if "vcpu" in event.properties:
> -# already checked on the generic format code
> -cond = "true"
> -else:
> -cond = "trace_event_get_state(%s)" % ("TRACE_" + event.name.upper())
> +cond = "trace_event_get_state(%s)" % ("TRACE_" + event.name.upper())
>
> out('if (%(cond)s) {',
> '#line %(event_lineno)d "%(event_filename)s"',
--
Alex Bennée
Virtualisation Tech Lead @ Linaro
vanced use cases. I am
however being conservative in adding new APIs so we take the time to get
each one right and minimise:
- leaking internal details and constricting future evolution of the emulator
- giving the users too many foot guns in the API
I'll have a look at the next version and see how we are doing.
--
Alex Bennée
Virtualisation Tech Lead @ Linaro
Yiwei Zhang writes:
> On Sun, Jun 8, 2025 at 1:24 AM Akihiko Odaki
> wrote:
>>
>> On 2025/06/06 1:26, Alex Bennée wrote:
>> > From: Yiwei Zhang
>> >
>> > Venus and later native contexts have their own fence context along wit
further and refer to enabled devices to further
filter out things like option roms.
Signed-off-by: Alex Bennée
---
pc-bios/meson.build | 202
1 file changed, 129 insertions(+), 73 deletions(-)
diff --git a/pc-bios/meson.build b/pc-bios/meson.build
index
oid %(api)s(%(args)s)',
> '{',
> -'if (%(cond)s) {',
> +api=e.api(),
> +args=e.args)
> +
> +if "disable" not in e.properties:
> +backend.generate_unconditional
Tanish Desai writes:
> The vcpu property is no longer used in these backends. Removing it avoids
> unnecessary checks and simplifies the code generation for these trace
> backends.
>
> Signed-off-by: Tanish Desai
Reviewed-by: Alex Bennée
--
Alex Bennée
Virtualisation Tech Lead @ Linaro
Although we are using structure initialisation the order of the
op[012]/cr[nm] fields don't match the rest of the code base.
Re-organise to be consistent and help the poor engineer who is
grepping for system registers.
Signed-off-by: Alex Bennée
---
target/arm/debug_helper.c
For now just deal with the basic version probe we see during startup.
Signed-off-by: Alex Bennée
---
target/arm/kvm.c| 44 +
target/arm/trace-events | 1 +
2 files changed, 45 insertions(+)
diff --git a/target/arm/kvm.c b/target/arm/kvm.c
index
If the user writes a large value to the register but with the bottom
bits unset we could end up with something illegal. By clamping ahead
of the check we at least assure we won't assert(bpr > 0) later in the
GIC interface code.
Signed-off-by: Alex Bennée
---
hw/intc/arm_gicv3_cpu
Fortunately all the information about which sysreg is being accessed
should be in the ISS field of the ESR. Once we process that we can
figure out what we need to do.
[AJB: the read/write stuff should probably go into a shared helper].
Signed-off-by: Alex Bennée
---
target/arm/kvm.c
Previously we suppressed this option as KVM would get confused if it
started trapping GIC system registers without a GIC configured.
However if we know we are trapping harder we can allow it much like we
do for HVF.
Signed-off-by: Alex Bennée
---
target/arm/kvm_arm.h | 8
hw/arm
This allows the vCPU guest core to go to sleep on a WFx instruction.
Signed-off-by: Alex Bennée
---
target/arm/kvm.c| 28
target/arm/trace-events | 1 +
2 files changed, 29 insertions(+)
diff --git a/target/arm/kvm.c b/target/arm/kvm.c
index 1280e2c1e8
Currently we do nothing but report we don't handle anything and let
KVM come to a halt.
Signed-off-by: Alex Bennée
---
target/arm/syndrome.h | 4
target/arm/kvm-stub.c | 5 +
target/arm/kvm.c | 44 +++
3 files changed, 53 inser
Import headers for trap-me-harder, based on 6.15.1.
Signed-off-by: Alex Bennée
---
include/standard-headers/linux/virtio_pci.h | 1 +
linux-headers/linux/kvm.h | 8
linux-headers/linux/vhost.h | 4 ++--
3 files changed, 11 insertions(+), 2 deletions
compile time but until now with no readfn.
Add a .readfn to return the CurrentEL and then loosen the restrictions
in arm_register_sysreg_for_feature to allow ARM_CP_NORAW registers to
be read if there is a readfn available.
Signed-off-by: Alex Bennée
Message-ID: <20250507165840.401623-1-alex.
It would be nice to only have the variable for this is a KVM_ARM_STATE
but currently everything is just held together in the common KVMState.
Only KVM ARM can set the flag though.
Signed-off-by: Alex Bennée
---
include/system/kvm_int.h | 4
target/arm/kvm.c | 19
Signed-off-by: Alex Bennée
---
target/arm/kvm_arm.h | 9 +
hw/arm/virt.c| 7 +--
target/arm/kvm.c | 7 +++
3 files changed, 21 insertions(+), 2 deletions(-)
diff --git a/target/arm/kvm_arm.h b/target/arm/kvm_arm.h
index 7dc83caed5..a4f68e14cb 100644
--- a/target/arm
e.filename=/dev/zen-ssd2/trixie-arm64,discard=unmap
\
-kernel
/home/alex/lsrc/linux.git/builds/arm64/arch/arm64/boot/Image \
-append "root=/dev/sda2" \
-chardev socket,id=vfs,path=/tmp/virtiofsd.sock \
-device vhost-user-fs-pci,chardev=
> b/tests/tcg/x86_64/system/validate-patch.py
> new file mode 100755
> index 00..700950eae5
> --- /dev/null
> +++ b/tests/tcg/x86_64/system/validate-patch.py
> @@ -0,0 +1,39 @@
> +#!/usr/bin/env python3
> +#
> +# validate-patch.py: check the patch applies
> +#
> +# This program takes two inputs:
> +# - the plugin output
> +# - the binary output
> +#
> +# Copyright (C) 2024
> +#
> +# SPDX-License-Identifier: GPL-2.0-or-later
> +
> +import sys
> +from argparse import ArgumentParser
> +
> +def main() -> None:
> +"""
> +Process the arguments, injest the program and plugin out and
> +verify they match up and report if they do not.
> +"""
> +parser = ArgumentParser(description="Validate patch")
> +parser.add_argument('test_output',
> +help="The output from the test itself")
> +parser.add_argument('plugin_output',
> +help="The output from plugin")
> +args = parser.parse_args()
> +
> +with open(args.test_output, 'r') as f:
> +test_data = f.read()
> +with open(args.plugin_output, 'r') as f:
> +plugin_data = f.read()
> +if "Value: 1" in test_data:
> +sys.exit(0)
> +else:
> +sys.exit(1)
> +
> +if __name__ == "__main__":
> +main()
> +
--
Alex Bennée
Virtualisation Tech Lead @ Linaro
known address, not in a current
> translation
> + * block.
My main concern about the long list of caveats for writing memory is the
user will almost certainly cause weird things to happen which will then
be hard to debug. I can see the patcher example however it would be
useful to know what other practical uses this interface provides.
--
Alex Bennée
Virtualisation Tech Lead @ Linaro
Gustavo Romero writes:
> Add a functional test, aarch64_hotplug_pci, to exercise PCI hotplug and
> hot-unplug on arm64.
Queued to testing/next, thanks.
--
Alex Bennée
Virtualisation Tech Lead @ Linaro
t(MemoryListener *listener)
> cpuas = container_of(listener, CPUAddressSpace, tcg_as_listener);
> cpu = cpuas->cpu;
>
> +if (!qdev_is_realized(DEVICE(cpu))) {
> +/*
> + * The listener is also called during realize, before
> + * all of th
If the user writes a large value to the register but with the bottom
bits unset we could end up with something illegal. By clamping ahead
of the check we at least assure we won't assert(bpr > 0) later in the
GIC interface code.
Signed-off-by: Alex Bennée
---
hw/intc/arm_gicv3_cpu
> Signed-off-by: Solomon Tan
Reviewed-by: Alex Bennée
--
Alex Bennée
Virtualisation Tech Lead @ Linaro
| 135 +++-
>> plugins/core.c| 33 +++
>> tests/tcg/Makefile.target | 1 +
>> tests/tcg/plugins/meson.build | 2 +-
>> tests/tcg/plugins/patch.c | 241 ++
&
This bug doesn't affect any of the other board types we model in
> this source file, because they all use either the Cortex-M3 or
> Cortex-M4. Those CPUs do not have an RTL configurable number of
> MPU regions, and always provide 8 regions if the MPU is built in.
With the typo fix:
ve NV support for KVM in QEMU.
BTW Philippe isn't the same test needed above for secure (which can't be
supported even with KVM NV support).
>
> Miguel
>
>> error_report("mach-virt: %s does not support providing "
>> "Virtualization extensions to the guest CPU",
>> current_accel_name());
>> --
>> 2.49.0
>>
>>
--
Alex Bennée
Virtualisation Tech Lead @ Linaro
t AccelOpsClass *ops)
{
assert(ops != NULL);
-assert(ops->create_vcpu_thread != NULL); /* mandatory */
+assert(ops->create_vcpu_thread || ops->cpu_thread_routine); /* mandatory */
cpus_accel = ops;
}
--
Alex Bennée
Virtualisation Tech Lead @ Linaro
Philippe Mathieu-Daudé writes:
> Few changes needed before being able to add the
> split acceleration. Mostly adapting few prototypes
> so callees have all necessary information.
make check-tcg failed:
➜ make check-tcg
/home/alex/lsrc/qemu.git/builds/arm.all/pyvenv/bin/meson i
claration -Wold-style-definition -Wredundant-decls -Wshadow=local
-Wstrict-prototypes -Wtype-limits -Wundef -Wvla -Wwrite-strings
-Wno-missing-include-dirs -Wno-psabi -Wno-shift-negative-value -isystem
/home/alex/lsrc/qemu.git/linux-headers -isystem linux-headers -iquote . -iquote
/home/alex/lsrc/qem
Philippe Mathieu-Daudé writes:
> Signed-off-by: Philippe Mathieu-Daudé
Reviewed-by: Alex Bennée
--
Alex Bennée
Virtualisation Tech Lead @ Linaro
accel/tcg/tcg-accel-ops.c
> +++ b/accel/tcg/tcg-accel-ops.c
> @@ -198,8 +198,10 @@ static inline void tcg_remove_all_breakpoints(CPUState
> *cpu)
> cpu_watchpoint_remove_all(cpu, BP_GDB);
> }
>
> -static void tcg_accel_ops_init(AccelOpsClass *ops)
> +static void
Philippe Mathieu-Daudé writes:
> In order to avoid init_machine() to call current_accel(),
> pass AccelState along.
>
> Signed-off-by: Philippe Mathieu-Daudé
Reviewed-by: Alex Bennée
--
Alex Bennée
Virtualisation Tech Lead @ Linaro
so we're clear
> >>> about the proposed usage.
> >>
> >> yes. And please change the vfio-pci property name to use underscores.
> >
> > Sorry, to *not* use underscores : use-legacy-x86-rom
>
> Thanks for pointing out it. Will fix it.
It's also not evident from the property that this is restricted to
ramfb behavior. Should the option on the vfio-pci device be prefixed
with ramfb? Thanks,
Alex
should rectified if we are no longer running translated code -
indeed currently it is rectified by the time we leave the translated
block and before we start the next one.
There are some edge cases when we handle exceptions but we should have
fixed up any register state before we longjmp back to the start of the
run loop.
--
Alex Bennée
Virtualisation Tech Lead @ Linaro
Hi,
The KVM/QEMU community call is at:
https://meet.jit.si/kvmcallmeeting
@
10/06/2025 14:00 UTC
Are there any agenda items for the sync-up?
--
Alex Bennée
Virtualisation Tech Lead @ Linaro
paths
> are on different drives. I made sure to convert the Windows paths to
> Unix paths to prevent warnings in generated files.
>
> Signed-off-by: oltolm
for plugins:
Acked-by: Alex Bennée
--
Alex Bennée
Virtualisation Tech Lead @ Linaro
bitfields
----
Alex Bennée (8):
tests/docker: expose $HOME/.cache/qemu as docker volume
gitlab: disable debug info on CI builds
tests/tcg: make aarch64 boot.S handle different starting modes
contrib/plugins: add a scaling factor
Stefan Hajnoczi writes:
> On Thu, Jun 5, 2025 at 12:28 PM Alex Bennée wrote:
>>
>> The following changes since commit 09be8a511a2e278b45729d7b065d30c68dd699d0:
>>
>> Merge tag 'pull-qapi-2025-06-03' of https://repo.or.cz/qemu/armbru into
>> st
Akihiko Odaki writes:
> On 2025/06/06 18:54, Alex Bennée wrote:
>> Akihiko Odaki writes:
>>
>>> On 2025/06/06 1:26, Alex Bennée wrote:
>>>> QOM objects can be embedded in other QOM objects and managed as part
>>>&g
Akihiko Odaki writes:
> On 2025/06/05 20:57, Alex Bennée wrote:
>> Akihiko Odaki writes:
>>
>>> On 2025/06/03 20:01, Alex Bennée wrote:
>>>> QOM objects can be embedded in other QOM objects and managed as part
>>>&g
Philippe Mathieu-Daudé writes:
> ping?
Queued to semihosting/next, thanks.
--
Alex Bennée
Virtualisation Tech Lead @ Linaro
Akihiko Odaki writes:
> On 2025/06/06 1:26, Alex Bennée wrote:
>> QOM objects can be embedded in other QOM objects and managed as part
>> of their lifetime but this isn't the case for
>> virtio_gpu_virgl_hostmem_region. However before we can split it out we
>> ne
77b5dc961da4364af26e771bd39f379cbbf7')
>
> -@skipFlakyTest("https://gitlab.com/qemu-project/qemu/-/issues/2921";)
> def test_aarch64_virt(self):
> self.set_machine('virt')
> self.cpu = 'cortex-a53'
--
Alex Bennée
Virtualisation Tech Lead @ Linaro
| 4
> backends/tpm/tpm_emulator.c | 4 ++--
> hw/gpio/pca9552.c | 2 +-
> tests/unit/test-char.c | 3 +--
> 4 files changed, 8 insertions(+), 5 deletions(-)
--
Alex Bennée
Virtualisation Tech Lead @ Linaro
B: expanded upstream link]
Signed-off-by: Alex Bennée
Message-ID: <20250603110204.838117-18-alex.ben...@linaro.org>
diff --git a/gdb-xml/aarch64-core.xml b/gdb-xml/aarch64-core.xml
index e1e9dc3f91..b8046510b9 100644
--- a/gdb-xml/aarch64-core.xml
+++ b/gdb-xml/aarch64-core
s/2648
Co-authored-by: Patryk 'patryk4815' Sondej
Signed-off-by: Dominik 'Disconnect3d' Czarnota
Message-Id: <20250403191340.53343-1-dominik.b.czarn...@gmail.com>
[AJB: fix include, checkpatch linewrap]
Signed-off-by: Alex Bennée
Message-ID: <20250603110204.838117-1
assets in size_memop
- fix include guard in gdbstub
- introduce qGDBServerVersion gdbstub query
- update gdb aarch64-core.xml to support bitfields
----
Alex Bennée (11):
tests/docker: expose $HOME/.cache/qemu as docker volume
Seeing as I've taken a few patches to here now I might as well put
myself forward to maintain virtio-gpu. I've marked it as Odd Fixes as
it is not my core focus. If someone with more GPU experience comes
forward we can always update again.
Reviewed-by: Markus Armbruster
Signed-of
It's easy to get lost in zeros while setting the numbers of
instructions per second. Add a scaling suffix to make things simpler.
Reviewed-by: Pierrick Bouvier
Signed-off-by: Alex Bennée
Message-ID: <20250603110204.838117-6-alex.ben...@linaro.org>
diff --git a/contrib/plugins/ips.
Thanks for volunteering to help.
Cc: Akihiko Odaki
Cc: Dmitry Osipenko
Reviewed-by: Markus Armbruster
Reviewed-by: Philippe Mathieu-Daudé
Acked-by: Michael S. Tsirkin
Signed-off-by: Alex Bennée
Message-ID: <20250603110204.838117-9-alex.ben...@linaro.org>
diff --git a/MAINTAI
: Jim MacArthur
Signed-off-by: Alex Bennée
Message-ID: <20250603110204.838117-4-alex.ben...@linaro.org>
diff --git a/tests/tcg/aarch64/Makefile.softmmu-target
b/tests/tcg/aarch64/Makefile.softmmu-target
index 9c52475b7a..f7a7d2b800 100644
--- a/tests/tcg/aarch64/Makefile.softmmu-target
commit message]
Tested-by: Dmitry Osipenko
Signed-off-by: Alex Bennée
Message-ID: <20250603110204.838117-13-alex.ben...@linaro.org>
diff --git a/hw/display/virtio-gpu-virgl.c b/hw/display/virtio-gpu-virgl.c
index b4aa8abb96..cea2e12eb9 100644
--- a/hw/display/virtio-gpu-virgl.c
+++ b/hw/disp
Reviewed-by: Pierrick Bouvier
Reviewed-by: Philippe Mathieu-Daudé
Signed-off-by: Alex Bennée
Message-ID: <20250603110204.838117-15-alex.ben...@linaro.org>
diff --git a/include/gdbstub/commands.h b/include/gdbstub/commands.h
index 40f0514fe9..bff3674872 100644
--- a/include/gdbstub/comm
If you want to run functional tests we should share .cache/qemu so we
don't force containers to continually re-download images. We also move
ccache to use this shared area.
Reviewed-by: Thomas Huth
Signed-off-by: Alex Bennée
Message-ID: <20250603110204.838117-2-alex.ben...@linaro.or
pe Mathieu-Daudé
Signed-off-by: Alex Bennée
Message-ID: <20250603110204.838117-5-alex.ben...@linaro.org>
diff --git a/tests/qtest/libqos/igb.c b/tests/qtest/libqos/igb.c
index f40c4ec4cd..ab3ef6f0c3 100644
--- a/tests/qtest/libqos/igb.c
+++ b/tests/qtest/libqos/igb.c
@@ -104,10
like --enable-debug-tcg.
Reviewed-by: Thomas Huth
Signed-off-by: Alex Bennée
Message-ID: <20250603110204.838117-3-alex.ben...@linaro.org>
diff --git a/.gitlab-ci.d/buildtest-template.yml
b/.gitlab-ci.d/buildtest-template.yml
index 118371e377..19663126ca 100644
--- a/.gitlab-ci.d/bui
The default is we update time every 1/10th of a second or so. However
for some cases we might want to update time more frequently. Allow
this to be set via the command line through the ipq argument.
Reviewed-by: Pierrick Bouvier
Signed-off-by: Alex Bennée
Message-ID: <20250603110204.83811
When things go wrong we want to assert on the register that failed to
be able to figure out what went wrong.
Reviewed-by: Pierrick Bouvier
Reviewed-by: Philippe Mathieu-Daudé
Signed-off-by: Alex Bennée
Message-ID: <20250603110204.838117-16-alex.ben...@linaro.org>
diff --git a/g
We can handle larger sized memops now, expand the range of the assert.
Fixes: 4b473e0c60 (tcg: Expand MO_SIZE to 3 bits)
Reviewed-by: Richard Henderson
Signed-off-by: Alex Bennée
Message-ID: <20250603110204.838117-14-alex.ben...@linaro.org>
diff --git a/include/exec/memop.h b/includ
Reviewed-by: Philippe Mathieu-Daudé
Message-Id: <20250410122643.1747913-4-manos.pitsidiana...@linaro.org>
Cc: qemu-sta...@nongnu.org
Signed-off-by: Alex Bennée
Message-ID: <20250603110204.838117-11-alex.ben...@linaro.org>
diff --git a/hw/display/virtio-gpu-virgl.c b/hw/display/virtio
guest.
Fixes: 77bf310084 ("ui/gtk: Draw guest frame at refresh cycle")
Reported-by: Dmitry Osipenko
Reported-by: Alex Bennée
Tested-by: Alex Bennée
Tested-by: Dmitry Osipenko
Reviewed-by: Alex Bennée
Reviewed-by: Dmitry Osipenko
Cc: Marc-André Lureau
Cc: Vivek Kasireddy
Signed-off-b
Manos Pitsidianakis
Reviewed-by: Philippe Mathieu-Daudé
Message-Id: <20250410122643.1747913-2-manos.pitsidiana...@linaro.org>
Cc: qemu-sta...@nongnu.org
Signed-off-by: Alex Bennée
Message-ID: <20250603110204.838117-10-alex.ben...@linaro.org>
diff --git a/include/system/memory.h b/include/syst
Markus Armbruster writes:
> Markus Armbruster writes:
>
>> Alex Bennée writes:
>
> [...]
>
>>> We don't mention the Link: or Message-Id: tags.
>>
>> Yes, but should it go into code-provenance.rst or
>> submitting-a-patch.rst?
>>
>&
https://gitlab.freedesktop.org/spice/spice/-/merge_requests/229
>
> ---
> Cc: Gerd Hoffmann
> Cc: Marc-André Lureau
> Cc: Dmitry Osipenko
> Cc: Frediano Ziglio
> Cc: Michael Scherle
> Cc: Dongwon Kim
> Cc: Alex Bennée
>
> Vivek Kasireddy (7):
> ui/egl-hel
safe, then relax.
>
> Meanwhile requests for exceptions can also be considered on a case by
> case basis.
>
> Signed-off-by: Daniel P. Berrangé
> Acked-by: Stefan Hajnoczi
> Reviewed-by: Kevin Wolf
> Signed-off-by: Markus Armbruster
Reviewed-by: Alex Bennée
--
Alex Bennée
Virtualisation Tech Lead @ Linaro
rrangé
> Reviewed-by: Peter Maydell
> Signed-off-by: Markus Armbruster
Reviewed-by: Alex Bennée
--
Alex Bennée
Virtualisation Tech Lead @ Linaro
Akihiko Odaki writes:
> On 2025/06/03 20:01, Alex Bennée wrote:
>> QOM objects can be embedded in other QOM objects and managed as part
>> of their lifetime but this isn't the case for
>> virtio_gpu_virgl_hostmem_region. However before we can split it out we
>> ne
Akihiko Odaki writes:
> On 2025/06/03 20:01, Alex Bennée wrote:
>> Currently the boot.S code assumes everything starts at EL1. This will
>> break things like the memory test which will barf on unaligned memory
>> access when run at a higher level.
>> Adapt the
ame spelling. It's okay if you subscribe or contribute to
> -the list via more than one address, but using multiple addresses in one
> -commit just confuses things. If someone else wrote the patch, git will
> -include a "From:" line in the body of the email (different from your
> -envelope From:) that will give credit to the correct author; but again,
> -that author's Signed-off-by: line is mandatory, with the same spelling.
> +this and happy for it to go into QEMU". For full guidance, read the
> +:ref:`code-provenance` documentation.
>
> The name used with "Signed-off-by" does not need to be your legal name,
> nor birth name, nor appear on any government ID. It is the identity you
> choose to be known by in the community, but should not be anonymous,
> nor misrepresent whom you are.
>
> -There are various tooling options for automatically adding these tags
> -include using ``git commit -s`` or ``git format-patch -s``. For more
> -information see `SubmittingPatches 1.12
> -<http://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/tree/Documentation/SubmittingPatches?id=f6f94e2ab1b33f0082ac22d71f66385a60d8157f#n297>`__.
>
> .. _include_a_meaningful_cover_letter:
--
Alex Bennée
Virtualisation Tech Lead @ Linaro
We can handle larger sized memops now, expand the range of the assert.
Fixes: 4b473e0c60 (tcg: Expand MO_SIZE to 3 bits)
Signed-off-by: Alex Bennée
Reviewed-by: Richard Henderson
---
v2
- instead of 128 use 1 << MO_SIZE for future proofing
v3
- fix comment, 1 << MO_SIZE goe
guest.
Fixes: 77bf310084 ("ui/gtk: Draw guest frame at refresh cycle")
Reported-by: Dmitry Osipenko
Reported-by: Alex Bennée
Tested-by: Alex Bennée
Tested-by: Dmitry Osipenko
Reviewed-by: Alex Bennée
Reviewed-by: Dmitry Osipenko
Cc: Marc-André Lureau
Cc: Vivek Kasireddy
Signed-off-b
s properly against
uint32_t and uint16_t.
Signed-off-by: Nabih Estefan
Reviewed-by: Laurent Vivier
Tested-by: Laurent Vivier
Reviewed-by: Richard Henderson
Message-Id: <20250429155621.2028198-1-nabiheste...@google.com>
[AJB: fix commit message, remove unneeded casts]
Signed-off-by: Alex Ben
s/2648
Co-authored-by: Patryk 'patryk4815' Sondej
Signed-off-by: Dominik 'Disconnect3d' Czarnota
Message-Id: <20250403191340.53343-1-dominik.b.czarn...@gmail.com>
[AJB: fix include, checkpatch linewrap]
Signed-off-by: Alex Bennée
---
gdbstub/gdbstub.c | 17
: Jim MacArthur
Signed-off-by: Alex Bennée
---
v4
- drop post eret nops
- proper error string for EL0 error case
- clamp any invalid target EL value to 1
v3
- create system stack so we _exit cleanly
- normalise EL string before compares
- catch when we start in a lower EL than we asked
d this via guest and host side perfetto tracing.
Cc:
Fixes: 94d0ea1c1928 ("virtio-gpu: Support Venus context")
Signed-off-by: Yiwei Zhang
Reviewed-by: Dmitry Osipenko
Message-Id: <20250518152651.334115-1-zzyi...@gmail.com>
[AJB: remove version history from commit message]
like --enable-debug-tcg.
Signed-off-by: Alex Bennée
Reviewed-by: Thomas Huth
---
.gitlab-ci.d/buildtest-template.yml | 1 +
1 file changed, 1 insertion(+)
diff --git a/.gitlab-ci.d/buildtest-template.yml
b/.gitlab-ci.d/buildtest-template.yml
index 118371e377..19663126ca 100644
--- a/.gitlab
The default is we update time every 1/10th of a second or so. However
for some cases we might want to update time more frequently. Allow
this to be set via the command line through the ipq argument.
Signed-off-by: Alex Bennée
Reviewed-by: Pierrick Bouvier
---
v4
- simplify error checking
From: Manos Pitsidianakis
Change the 3 part async cleanup of a blob memory mapping to check if the
unmapping has finished already after deleting the subregion; this
condition allows us to skip suspending the command and responding to the
guest right away.
Signed-off-by: Manos Pitsidianakis
Revi
Manos Pitsidianakis
Reviewed-by: Philippe Mathieu-Daudé
Signed-off-by: Alex Bennée
Message-Id: <20250410122643.1747913-2-manos.pitsidiana...@linaro.org>
Cc: qemu-sta...@nongnu.org
---
include/system/memory.h | 1 +
hw/display/virtio-gpu-virgl.c | 23 ---
2 files changed, 9
If you want to run functional tests we should share .cache/qemu so we
don't force containers to continually re-download images. We also move
ccache to use this shared area.
Signed-off-by: Alex Bennée
Reviewed-by: Thomas Huth
---
v3
- mention ccache
v2
- Share a whole .cache/qemu
When things go wrong we want to assert on the register that failed to
be able to figure out what went wrong.
Reviewed-by: Pierrick Bouvier
Reviewed-by: Philippe Mathieu-Daudé
Signed-off-by: Alex Bennée
---
gdbstub/gdbstub.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a
B: expanded upstream link]
Signed-off-by: Alex Bennée
---
gdb-xml/aarch64-core.xml | 52 ++--
1 file changed, 50 insertions(+), 2 deletions(-)
diff --git a/gdb-xml/aarch64-core.xml b/gdb-xml/aarch64-core.xml
index e1e9dc3f91..b8046510b9 100644
--- a/gdb-xml/aarch
hiko/Dmitry as virtio-gpu reviewers
The following still need review:
tests/tcg: make aarch64 boot.S handle different starting modes
Alex.
Alex Bennée (11):
tests/docker: expose $HOME/.cache/qemu as docker volume
gitlab: disable debug info on CI builds
tests/tcg: make aarch64 boot.S handle
Reviewed-by: Pierrick Bouvier
Reviewed-by: Philippe Mathieu-Daudé
Signed-off-by: Alex Bennée
---
include/gdbstub/commands.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/include/gdbstub/commands.h b/include/gdbstub/commands.h
index 40f0514fe9..bff3674872 100644
--- a
Thanks for volunteering to help.
Cc: Akihiko Odaki
Cc: Dmitry Osipenko
Reviewed-by: Markus Armbruster
Reviewed-by: Philippe Mathieu-Daudé
Signed-off-by: Alex Bennée
Acked-by: Michael S. Tsirkin
---
MAINTAINERS | 2 ++
1 file changed, 2 insertions(+)
diff --git a/MAINTAINERS b/MAINTAINERS
Seeing as I've taken a few patches to here now I might as well put
myself forward to maintain virtio-gpu. I've marked it as Odd Fixes as
it is not my core focus. If someone with more GPU experience comes
forward we can always update again.
Reviewed-by: Markus Armbruster
Signed-of
It's easy to get lost in zeros while setting the numbers of
instructions per second. Add a scaling suffix to make things simpler.
Signed-off-by: Alex Bennée
Reviewed-by: Pierrick Bouvier
---
v2
- normalise the suffix before a full strcmp0
- check endptr actually set
- fix check
>
>
> Hence the current implementation is a little clumsy!
>
> Thanks for your advice.
>
> Jon
>
> On Mon, Jun 2, 2025 at 4:09 PM Alex Bennée wrote:
>
> Jon Wilson writes:
>
> (Adding Richard, the
re I
> think the issue is caused by the surrounding TCG in the block it is injected
> into?
>
> ////
> runner-x86_64: ../tcg/tcg.c:4852: tcg_reg_alloc_mov: Assertion `ts->val_type
> == TEMP_VAL_REG' failed.
> Aborted (core dumped)
>
>
> I would be very grateful for any advice of how to resolve this issue, or any
> alternative approaches I could use to optimize my original implementation. The
> code is obviously a very hot path and so even a tiny performance improvement
> could result in a large performance gain overall.
--
Alex Bennée
Virtualisation Tech Lead @ Linaro
ield was
defined, so at least before 1995. Also, neither the kernel or QEMU
is_vga helpers account for this, so they'd not have a VGA region or be
properly detected elsewhere. Thanks,
Alex
> +
> if (!(reg_info->flags & VFIO_REGION_INFO_FLAG_READ) ||
errp)) {
> +if (!vfio_pci_igd_opregion_detect(vdev, &opregion)) {
> return true;
> }
> info_report("OpRegion detected on Intel display %x.", vdev->device_id);
> @@ -695,7 +693,7 @@ static bool vfio_pci_kvmgt_config_quirk(VFIOPCIDevice
> *vdev, E
to a non-VGA device that doesn't make
any sense. vfio_populate_vga() needs to care about the exposed class
code now too. Thanks,
Alex
> Signed-off-by: Tomita Moeko
> ---
> hw/vfio/pci.c| 17 +
> hw/vfio/pci.h| 1 +
> hw/vfio/trace-events | 1 +
>
Akihiko Odaki writes:
> On 2025/05/22 18:28, Alex Bennée wrote:
>> Akihiko Odaki writes:
>>
>>> On 2025/05/22 16:31, Manos Pitsidianakis wrote:
>>>> On Thu, May 22, 2025 at 10:03 AM Akihiko Odaki
>>>> wrote:
>>>>>
>>>
Philippe Mathieu-Daudé writes:
> On 21/5/25 17:42, Alex Bennée wrote:
>> From: Dominik 'Disconnect3d' Czarnota
>> This commit adds support for the `qGDBServerVersion` packet to the
>> qemu
>> gdbstub which could be used by clients to detect the QEMU versio
Hi,
I forgot to send this yesterday due to local bank holidays, anyway the
KVM/QEMU community call is at:
https://meet.jit.si/kvmcallmeeting
@
27/05/2025 14:00 UTC
Are there any agenda items for the sync-up?
--
Alex Bennée
Virtualisation Tech Lead @ Linaro
TRD = Asset(
> +('https://ftp.debian.org/debian/dists/stable/main/installer-arm64/'
> + 'current/images/netboot/debian-installer/arm64/initrd.gz'),
> +
> '2583ec22b45265ad69e82f198674f53d4cd85be124fe012eedc2fd91156bc4b4')
Hmm do we need
Thomas Huth writes:
> From: Thomas Huth
>
> The problem with the PCI bridge has been fixed in commit e5894fd6f411c1
> ("hw/pci-host/gt64120: Fix endianness handling"), so we can enable the
> corresponding test again.
>
> Signed-off-by: Thomas Huth
Reviewed-by
.
I would expect us to:
a) handle the QEMU_PLUGIN_CB_RW_REGS
b) try and enforce we are only being called from such callbacks
Otherwise TCG won't know to restore register state from what has been
written to.
--
Alex Bennée
Virtualisation Tech Lead @ Linaro
1 - 100 of 6330 matches
Mail list logo
