Hi,
The KVM/QEMU community call is at:
https://meet.jit.si/kvmcallmeeting
@
04/02/2025 14:00 UTC
Are there any agenda items for the sync-up?
--
Alex Bennée
Virtualisation Tech Lead @ Linaro
Gautam Bhat writes:
> On Thu, Jan 2, 2025 at 3:45 PM Alex Bennée wrote:
>
>> The call into the prologue comes from:
>>
>> ret = tcg_qemu_tb_exec(cpu_env(cpu), tb_ptr);
>>
>> in cpu_tb_exec. With env in RDI and tb_ptr (the code address) being i
n unnoticed.
>
> 1) 30933c4fb4f3d ("tcg/cputlb: remove other-cpu capability from TLB flushing")
> Signed-off-by: Igor Mammedov
> Suggested-by: Alex Bennée
> ---
> accel/tcg/cputlb.c | 11 ---
> 1 file changed, 4 insertions(+), 7 deletions(-)
>
> diff
On Fri, 31 Jan 2025 02:33:03 +0800
Tomita Moeko wrote:
> On 1/25/25 15:42, Tomita Moeko wrote:
> > On 1/25/25 05:13, Alex Williamson wrote:
> >> On Sat, 25 Jan 2025 03:12:45 +0800
> >> Tomita Moeko wrote:
> >>
> >>> Both enable opregion
ication
to the user how they can resolve the issue, such as implemented here, is
better than none, but maybe we can elaborate in a comment that this is
really more of a workaround for the current behavior of firmware
relative to the 64-bit MMIO placement policy. Thanks,
Alex
> +error_setg
\
})
So long as we only want once per call site and not once per object,
which would pull in something like warn_report_once_cond(). Thanks,
Alex
> /*
> * Convenience function to error_report() and free @err.
> * The report includes h
ses, l1_dmisses,
> | ^~~~
>
> Is a false-positive, since cores > 1, so the variable is set in the
> above loop.
>
> Signed-off-by: Marc-André Lureau
Queued to plugins/next, thanks.
--
Alex Bennée
Virtualisation Tech Lead @ Linaro
elf
-Wmissing-format-attribute -Wmissing-prototypes -Wnested-externs
-Wold-style-declaration -Wold-style-definition -Wredundant-decls -Wshadow=local
-Wstrict-prototypes -Wtype-limits -Wundef -Wvla -Wwrite-strings
-Wno-missing-include-dirs -Wno-psabi -Wno-shift-negative-value -isystem
/home/ale
urn NULL;
> +}
> +
I don't have any fundamental objection to this. I would prefer it if the
new helper was used by either one of the test or contrib plugins to
ensure we don't bitrot it.
> /*
> * Instruction information
> *
--
Alex Bennée
Virtualisation Tech Lead @ Linaro
G_TYPE_I64 would remove a *lot* of
>> 32-bit fallback code.
I support going the whole hog. I would be curious what use cases still
exist for an up to date 32-on-32 QEMU based emulation?
>
> Sound like a good alternative to me!
>
> Thomas
--
Alex Bennée
Virtualisation Tech Lead @ Linaro
BEGIN:VCALENDAR
PRODID:-//Google Inc//Google Calendar 70.9054//EN
VERSION:2.0
CALSCALE:GREGORIAN
METHOD:REQUEST
BEGIN:VTIMEZONE
TZID:America/New_York
X-LIC-LOCATION:America/New_York
BEGIN:DAYLIGHT
TZOFFSETFROM:-0500
TZOFFSETTO:-0400
TZNAME:EDT
DTSTART:19700308T02
RRULE:FREQ=YEARLY;BYMONTH=3;BYD
BEGIN:VCALENDAR
PRODID:-//Google Inc//Google Calendar 70.9054//EN
VERSION:2.0
CALSCALE:GREGORIAN
METHOD:REQUEST
BEGIN:VTIMEZONE
TZID:America/New_York
X-LIC-LOCATION:America/New_York
BEGIN:DAYLIGHT
TZOFFSETFROM:-0500
TZOFFSETTO:-0400
TZNAME:EDT
DTSTART:19700308T02
RRULE:FREQ=YEARLY;BYMONTH=3;BYD
encing mode isn't supported for DRM
> contexts in virglrenderer.
>
> Reviewed-by: Akihiko Odaki
> Acked-by: Michael S. Tsirkin
> Tested-by: Alex Bennée
> Signed-off-by: Dmitry Osipenko
Reviewed-by: Alex Bennée
--
Alex Bennée
Virtualisation Tech Lead @ Linaro
opened
> - Asahi (Apple SoC GPUs), partially merged upstream
>
--
Alex Bennée
Virtualisation Tech Lead @ Linaro
Dmitry Osipenko writes:
> On 1/23/25 14:58, Alex Bennée wrote:
>> Dmitry Osipenko writes:
>>
>>> On 1/22/25 20:00, Alex Bennée wrote:
>>>> Dmitry Osipenko writes:
>>>>
>>>>> This patchset adds DRM native context support to VirtIO
Akihiko Odaki writes:
> On 2025/01/27 5:11, Dmitry Osipenko wrote:
>> From: Alex Bennée
>> This attempts to tidy up the VirtIO GPU documentation to make the
>> list
>> of requirements clearer. There are still a lot of moving parts and the
>> distros have some
Pierrick Bouvier writes:
> Hi Thomas,
>
> On 1/24/25 05:29, Thomas Huth wrote:
>> On 10/01/2025 14.17, Alex Bennée wrote:
>>> From: Pierrick Bouvier
>>>
>>> This boot an OP-TEE environment, and launch a nested guest VM inside it
>>> using
scenario.
> - */
> -if (vdev->pdev.qdev.hotplugged) {
> -error_report("IGD device %s hotplugged, ROM disabled, "
> - "legacy mode disabled", vdev->vbasedev.name);
> -vdev->rom_read_failed = true;
> -
if (r != tests[i].expected_r) {
> +printf("expected result 0x%" PRIx64 "\n", tests[i].expected_r);
> +passed = false;
> +}
> +if (mxcsr != tests[i].expected_mxcsr) {
> +printf("expected MXCSR flags 0x%x\n", tests[i].expected_mxcsr);
> +passed = false;
> +}
> +}
> +return passed ? 0 : 1;
> +}
> diff --git a/tests/tcg/x86_64/Makefile.target
> b/tests/tcg/x86_64/Makefile.target
> index d6dff559c7d..be20fc64e88 100644
> --- a/tests/tcg/x86_64/Makefile.target
> +++ b/tests/tcg/x86_64/Makefile.target
> @@ -18,6 +18,7 @@ X86_64_TESTS += adox
> X86_64_TESTS += test-1648
> X86_64_TESTS += test-2175
> X86_64_TESTS += cross-modifying-code
> +X86_64_TESTS += fma
> TESTS=$(MULTIARCH_TESTS) $(X86_64_TESTS) test-x86_64
> else
> TESTS=$(MULTIARCH_TESTS)
--
Alex Bennée
Virtualisation Tech Lead @ Linaro
cessary
(seems I wouldn't have invented such a need), removing it is really the
only way to fully validate that, and we can always revisit if we start
getting regression reports. Thanks,
Alex
> Signed-off-by: Tomita Moeko
> ---
> hw/vfio/igd.c| 30
Igor Mammedov writes:
> On Thu, 23 Jan 2025 12:23:43 +0100
> Igor Mammedov wrote:
>
>> On Thu, 23 Jan 2025 10:52:15 +
>> Alex Bennée wrote:
>>
>> > Igor Mammedov writes:
>> >
>> > > QEMU will crash with following debug ena
;Type "help()" for more information.')
> +exec_command_and_wait_for_pattern(self, 'import machine as mch',
> '>>>')
> +exec_command_and_wait_for_pattern(self, 'mch.reset()', 'MicroPython')
> +wait_for_console_pattern(self, '>>>')
We could do more if we wanted - all the microbit specific stuff lives in
the microbit module:
https://microbit-micropython.readthedocs.io/en/latest/microbit_micropython_api.html
Anyway:
Reviewed-by: Alex Bennée
> +
> +if __name__ == '__main__':
> +QemuSystemTest.main()
--
Alex Bennée
Virtualisation Tech Lead @ Linaro
Philippe Mathieu-Daudé writes:
> Use the tcg_enabled() check so the compiler can elide
> the call when TCG isn't available, allowing to remove
> the tb_flush() stub.
>
> Signed-off-by: Philippe Mathieu-Daudé
Reviewed-by: Alex Bennée
--
Alex Bennée
Virtualisation Tech Lead @ Linaro
Igor Mammedov writes:
> On Thu, 23 Jan 2025 10:52:15 +
> Alex Bennée wrote:
>
>> Igor Mammedov writes:
>>
>> > QEMU will crash with following debug enabled
>> > # define DEBUG_TLB_GATE 1
>> > # define DEBUG_TLB_LOG_GA
Dmitry Osipenko writes:
> On 1/22/25 20:00, Alex Bennée wrote:
>> Dmitry Osipenko writes:
>>
>>> This patchset adds DRM native context support to VirtIO-GPU on Qemu.
>>>
>>> Contarary to Virgl and Venus contexts that mediates high level GFX APIs,
>&
+417,6 @@ void tlb_flush_by_mmuidx(CPUState *cpu, uint16_t idxmap)
> {
> tlb_debug("mmu_idx: 0x%" PRIx16 "\n", idxmap);
>
> -assert_cpu_is_self(cpu);
> -
> tlb_flush_by_mmuidx_async_work(cpu, RUN_ON_CPU_HOST_INT(idxmap));
> }
--
Alex Bennée
Virtualisation Tech Lead @ Linaro
Philippe Mathieu-Daudé writes:
> CpuState caches its CPUClass since commit 6fbdff87062
> ("cpu: cache CPUClass in CPUState for hot code paths"),
> use it.
>
> Signed-off-by: Philippe Mathieu-Daudé
> Reviewed-by: Richard Henderson
Acked-by: Alex Bennée
--
Ale
le code on
> the microblaze and tricore implementations.
>
> Signed-off-by: Philippe Mathieu-Daudé
Reviewed-by: Alex Bennée
--
Alex Bennée
Virtualisation Tech Lead @ Linaro
re32_v, int32_t, 2, true)
> +GEN_LDST_WHOLE_TRANS(vl2re64_v, int64_t, 2, true)
> +GEN_LDST_WHOLE_TRANS(vl4re8_v, int8_t, 4, true)
> +GEN_LDST_WHOLE_TRANS(vl4re16_v, int16_t, 4, true)
> +GEN_LDST_WHOLE_TRANS(vl4re32_v, int32_t, 4, true)
> +GEN_LDST_WHOLE_TRANS(vl4re64_v, int64_t, 4,
suffix=".log")
> @@ -91,7 +91,7 @@ def test_aarch64_virt_insn_icount(self):
> kernel_path = self.ASSET_KERNEL.fetch()
> kernel_command_line = (self.KERNEL_COMMON_COMMAND_LINE +
> 'console=ttyAMA0')
> -console_pattern = 'Kernel panic - not syncing: VFS:'
> +console_pattern = 'Please append a correct "root=" boot option'
>
> plugin_log = tempfile.NamedTemporaryFile(mode="r+t", prefix="plugin",
> suffix=".log")
--
Alex Bennée
Virtualisation Tech Lead @ Linaro
ype 'help' for more information
(qemu) quit
Which looks very much like the PFN locking failure. However booting up
with venus=on instead works. Could there be any differences in the way
device memory is mapped in the two cases?
> - Intel (i915), merge requests are opened
&g
v=char0,mode=readline \
-chardev hub,id=hub0,chardevs.0=char0,chardevs.1=clog
Giving:
qemu-system-aarch64: -chardev -hub,id=hub0,chardevs.0=char0,chardevs.1=clog:
hub: -multiplexers and hub devices can't be stacked, check chardev
-'char0', chardev should not be a hub device or have 'mux=on'
-enabled
So what stops this sort of chain?
--
Alex Bennée
Virtualisation Tech Lead @ Linaro
Peter Maydell writes:
> On Wed, 18 Dec 2024 at 18:15, Alex Bennée wrote:
>>
>> Signed-off-by: Alex Bennée
>> Cc: qemu-sta...@nongnu.org
>> ---
>> hw/arm/virt.c | 2 ++
>> 1 file changed, 2 insertions(+)
>>
>> diff --git a/hw/arm/virt.c b/h
Roman Penyaev writes:
> On Tue, Jan 21, 2025 at 4:02 PM Alex Bennée wrote:
>>
>> Roman Penyaev writes:
>>
>> > This adds a few lines describing `hub` aggregator configuration
>> > for aggregation of several backend devices with a single frontend
>
j)
> pty_chr_state(chr, 0);
> object_unref(OBJECT(s->ioc));
> pty_chr_timer_cancel(s);
> -qemu_chr_be_event(chr, CHR_EVENT_CLOSED);
> }
It would be nice to clean up connected/s->connected to bools at some
point. However this is fine:
Reviewed-by: Alex Bennée
--
Alex Bennée
Virtualisation Tech Lead @ Linaro
+::
> +
> + # Start TTY emulator
> + tio /tmp/pty
> +
> + # Start VNC client and switch to virtual console Ctrl-Alt-2
> + vncviewer :0
> +
> +Several frontend devices is not supported. Stacking of multiplexers
> +and hub devices is not supp
Philippe Mathieu-Daudé writes:
> CpuState caches its CPUClass since commit 6fbdff87062
> ("cpu: cache CPUClass in CPUState for hot code paths"),
> use it.
>
> Signed-off-by: Philippe Mathieu-Daudé
Reviewed-by: Alex Bennée
--
Alex Bennée
Virtualisation Tech Lead @ Linaro
Philippe Mathieu-Daudé writes:
> CpuState caches its CPUClass since commit 6fbdff87062
> ("cpu: cache CPUClass in CPUState for hot code paths"),
> use it.
>
> Signed-off-by: Philippe Mathieu-Daudé
Acked-by: Alex Bennée
--
Alex Bennée
Virtualisation Tech Lead @ Linaro
.
Of course.
>
> On Mon, Jan 20, 2025 at 11:00 PM Alex Bennée wrote:
>
> Until there are timers enabled the semantics of clock_step_next() will
> fail. Since d524441a36 (system/qtest: properly feedback results of
> clock_[step|set]) we will signal a FAIL if time doesn
).
Signed-off-by: Alex Bennée
---
include/system/qtest.h | 1 -
hw/ppc/spapr_rtas.c| 1 -
hw/riscv/riscv_hart.c | 1 -
system/qtest.c | 26 +++---
4 files changed, 3 insertions(+), 26 deletions(-)
diff --git a/include/system/qtest.h b/include/system/qtest.h
index
Until there are timers enabled the semantics of clock_step_next() will
fail. Since d524441a36 (system/qtest: properly feedback results of
clock_[step|set]) we will signal a FAIL if time doesn't advance.
Signed-off-by: Alex Bennée
---
tests/qtest/npcm7xx_timer-test.c | 1 -
1 file chang
desirable for tests which are checking
that nothing changes when things are disabled.
Previously most tests got away with it because --enable-slirp always
has a timer running while the test is active.
Signed-off-by: Alex Bennée
Cc: Peter Maydell
---
util/qemu-timer.c | 16 +++-
1 file
It is invalid to call clock_step with an implied time to step forward
as if no timers are running we won't be able to advance.
Signed-off-by: Alex Bennée
---
system/qtest.c | 7 ++-
1 file changed, 6 insertions(+), 1 deletion(-)
diff --git a/system/qtest.c b/system/qtest.c
index 28b6f
This replicates the changes from 92cb8f8bf6 (tests/qtest: remove
clock_steps from virtio tests) as there are no timers in the virtio
code. We still busy wait and timeout though.
Signed-off-by: Alex Bennée
---
tests/qtest/libqos/virtio-pci-modern.c | 6 ++
tests/qtest/libqos/virtio-pci.c
This allows people to run the test locally:
make docker-test-rust@fedora-rust-nightly
Signed-off-by: Alex Bennée
---
tests/docker/Makefile.include | 3 +++
tests/docker/test-rust| 21 +
2 files changed, 24 insertions(+)
create mode 100755 tests/docker/test-rust
Don't both creating a GString to temporarily hold our qtest command.
Instead do a simpler g_strndup and use autofree to clean up
afterwards.
Signed-off-by: Alex Bennée
---
system/qtest.c | 20
1 file changed, 8 insertions(+), 12 deletions(-)
diff --git a/system/qtes
s/qtest: rename qtest_send_prefix and roll-up into qtest_send
tests/qtest: simplify qtest_process_inbuf
tests/qtest: don't step clock at start of npcm7xx periodic IRQ test
tests/qtest: don't attempt to clock_step while waiting for virtio ISR
tests/docker: replicate the check-rust-tools-ni
Hi,
The KVM/QEMU community call is at:
https://meet.jit.si/kvmcallmeeting
@
21/01/2025 14:00 UTC
Are there any agenda items for the sync-up?
--
Alex Bennée
Virtualisation Tech Lead @ Linaro
Richard Henderson writes:
> These are not particularly useful outside of optimization passes.
>
> Signed-off-by: Richard Henderson
Reviewed-by: Alex Bennée
--
Alex Bennée
Virtualisation Tech Lead @ Linaro
Richard Henderson writes:
> These defines are not required outside of tcg/tcg.c,
> which includes tcg-target.c.inc before use.
> Reduces the exported symbol set of tcg-target.h.
>
> Reviewed-by: Philippe Mathieu-Daudé
> Signed-off-by: Richard Henderson
Reviewed-by: Alex
Ds.
>
> If this series is accepted, I will rebase the all-stop series on top
> of it.
Queued to gdbstub/next, thanks.
--
Alex Bennée
Virtualisation Tech Lead @ Linaro
ig() on the
> first CPU and wakes it up with host_interrupt_signal. Note that the
> result of this gdb_handlesig() invocation is handled, as opposed to
> many other existing call sites. These other call sites probably need to
> be fixed separately.
>
> Signed-off-by: Ilya Leosh
oroutine-io.c'))
>util_ss.add(files(f'coroutine-@coroutine_backend@.c'))
>util_ss.add(files('thread-pool.c', 'qemu-timer.c'))
> +endif
> +if have_block or have_ga or have_user
>util_ss.add(files('qemu-sockets.c'))
> endif
> if have_block
I guess have_block is synonymous with have_system:
Reviewed-by: Alex Bennée
--
Alex Bennée
Virtualisation Tech Lead @ Linaro
gt; index 5525b3886fa..d79dc6d81f1 100644
> --- a/scripts/rust/rustc_args.py
> +++ b/scripts/rust/rustc_args.py
> @@ -215,6 +215,8 @@ def main() -> None:
>
> if rustc_version >= (1, 80):
> if args.lints:
> +print("--check-cfg")
> +
From: Pierrick Bouvier
Reviewed-by: Richard Henderson
Signed-off-by: Pierrick Bouvier
Message-Id: <20241217224306.2900490-11-pierrick.bouv...@linaro.org>
Signed-off-by: Alex Bennée
Message-Id: <20250116160306.1709518-21-alex.ben...@linaro.org>
diff --git a/contrib/plugins/
: Philippe Mathieu-Daudé
Signed-off-by: Pierrick Bouvier
Tested-by: Stefan Weil
Tested-by: Philippe Mathieu-Daudé
Message-Id: <20250110203401.178532-4-pierrick.bouv...@linaro.org>
Signed-off-by: Alex Bennée
Message-Id: <20250116160306.1709518-26-alex.ben...@linaro.org>
diff --git a/m
From: Pierrick Bouvier
Reviewed-by: Richard Henderson
Signed-off-by: Pierrick Bouvier
Message-Id: <20241209183104.365796-3-pierrick.bouv...@linaro.org>
Signed-off-by: Alex Bennée
Message-Id: <20250116160306.1709518-33-alex.ben...@linaro.org>
diff --git a/docs/devel/submitting-a-
The function is qemu_plugin_mem_get_value()
Reviewed-by: Pierrick Bouvier
Signed-off-by: Alex Bennée
Message-Id: <20250116160306.1709518-27-alex.ben...@linaro.org>
diff --git a/include/qemu/qemu-plugin.h b/include/qemu/qemu-plugin.h
index 0fba36ae02..3a850aa216 100644
--- a/include/qem
From: Pierrick Bouvier
Reviewed-by: Richard Henderson
Signed-off-by: Pierrick Bouvier
Message-Id: <20241217224306.2900490-10-pierrick.bouv...@linaro.org>
Signed-off-by: Alex Bennée
Message-Id: <20250116160306.1709518-20-alex.ben...@linaro.org>
diff --git a/contrib/plugins/h
Message-Id: <20250111215244.1680931-1...@weilnetz.de>
Signed-off-by: Alex Bennée
Message-Id: <20250116160306.1709518-38-alex.ben...@linaro.org>
diff --git a/scripts/nsis.py b/scripts/nsis.py
index 03ed7608a2..af4e064819 100644
--- a/scripts/nsis.py
+++ b/scripts/nsis.py
@@ -37,10 +
When we update the script we should rebuild the docs. Otherwise
breaking changes made to the kdoc script don't become apparent until
later.
Reviewed-by: Pierrick Bouvier
Signed-off-by: Alex Bennée
Message-Id: <20250116160306.1709518-32-alex.ben...@linaro.org>
diff --git a/
From: Pierrick Bouvier
Reviewed-by: Philippe Mathieu-Daudé
Reviewed-by: Richard Henderson
Signed-off-by: Pierrick Bouvier
Tested-by: Stefan Weil
Tested-by: Philippe Mathieu-Daudé
Message-Id: <20250110203401.178532-3-pierrick.bouv...@linaro.org>
Signed-off-by: Alex Bennée
Mess
From: Pierrick Bouvier
MacOS and Linux are straightforward, but Windows needs a bit more
details.
Reviewed-by: Richard Henderson
Signed-off-by: Pierrick Bouvier
Message-Id: <20241209183104.365796-5-pierrick.bouv...@linaro.org>
Signed-off-by: Alex Bennée
Message-Id: <20250116160306.1
A number of copy and paste kdoc comments are referring to the wrong
definition. Fix those cases.
Reviewed-by: Pierrick Bouvier
Signed-off-by: Alex Bennée
Message-Id: <20250116160306.1709518-29-alex.ben...@linaro.org>
diff --git a/tests/qtest/libqos/qgraph.h b/tests/qtest/libqos/qgraph.h
From: Pierrick Bouvier
Signed-off-by: Pierrick Bouvier
Reviewed-by: Richard Henderson
Message-Id: <20241217224306.2900490-6-pierrick.bouv...@linaro.org>
Signed-off-by: Alex Bennée
Message-Id: <20250116160306.1709518-16-alex.ben...@linaro.org>
diff --git a/contrib/plugins/sto
Since d197063fcf9 (memory: move unassigned_mem_ops to memory.c) this
field is unused.
Reviewed-by: Richard Henderson
Reviewed-by: Philippe Mathieu-Daudé
Reviewed-by: Peter Xu
Signed-off-by: Alex Bennée
Message-Id: <20250116160306.1709518-31-alex.ben...@linaro.org>
diff --git a/includ
: Julian Ganz
Reviewed-by: Richard Henderson
Signed-off-by: Alex Bennée
Message-Id: <20250116160306.1709518-23-alex.ben...@linaro.org>
diff --git a/accel/tcg/translate-all.c b/accel/tcg/translate-all.c
index 453eb20ec9..d56ca13cdd 100644
--- a/accel/tcg/translate-all.c
+++ b/accel/tcg/translate
ared identifier
'EXCP_HALTED'
88 | cs->exception_index = EXCP_HALTED;
| ^
Signed-off-by: Philippe Mathieu-Daudé
Reviewed-by: Richard Henderson
Message-Id: <20250103171037.11265-5-phi...@linaro.org>
Signed-off-by: Alex Bennée
Message-
From: Pierrick Bouvier
Signed-off-by: Pierrick Bouvier
Reviewed-by: Richard Henderson
Message-Id: <20241217224306.2900490-7-pierrick.bouv...@linaro.org>
Signed-off-by: Alex Bennée
Message-Id: <20250116160306.1709518-17-alex.ben...@linaro.org>
diff --git a/contrib/plugins/cache
From: Pierrick Bouvier
Present the various parts of QEMU and organization of codebase.
Reviewed-by: Richard Henderson
Signed-off-by: Pierrick Bouvier
Message-Id: <20241209183104.365796-6-pierrick.bouv...@linaro.org>
[AJB: tweak commit summary, update MAINTAINERS]
Signed-off-by: Alex
A number of copy and paste kdoc comments are referring to the wrong
definition. Fix those cases.
Reviewed-by: Pierrick Bouvier
Signed-off-by: Alex Bennée
Message-Id: <20250116160306.1709518-30-alex.ben...@linaro.org>
diff --git a/include/exec/memory.h b/include/exec/memory.h
index 9458
d
of checking the return value. Having a return value is still useful
for HMP though so tweak the return to use a simple bool instead.
Reviewed-by: Pierrick Bouvier
Acked-by: Ilya Leoshkevich
Signed-off-by: Alex Bennée
Message-Id: <20250116160306.1709518-11-alex.ben...@linaro.org>
di
We don't need to wrap usb_device_add as usb_parse is already gated
with an if (machine_usb(current_machine)) check. Instead just assert
and directly fail if usbdevice_create returns NULL.
Reviewed-by: Philippe Mathieu-Daudé
Signed-off-by: Alex Bennée
Message-Id: <20250116160306.17
From: Pierrick Bouvier
Reviewed-by: Richard Henderson
Signed-off-by: Pierrick Bouvier
Message-Id: <20241217224306.2900490-9-pierrick.bouv...@linaro.org>
Signed-off-by: Alex Bennée
Message-Id: <20250116160306.1709518-19-alex.ben...@linaro.org>
diff --git a/contrib/plugins/cflow
From: Pierrick Bouvier
Reviewed-by: Richard Henderson
Signed-off-by: Pierrick Bouvier
Message-Id: <20241217224306.2900490-3-pierrick.bouv...@linaro.org>
Signed-off-by: Alex Bennée
Message-Id: <20250116160306.1709518-13-alex.ben...@linaro.org>
diff --git a/contrib/plugins/howvec
rm-compat-semi.c:169:
../target/riscv/common-semi-target.h:16:5: error: use of undeclared
identifier 'RISCVCPU'
16 | RISCVCPU *cpu = RISCV_CPU(cs);
| ^
Signed-off-by: Philippe Mathieu-Daudé
Reviewed-by: Richard Henderson
Message-Id: <20250103171037.11265-4-phi..
From: Pierrick Bouvier
Reviewed-by: Richard Henderson
Signed-off-by: Pierrick Bouvier
Message-Id: <20241209183104.365796-4-pierrick.bouv...@linaro.org>
Signed-off-by: Alex Bennée
Message-Id: <20250116160306.1709518-34-alex.ben...@linaro.org>
diff --git a/docs/devel/submitting-a-
From: Pierrick Bouvier
Reviewed-by: Alex Bennée
Reviewed-by: Richard Henderson
Signed-off-by: Pierrick Bouvier
Signed-off-by: Alex Bennée
Message-Id: <20250116160306.1709518-12-alex.ben...@linaro.org>
diff --git a/tests/tcg/plugins/insn.c b/tests/tcg/plugins/insn.c
index baf2
From: Pierrick Bouvier
Reviewed-by: Richard Henderson
Signed-off-by: Pierrick Bouvier
Message-Id: <20241217224306.2900490-4-pierrick.bouv...@linaro.org>
Signed-off-by: Alex Bennée
Message-Id: <20250116160306.1709518-14-alex.ben...@linaro.org>
diff --git a/tests/tcg/plugins/sysca
We have two types of perl scripts in the tree. The ones from the
kernel are mostly tab based where as scripts we have written ourselves
use 4 space indentation.
Attempt to codify that in our .editorconfig
Reviewed-by: Pierrick Bouvier
Signed-off-by: Alex Bennée
Message-Id
From: Pierrick Bouvier
Signed-off-by: Pierrick Bouvier
Reviewed-by: Richard Henderson
Message-Id: <20241217224306.2900490-8-pierrick.bouv...@linaro.org>
Signed-off-by: Alex Bennée
Message-Id: <20250116160306.1709518-18-alex.ben...@linaro.org>
diff --git a/contrib/plugins/h
From: Pierrick Bouvier
Reviewed-by: Richard Henderson
Signed-off-by: Pierrick Bouvier
Message-Id: <20241217224306.2900490-5-pierrick.bouv...@linaro.org>
Signed-off-by: Alex Bennée
Message-Id: <20250116160306.1709518-15-alex.ben...@linaro.org>
diff --git a/tests/tcg/plugins/mem.c
windows ndis script
----
Alex Bennée (11):
semihosting: add guest_error logging for failed opens
system/vl: more error exit into config enumeration code
system: squash usb_parse into a single function
system: propagate Error to gdbserver_start (and
Tested-by: Stefan Weil
Tested-by: Philippe Mathieu-Daudé
Message-Id: <20250110203401.178532-2-pierrick.bouv...@linaro.org>
Signed-off-by: Alex Bennée
Message-Id: <20250116160306.1709518-24-alex.ben...@linaro.org>
diff --git a/meson.build b/meson.build
index d06f59095c..da279cc112 10
Daudé
Reviewed-by: Richard Henderson
Message-Id: <20250103171037.11265-6-phi...@linaro.org>
Signed-off-by: Alex Bennée
Message-Id: <20250116160306.1709518-8-alex.ben...@linaro.org>
diff --git a/semihosting/meson.build b/semihosting/meson.build
index 34933e5a19..86f5004bed 100644
From: Pierrick Bouvier
Reviewed-by: Richard Henderson
Signed-off-by: Pierrick Bouvier
Message-Id: <20241217224306.2900490-12-pierrick.bouv...@linaro.org>
Signed-off-by: Alex Bennée
Message-Id: <20250116160306.1709518-22-alex.ben...@linaro.org>
diff --git a/configure b/con
s & TLB_INVALID_MASK) {
| ^
Signed-off-by: Philippe Mathieu-Daudé
Reviewed-by: Richard Henderson
Message-Id: <20250103171037.11265-3-phi...@linaro.org>
Signed-off-by: Alex Bennée
Message-Id: <20250116160306.1709518-5-alex.ben...@linaro.org>
diff --git a/semihosting/uaccess.c b/se
x27;target_ulong'
26 |target_ulong fname, target_ulong fname_len,
|^
Signed-off-by: Philippe Mathieu-Daudé
Reviewed-by: Richard Henderson
Message-Id: <20250103171037.11265-2-phi...@linaro.org>
Signed-off-by: Alex Bennée
Message-Id: <20250116160306.
hieu-Daudé
Reviewed-by: Pierrick Bouvier
Reviewed-by: Richard Henderson
Reviewed-by: Philippe Mathieu-Daudé
Signed-off-by: Alex Bennée
Message-Id: <20250116160306.1709518-9-alex.ben...@linaro.org>
diff --git a/system/vl.c b/system/vl.c
index be029c52ef..22c1444da4 100644
--- a/system/vl.c
++
phi...@linaro.org>
Signed-off-by: Alex Bennée
Message-Id: <20250116160306.1709518-3-alex.ben...@linaro.org>
diff --git a/include/semihosting/uaccess.h b/include/semihosting/uaccess.h
index c2fa5a655d..6bc90b12d6 100644
--- a/include/semihosting/uaccess.h
+++ b/include/semihosting/uaccess
From: Pierrick Bouvier
Reviewed-by: Richard Henderson
Signed-off-by: Pierrick Bouvier
Message-Id: <20241209183104.365796-7-pierrick.bouv...@linaro.org>
[AJB: update MAINTAINERS]
Signed-off-by: Alex Bennée
Message-Id: <20250116160306.1709518-37-alex.ben...@linaro.org>
diff --git a
This usually indicates the semihosting call was expecting to find
something but didn't.
Reviewed-by: Pierrick Bouvier
Signed-off-by: Alex Bennée
Message-Id: <20250116160306.1709518-2-alex.ben...@linaro.org>
diff --git a/semihosting/syscalls.c b/semihosting/syscalls.c
index
/compiler.h" deal with that by having it
> include "qemu/clang-tsa.h" (renamed as qemu/clang-tsa.h.inc).
> Add a check to not include "qemu/clang-tsa.h.inc" directly,
> remove previous "qemu/clang-tsa.h" inclusions.
>
> Suggested-by: Pierrick Bouvie
t values; they are
> not removed from code_gen_buffer only in order to keep things simple.
>
> Co-developed-by: Nina Schoetterl-Glausch
> Reviewed-by: Richard Henderson
> Signed-off-by: Ilya Leoshkevich
Reviewed-by: Alex Bennée
--
Alex Bennée
Virtualisation Tech Lead @ Linaro
Ilya Leoshkevich writes:
> These similarly named functions serve different purposes; add
> docstrings to highlight them.
>
> Suggested-by: Alex Bennée
> Signed-off-by: Ilya Leoshkevich
Reviewed-by: Alex Bennée
--
Alex Bennée
Virtualisation Tech Lead @ Linaro
e.h
> @@ -73,7 +73,7 @@ typedef struct VFIORamDiscardListener {
>
> int vfio_container_dma_map(VFIOContainerBase *bcontainer,
> hwaddr iova, ram_addr_t size,
> - void *vaddr, bool readonly);
> + void
: Philippe Mathieu-Daudé
Signed-off-by: Pierrick Bouvier
Tested-by: Stefan Weil
Tested-by: Philippe Mathieu-Daudé
Message-Id: <20250110203401.178532-4-pierrick.bouv...@linaro.org>
Signed-off-by: Alex Bennée
---
meson.build | 5 +
contrib/plugins/meson.build | 2 +-
p
From: Pierrick Bouvier
Reviewed-by: Richard Henderson
Signed-off-by: Pierrick Bouvier
Message-Id: <20241217224306.2900490-9-pierrick.bouv...@linaro.org>
Signed-off-by: Alex Bennée
---
contrib/plugins/cflow.c | 17 +++--
1 file changed, 11 insertions(+), 6 deletions(-)
diff
igd.c| 125 +++
> hw/vfio/pci-quirks.c | 57 +++-
> hw/vfio/pci-quirks.h | 72 +
> 3 files changed, 109 insertions(+), 145 deletions(-)
> create mode 100644 hw/vfio/pci-quirks.h
>
Reviewed-by: Alex Williamson
From: Pierrick Bouvier
Reviewed-by: Philippe Mathieu-Daudé
Reviewed-by: Richard Henderson
Signed-off-by: Pierrick Bouvier
Tested-by: Stefan Weil
Tested-by: Philippe Mathieu-Daudé
Message-Id: <20250110203401.178532-3-pierrick.bouv...@linaro.org>
Signed-off-by: Alex Bennée
---
docs
1 - 100 of 6139 matches
Mail list logo
