Re: [PATCH v2] docs/devel/submitting-a-patch.rst: add b4 section

2025-08-04 Thread Alex Bennée
Manos Pitsidianakis writes: > Add a section about b4, an actively maintained and widely packaged CLI > tool for contributing to patch-based development projects. > > Reviewed-by: Gustavo Romero > Signed-off-by: Manos Pitsidianakis Queued to maintainer/for-10.1-rc2, thanks.

Re: [PULL 11/14] tests/tcg: reduce the number of plugin tests combinations

2025-08-04 Thread Alex Bennée
Pierrick Bouvier writes: > On 7/28/25 12:03 PM, Pierrick Bouvier wrote: >> Hi Alex, >> On 7/27/25 1:32 AM, Alex Bennée wrote: >>> As our set of multiarch tests has grown the practice of running every >>> plugin with every test is becoming unsustainable. If we

Re: [PATCH for-10.2 0/4] vfio: Remove 'vfio-platform'

2025-07-31 Thread Alex Williamson
ode 100644 include/hw/vfio/vfio-platform.h > delete mode 100644 hw/vfio/amd-xgbe.c > delete mode 100644 hw/vfio/calxeda-xgmac.c > delete mode 100644 hw/vfio/platform.c > Reviewed-by: Alex Williamson

Re: [PATCH 0/5] contrib/plugins/hotblocks: Minor bug fixes and add limit argument

2025-07-30 Thread Alex Bradbury
On 2025-07-30 14:48, Manos Pitsidianakis wrote: > Hi Alex, > > On Wed, Jul 30, 2025 at 4:19 PM Alex Bradbury wrote: >> >> This series contains one minor feature addition and a series of small >> bugfixes/improvements. The addition that motivates the submission is to

[PATCH 1/5] contrib/plugins/hotblocks: Correctly free sorted counts list

2025-07-30 Thread Alex Bradbury
g_list_free should be passed the head of the list. Signed-off-by: Alex Bradbury --- contrib/plugins/hotblocks.c | 9 + 1 file changed, 5 insertions(+), 4 deletions(-) diff --git a/contrib/plugins/hotblocks.c b/contrib/plugins/hotblocks.c index 98404b6885..d3dd23ed9f 100644 --- a

[PATCH 3/5] contrib/plugins/hotblocks: Print uint64_t with PRIu64 rather than PRId64

2025-07-30 Thread Alex Bradbury
qemu_plugin_u64_sum returns a uint64_t, so PRIu64 is the correct format specifier. Signed-off-by: Alex Bradbury --- contrib/plugins/hotblocks.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/contrib/plugins/hotblocks.c b/contrib/plugins/hotblocks.c index cf4d6b8c36

[PATCH 5/5] contrib/plugins/hotblocks: Allow limit to be set as a command line argument

2025-07-30 Thread Alex Bradbury
Also add documentation for this argument. This allows the default of 20 to be overridden, and is helpful for using the hotblocks plugin for analysis scripts that require collecting data on a larger number of blocks (e.g. setting limit=0 to dump information on all blocks). Signed-off-by: Alex

[PATCH 0/5] contrib/plugins/hotblocks: Minor bug fixes and add limit argument

2025-07-30 Thread Alex Bradbury
. Setting limit=0 and dumping information about all executed blocks is incredibly helpful for an analysis script I have downstream. This is my first contribution to QEMU. I've attempted to follow all of the guidance in the "Submitting a Patch" guide, but apologies if I missed anything. A

[PATCH 2/5] contrib/plugins/hotblocks: Fix off by one error in iteration of sorted blocks

2025-07-30 Thread Alex Bradbury
g larger. Signed-off-by: Alex Bradbury --- contrib/plugins/hotblocks.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/contrib/plugins/hotblocks.c b/contrib/plugins/hotblocks.c index d3dd23ed9f..cf4d6b8c36 100644 --- a/contrib/plugins/hotblocks.c +++ b/contrib/plugins/hot

[PATCH 4/5] docs/about/emulation: Add documentation for hotblocks plugin arguments

2025-07-30 Thread Alex Bradbury
Currently just 'inline'. Signed-off-by: Alex Bradbury --- docs/about/emulation.rst | 10 ++ 1 file changed, 10 insertions(+) diff --git a/docs/about/emulation.rst b/docs/about/emulation.rst index 456d01d5b0..9c963f4705 100644 --- a/docs/about/emulation.rst +++ b/

Re: [PATCH 0/2] vfio/igd: Legacy mode fixes after introduction of

2025-07-28 Thread Alex Williamson
9 --- > hw/vfio/pci.c | 13 ++--- > hw/vfio/pci.h | 1 + > 4 files changed, 24 insertions(+), 10 deletions(-) > Reviewed-by: Alex Williamson

[PULL 09/14] tests/tcg: don't include multiarch tests if not supported

2025-07-27 Thread Alex Bennée
We are about to change the way the plugin runs are done and having this included by default will complicate things. Reviewed-by: Manos Pitsidianakis Signed-off-by: Alex Bennée Message-ID: <20250725154517.3523095-10-alex.ben...@linaro.org> diff --git a/tests/tcg/Makefile.target b/tes

[PULL 11/14] tests/tcg: reduce the number of plugin tests combinations

2025-07-27 Thread Alex Bennée
instrumentation test). We can handle this by manually adding them to EXTRA_RUNS. We also need to wrap rules in a CONFIG_PLUGIN test so we don't enable the runs when plugins are not enabled. Reviewed-by: Manos Pitsidianakis Signed-off-by: Alex Bennée Message-ID: <20250725154517.3523095-12-

[PULL 14/14] tests/functional: expose sys.argv to unittest.main

2025-07-27 Thread Alex Bennée
With this we can call the supported we can take advantage of the argument the module supports: env PYTHONPATH=/home/alex/lsrc/qemu.git/python:/home/alex/lsrc/qemu.git/tests/functional ./pyvenv/bin/python /home/alex/lsrc/qemu.git/tests/functional/test_aarch64_kvm.py --help usage

[PULL 10/14] configure: expose PYTHON to test/tcg/config-host.mak

2025-07-27 Thread Alex Bennée
This will be useful for making $shell calls to something more flexible than the shell builtins. Reviewed-by: Manos Pitsidianakis Signed-off-by: Alex Bennée Message-ID: <20250725154517.3523095-11-alex.ben...@linaro.org> diff --git a/configure b/configure index 95f67c1a827..825057ebf15

[PULL for 10.1-rc1 00/14] documentation an testing updates

2025-07-27 Thread Alex Bennée
edded help ---- Alex Bennée (14): docs/user: clarify user-mode expects the same OS docs/system: reword the TAP notes to remove tarball ref docs/user: clean up headings docs/user: slightly reword section on system calls docs/user: expand section on threading

[PULL 03/14] docs/user: clean up headings

2025-07-27 Thread Alex Bennée
This was a slightly duff format for rst, make it use proper headings. Reviewed-by: Manos Pitsidianakis Reviewed-by: Richard Henderson Signed-off-by: Alex Bennée Message-ID: <20250725154517.3523095-4-alex.ben...@linaro.org> diff --git a/docs/user/main.rst b/docs/user/main.rst index 9a1c6

[PULL 07/14] tests/tcg: skip libsyscall.so on softmmu tests

2025-07-27 Thread Alex Bennée
It isn't testing anything and just expanding the runtime of testing. Reviewed-by: Manos Pitsidianakis Signed-off-by: Alex Bennée Message-ID: <20250725154517.3523095-8-alex.ben...@linaro.org> diff --git a/tests/tcg/Makefile.target b/tests/tcg/Makefile.target index af68f11664f..

[PULL 13/14] tests/docker: handle host-arch selection for all-test-cross

2025-07-27 Thread Alex Bennée
When building on non-x86 we get a bunch but not all of the compilers. Handle this in the Dockerfile by probing the arch and expanding the list available. Reviewed-by: Manos Pitsidianakis Signed-off-by: Alex Bennée Message-ID: <20250725154517.3523095-14-alex.ben...@linaro.org> diff -

[PULL 12/14] tests/docker: add --arch-only to qemu deps for all-test-cross

2025-07-27 Thread Alex Bennée
If we want to build this container on non-x86 systems we might not have all the cross-compilers needed for the ROM blobs we don't actually build. Use --arch-only to avoid stalling on these missing bits. Reviewed-by: Manos Pitsidianakis Signed-off-by: Alex Bennée Messa

[PULL 06/14] tests/functional: add hypervisor test for aarch64

2025-07-27 Thread Alex Bennée
ed-by: Manos Pitsidianakis Reviewed-by: Manos Pitsidianakis Signed-off-by: Alex Bennée Message-ID: <20250725154517.3523095-7-alex.ben...@linaro.org> diff --git a/tests/functional/meson.build b/tests/functional/meson.build index 8bebcd4d94e..ecf965adc6c 100644 --- a/tests/functional/meson.

[PULL 02/14] docs/system: reword the TAP notes to remove tarball ref

2025-07-27 Thread Alex Bennée
We don't ship the tarball and users should generally look to the distribution specific packaging. Resolves: https://gitlab.com/qemu-project/qemu/-/issues/560 Reviewed-by: Manos Pitsidianakis Signed-off-by: Alex Bennée Message-ID: <20250725154517.3523095-3-alex.ben...@linaro.org> d

[PULL 01/14] docs/user: clarify user-mode expects the same OS

2025-07-27 Thread Alex Bennée
While we somewhat cover this later when we talk about supported operating systems make it clear in the front matter. Reviewed-by: Manos Pitsidianakis Signed-off-by: Alex Bennée Message-ID: <20250725154517.3523095-2-alex.ben...@linaro.org> diff --git a/docs/user/index.rst b/docs/user/ind

[PULL 04/14] docs/user: slightly reword section on system calls

2025-07-27 Thread Alex Bennée
Expand the description slightly and quote ioctl(). I did ponder mentioning something about why DRM ioctls are often missing but I see we have the I915 ones so I guess its just no one has done them. Reviewed-by: Manos Pitsidianakis Signed-off-by: Alex Bennée Message-ID: <20250725154517.352309

[PULL 05/14] docs/user: expand section on threading

2025-07-27 Thread Alex Bennée
Potentially too many weasel words when describing atomic and memory order issues. Reviewed-by: Richard Henderson Signed-off-by: Alex Bennée Message-ID: <20250725154517.3523095-6-alex.ben...@linaro.org> diff --git a/docs/user/main.rst b/docs/user/main.rst index 05de904225c..347bdfabf8c

[PULL 08/14] tests/tcg: remove ADDITIONAL_PLUGINS_TESTS

2025-07-27 Thread Alex Bennée
We never actually used this is the end. Remove it to enable re-factoring. Fixes: 7cefff22d54 (tests/tcg: add mechanism to run specific tests with plugins) Reviewed-by: Manos Pitsidianakis Signed-off-by: Alex Bennée Message-ID: <20250725154517.3523095-9-alex.ben...@linaro.org> diff -

Re: [PATCH v2] target/arm: add support for 64-bit PMCCNTR in AArch32 mode

2025-07-25 Thread Alex Richardson
On Fri, 25 Jul 2025 at 02:19, Peter Maydell wrote: > > On Fri, 25 Jul 2025 at 01:10, Alex Richardson > wrote: > > > > In the PMUv3, a new AArch32 64-bit (MCRR/MRRC) accessor for the > > PMCCNTR was added. In QEMU we forgot to implement this, so only > > prov

[PATCH v3] target/arm: add support for 64-bit PMCCNTR in AArch32 mode

2025-07-25 Thread Alex Richardson
/ddi0601/2024-06/AArch32-Registers/PMCCNTR--Performance-Monitors-Cycle-Count-Register?lang=en Change v2->v3: - Moved ARM_CP_NO_GDB to the 32-bit register if Armv8 is supported Changes v1->v2: - Moved to new file - Updated commit message - Added ARM_CP_NO_GDB Signed-off-by: Alex Rich

[PATCH for 10.1 v2 13/14] tests/docker: handle host-arch selection for all-test-cross

2025-07-25 Thread Alex Bennée
When building on non-x86 we get a bunch but not all of the compilers. Handle this in the Dockerfile by probing the arch and expanding the list available. Reviewed-by: Manos Pitsidianakis Signed-off-by: Alex Bennée --- v2 - expand all arches in a single RUN statement --- .../dockerfiles

[PATCH for 10.1 v2 06/14] tests/functional: add hypervisor test for aarch64

2025-07-25 Thread Alex Bennée
ed-by: Manos Pitsidianakis Reviewed-by: Manos Pitsidianakis Signed-off-by: Alex Bennée --- v2 - drop try/except (copy paste from gpu handling) - refactor tests into helper, add commentary - drop 2 line spacing --- tests/functional/meson.build | 1 + tests/functional/test_aarch64_k

[PATCH for 10.1 v2 03/14] docs/user: clean up headings

2025-07-25 Thread Alex Bennée
This was a slightly duff format for rst, make it use proper headings. Reviewed-by: Manos Pitsidianakis Reviewed-by: Richard Henderson Signed-off-by: Alex Bennée --- docs/user/main.rst | 50 ++ 1 file changed, 28 insertions(+), 22 deletions(-) diff

[PATCH for 10.1 v2 05/14] docs/user: expand section on threading

2025-07-25 Thread Alex Bennée
Potentially too many weasel words when describing atomic and memory order issues. Signed-off-by: Alex Bennée --- v2 - /we are limit/we limit/ - use QEMU -user-mode process instead of guest --- docs/user/main.rst | 12 +--- 1 file changed, 9 insertions(+), 3 deletions(-) diff --git

[PATCH for 10.1 v2 10/14] configure: expose PYTHON to test/tcg/config-host.mak

2025-07-25 Thread Alex Bennée
This will be useful for making $shell calls to something more flexible than the shell builtins. Reviewed-by: Manos Pitsidianakis Signed-off-by: Alex Bennée --- configure | 1 + 1 file changed, 1 insertion(+) diff --git a/configure b/configure index 95f67c1a827..825057ebf15 100755 --- a

[PATCH for 10.1 v2 07/14] tests/tcg: skip libsyscall.so on softmmu tests

2025-07-25 Thread Alex Bennée
It isn't testing anything and just expanding the runtime of testing. Reviewed-by: Manos Pitsidianakis Signed-off-by: Alex Bennée --- tests/tcg/Makefile.target | 6 ++ 1 file changed, 6 insertions(+) diff --git a/tests/tcg/Makefile.target b/tests/tcg/Makefile.target index af68f1

[PATCH for 10.1 v2 12/14] tests/docker: add --arch-only to qemu deps for all-test-cross

2025-07-25 Thread Alex Bennée
If we want to build this container on non-x86 systems we might not have all the cross-compilers needed for the ROM blobs we don't actually build. Use --arch-only to avoid stalling on these missing bits. Reviewed-by: Manos Pitsidianakis Signed-off-by: Alex Bennée --- tests/docker/docker

[PATCH for 10.1 v2 08/14] tests/tcg: remove ADDITIONAL_PLUGINS_TESTS

2025-07-25 Thread Alex Bennée
We never actually used this is the end. Remove it to enable re-factoring. Fixes: 7cefff22d54 (tests/tcg: add mechanism to run specific tests with plugins) Reviewed-by: Manos Pitsidianakis Signed-off-by: Alex Bennée --- tests/tcg/Makefile.target | 3 +-- 1 file changed, 1 insertion(+), 2

[PATCH for 10.1 v2 00/14] documentation updates and test tweaks pre-PR

2025-07-25 Thread Alex Bennée
27;m away for a week so if I don't post the PR on Saturday another maintainer is free to merge it via their tree. The following need review: docs/user: expand section on threading Alex. Alex Bennée (14): docs/user: clarify user-mode expects the same OS docs/system: reword the TAP notes t

[PATCH for 10.1 v2 11/14] tests/tcg: reduce the number of plugin tests combinations

2025-07-25 Thread Alex Bennée
instrumentation test). We can handle this by manually adding them to EXTRA_RUNS. We also need to wrap rules in a CONFIG_PLUGIN test so we don't enable the runs when plugins are not enabled. Reviewed-by: Manos Pitsidianakis Signed-off-by: Alex Bennée --- tests/tcg/Makefile.target

[PATCH for 10.1 v2 02/14] docs/system: reword the TAP notes to remove tarball ref

2025-07-25 Thread Alex Bennée
We don't ship the tarball and users should generally look to the distribution specific packaging. Resolves: https://gitlab.com/qemu-project/qemu/-/issues/560 Reviewed-by: Manos Pitsidianakis Signed-off-by: Alex Bennée --- docs/system/devices/net.rst | 16 +++- 1 file change

[PATCH for 10.1 v2 01/14] docs/user: clarify user-mode expects the same OS

2025-07-25 Thread Alex Bennée
While we somewhat cover this later when we talk about supported operating systems make it clear in the front matter. Reviewed-by: Manos Pitsidianakis Signed-off-by: Alex Bennée --- docs/user/index.rst | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/docs/user/index.rst

[PATCH for 10.1 v2 14/14] tests/functional: expose sys.argv to unittest.main

2025-07-25 Thread Alex Bennée
With this we can call the supported we can take advantage of the argument the module supports: env PYTHONPATH=/home/alex/lsrc/qemu.git/python:/home/alex/lsrc/qemu.git/tests/functional ./pyvenv/bin/python /home/alex/lsrc/qemu.git/tests/functional/test_aarch64_kvm.py --help usage

[PATCH for 10.1 v2 09/14] tests/tcg: don't include multiarch tests if not supported

2025-07-25 Thread Alex Bennée
We are about to change the way the plugin runs are done and having this included by default will complicate things. Reviewed-by: Manos Pitsidianakis Signed-off-by: Alex Bennée --- tests/tcg/Makefile.target | 6 ++ tests/tcg/multiarch/system/Makefile.softmmu-target

[PATCH for 10.1 v2 04/14] docs/user: slightly reword section on system calls

2025-07-25 Thread Alex Bennée
Expand the description slightly and quote ioctl(). I did ponder mentioning something about why DRM ioctls are often missing but I see we have the I915 ones so I guess its just no one has done them. Reviewed-by: Manos Pitsidianakis Signed-off-by: Alex Bennée --- docs/user/main.rst | 12

[RFC PATCH] tests/functional: expose sys.argv to unittest.main

2025-07-25 Thread Alex Bennée
With this we can call the supported we can take advantage of the argument the module supports: env PYTHONPATH=/home/alex/lsrc/qemu.git/python:/home/alex/lsrc/qemu.git/tests/functional ./pyvenv/bin/python /home/alex/lsrc/qemu.git/tests/functional/test_aarch64_kvm.py --help usage

Re: [PATCH v3 4/4] tests/functional: add -k TEST_NAME_PATTERN CLI arg

2025-07-25 Thread Alex Bennée
mas Huth > Signed-off-by: Manos Pitsidianakis Tested-by: Alex Bennée -- Alex Bennée Virtualisation Tech Lead @ Linaro

Re: [PATCH v3 1/4] tests/functional: add --debug CLI arg

2025-07-25 Thread Alex Bennée
> only. > > Signed-off-by: Manos Pitsidianakis Tested-by: Alex Bennée -- Alex Bennée Virtualisation Tech Lead @ Linaro

Re: [PATCH for 10.1 13/13] tests/docker: handle host-arch selection for all-test-cross

2025-07-25 Thread Alex Bennée
Manos Pitsidianakis writes: > On Thu, Jul 24, 2025 at 3:36 PM Alex Bennée wrote: >> >> Manos Pitsidianakis writes: >> >> > On Thu, Jul 24, 2025 at 2:00 PM Alex Bennée wrote: >> >> >> >> When building on non-x86 we get a bunch but not all

[PATCH v2] target/arm: add support for 64-bit PMCCNTR in AArch32 mode

2025-07-24 Thread Alex Richardson
/AArch32-Registers/PMCCNTR--Performance-Monitors-Cycle-Count-Register?lang=en Signed-off-by: Alex Richardson --- target/arm/cpregs-pmu.c | 6 ++ 1 file changed, 6 insertions(+) diff --git a/target/arm/cpregs-pmu.c b/target/arm/cpregs-pmu.c index 0f295b1376..ef176e4045 100644 --- a/target/arm

Re: [PATCH for 10.1 11/13] tests/tcg: reduce the number of plugin tests combinations

2025-07-24 Thread Alex Bennée
Manos Pitsidianakis writes: > On Thu, Jul 24, 2025 at 3:00 PM Alex Bennée wrote: >> >> Manos Pitsidianakis writes: >> >> > On Thu, Jul 24, 2025 at 2:00 PM Alex Bennée wrote: >> >> >> >> As our set of multiarch tests has grown the pra

Re: [PATCH 03/14] python: drop 'is_closing' back compat helper

2025-07-24 Thread Alex Bennée
Daniel P. Berrangé writes: > Our minimum python is now 3.9, so back compat with python > 3.6 is no longer required. > > Signed-off-by: Daniel P. Berrangé Reviewed-by: Alex Bennée -- Alex Bennée Virtualisation Tech Lead @ Linaro

Re: [PATCH for 10.1 13/13] tests/docker: handle host-arch selection for all-test-cross

2025-07-24 Thread Alex Bennée
Manos Pitsidianakis writes: > On Thu, Jul 24, 2025 at 2:00 PM Alex Bennée wrote: >> >> When building on non-x86 we get a bunch but not all of the compilers. >> Handle this in the Dockerfile by probing the arch and expanding the >> list available. >&

Re: [PATCH for 10.1 11/13] tests/tcg: reduce the number of plugin tests combinations

2025-07-24 Thread Alex Bennée
Manos Pitsidianakis writes: > On Thu, Jul 24, 2025 at 2:00 PM Alex Bennée wrote: >> >> As our set of multiarch tests has grown the practice of running every >> plugin with every test is becoming unsustainable. If we switch to >> ensuring every test gets run with at le

[PATCH for 10.1 05/13] docs/user: expand section on threading

2025-07-24 Thread Alex Bennée
Potentially too many weasel words when describing atomic and memory order issues. Signed-off-by: Alex Bennée --- docs/user/main.rst | 11 --- 1 file changed, 8 insertions(+), 3 deletions(-) diff --git a/docs/user/main.rst b/docs/user/main.rst index 05de904225c..449acd4a324 100644 --- a

[PATCH for 10.1 07/13] tests/tcg: skip libsyscall.so on softmmu tests

2025-07-24 Thread Alex Bennée
It isn't testing anything and just expanding the runtime of testing. Signed-off-by: Alex Bennée --- tests/tcg/Makefile.target | 6 ++ 1 file changed, 6 insertions(+) diff --git a/tests/tcg/Makefile.target b/tests/tcg/Makefile.target index af68f11664f..3d96182a7b9 100644 --- a/test

[PATCH for 10.1 12/13] tests/docker: add --arch-only to qemu deps for all-test-cross

2025-07-24 Thread Alex Bennée
If we want to build this container on non-x86 systems we might not have all the cross-compilers needed for the ROM blobs we don't actually build. Use --arch-only to avoid stalling on these missing bits. Signed-off-by: Alex Bennée --- tests/docker/dockerfiles/debian-all-test-cross.docke

[PATCH for 10.1 09/13] tests/tcg: don't include multiarch tests if not supported

2025-07-24 Thread Alex Bennée
We are about to change the way the plugin runs are done and having this included by default will complicate things. Signed-off-by: Alex Bennée --- tests/tcg/Makefile.target | 6 ++ tests/tcg/multiarch/system/Makefile.softmmu-target | 5 + 2 files changed, 11

[PATCH for 10.1 01/13] docs/user: clarify user-mode expects the same OS

2025-07-24 Thread Alex Bennée
While we somewhat cover this later when we talk about supported operating systems make it clear in the front matter. Signed-off-by: Alex Bennée --- docs/user/index.rst | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/docs/user/index.rst b/docs/user/index.rst index

Re: [PATCH v2] tests/functional: add hypervisor test for aarch64

2025-07-24 Thread Alex Bennée
Philippe Mathieu-Daudé writes: > From: Alex Bennée > > This is a simple test case that runs an image with kvmtool and > kvm-unit-tests which can validate virtualisation works. This is useful > for exercising TCG but can also be applied to any nested virt setup > which is why

[PATCH for 10.1 00/13] documentation updates and test tweaks

2025-07-24 Thread Alex Bennée
ests/functional: add hypervisor test for aarch64 docs/user: expand section on threading docs/user: slightly reword section on system calls docs/user: clean up headings docs/system: reword the TAP notes to remove tarball ref docs/user: clarify user-mode expects the same OS Alex. Alex Benn

[PATCH for 10.1 08/13] tests/tcg: remove ADDITIONAL_PLUGINS_TESTS

2025-07-24 Thread Alex Bennée
We never actually used this is the end. Remove it to enable re-factoring. Fixes: 7cefff22d54 (tests/tcg: add mechanism to run specific tests with plugins) Signed-off-by: Alex Bennée --- tests/tcg/Makefile.target | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/tests/tcg

[PATCH for 10.1 13/13] tests/docker: handle host-arch selection for all-test-cross

2025-07-24 Thread Alex Bennée
When building on non-x86 we get a bunch but not all of the compilers. Handle this in the Dockerfile by probing the arch and expanding the list available. Signed-off-by: Alex Bennée --- .../dockerfiles/debian-all-test-cross.docker | 31 ++- 1 file changed, 17 insertions(+), 14

[PATCH for 10.1 11/13] tests/tcg: reduce the number of plugin tests combinations

2025-07-24 Thread Alex Bennée
instrumentation test). We can handle this by manually adding them to EXTRA_RUNS. We also need to wrap rules in a CONFIG_PLUGIN test so we don't enable the runs when plugins are not enabled. Signed-off-by: Alex Bennée --- tests/tcg/Makefile.target | 23 ++- test

[PATCH for 10.1 10/13] configure: expose PYTHON to test/tcg/config-host.mak

2025-07-24 Thread Alex Bennée
This will be useful for making $shell calls to something more flexible than the shell builtins. Signed-off-by: Alex Bennée --- configure | 1 + 1 file changed, 1 insertion(+) diff --git a/configure b/configure index 95f67c1a827..825057ebf15 100755 --- a/configure +++ b/configure @@ -1800,6

[PATCH for 10.1 03/13] docs/user: clean up headings

2025-07-24 Thread Alex Bennée
This was a slightly duff format for rst, make it use proper headings. Signed-off-by: Alex Bennée --- docs/user/main.rst | 50 ++ 1 file changed, 28 insertions(+), 22 deletions(-) diff --git a/docs/user/main.rst b/docs/user/main.rst index 9a1c60448c5

[PATCH for 10.1 02/13] docs/system: reword the TAP notes to remove tarball ref

2025-07-24 Thread Alex Bennée
We don't ship the tarball and users should generally look to the distribution specific packaging. Resolves: https://gitlab.com/qemu-project/qemu/-/issues/560 Signed-off-by: Alex Bennée --- docs/system/devices/net.rst | 16 +++- 1 file changed, 11 insertions(+), 5 deletions(-)

[PATCH for 10.1 04/13] docs/user: slightly reword section on system calls

2025-07-24 Thread Alex Bennée
Expand the description slightly and quote ioctl(). I did ponder mentioning something about why DRM ioctls are often missing but I see we have the I915 ones so I guess its just no one has done them. Signed-off-by: Alex Bennée --- docs/user/main.rst | 12 1 file changed, 8 insertions

[PATCH for 10.1 06/13] tests/functional: add hypervisor test for aarch64

2025-07-24 Thread Alex Bennée
This is a simple test case that runs an image with kvmtool and kvm-unit-tests which can validate virtualisation works. This is useful for exercising TCG but can also be applied to any nested virt setup which is why it doesn't specify an accelerator. Signed-off-by: Alex Bennée Cc: Phi

Re: [PATCH] hw/sd: print bad s->arglen in unexpected response

2025-07-23 Thread Alex Bennée
the guest miss-programming the device with invalid data? There could be an argument for using: qemu_log_mask(LOG_GUEST_ERROR, "Unexpected response to cmd %d, arglen=%d\n", s->cmd, s->arglen); instead. Phillipe WDYT? > /* Illegal command is about as near as we can get. */ > s->arglen = 1; > s->response[0] = 4; -- Alex Bennée Virtualisation Tech Lead @ Linaro

Re: [SPAM] [PATCH v4 4/5] hw/misc/aspeed_otp: Add 'drive' property to support block backend

2025-07-22 Thread Alex Bennée
>> +} else { >> num = s->size / sizeof(uint32_t); >> p = (uint32_t *)s->storage; >> for (i = 0; i < num; i++) { >> p[i] = (i % 2 == 0) ? 0x : 0x; >> } >> - >> +} >> return true; >> } >> @@ -75,6 +88,7 @@ static void aspeed_otp_realize(DeviceState *dev, >> Error **errp) >> static const Property aspeed_otp_properties[] = { >> DEFINE_PROP_UINT64("size", AspeedOTPState, size, 0), >> +DEFINE_PROP_DRIVE("drive", AspeedOTPState, blk), >> }; >> static void aspeed_otp_class_init(ObjectClass *klass, const void >> *data) -- Alex Bennée Virtualisation Tech Lead @ Linaro

[RFC PATCH] tests/functional: add hypervisor test for aarch64

2025-07-21 Thread Alex Bennée
This is a simple test case that runs an image with kvmtool and kvm-unit-tests which can validate virtualisation works. This is useful for exercising TCG but can also be applied to any nested virt setup which is why it doesn't specify an accelerator. Signed-off-by: Alex Bennée Cc: Phi

KVM/QEMU community call for agenda items (22/7/25)

2025-07-21 Thread Alex Bennée
Hi, The KVM/QEMU community call is at: https://meet.jit.si/kvmcallmeeting @ 22/07/2025 13:00 UTC Are there any agenda items for the sync-up? -- Alex Bennée Virtualisation Tech Lead @ Linaro

Re: [RFC PATCH 0/6] Fix building of sparc/sparc32plus test cases

2025-07-17 Thread Alex Bennée
Mark Cave-Ayland writes: > On 16/07/2025 11:54, Alex Bennée wrote: > >> We didn't have any reliable way to build sparc test cases. I have >> found someone who ships a compiler but the binaries still don't run >> due to the need for CASA. >> I'm p

[PATCH] docs/devel: fix over-quoting of QEMU_TEST_KEEP_SCRATCH

2025-07-17 Thread Alex Bennée
Signed-off-by: Alex Bennée --- docs/devel/testing/functional.rst | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/docs/devel/testing/functional.rst b/docs/devel/testing/functional.rst index 9d08abe284..2725633e09 100644 --- a/docs/devel/testing/functional.rst +++ b/docs/devel

Re: [PATCH] tests/functional: add --debug CLI arg

2025-07-17 Thread Alex Bennée
Thomas Huth writes: > On 17/07/2025 10.42, Alex Bennée wrote: >> Manos Pitsidianakis writes: >> >>> Add argument parsing to functional tests to improve developer experience >>> when running individual tests. All logs are printed to stdout >>> intersp

Re: [PATCH] tests/functional: add --debug CLI arg

2025-07-17 Thread Alex Bennée
Manos Pitsidianakis writes: > On Thu, Jul 17, 2025 at 11:42 AM Alex Bennée wrote: >> >> Manos Pitsidianakis writes: >> >> > Add argument parsing to functional tests to improve developer experience >> > when running individual tests. All logs are print

Re: [PATCH] tests/functional: add --debug CLI arg

2025-07-17 Thread Alex Bennée
-help > usage: test_aarch64_virt [-h] [-d] Am I holding it wrong? ➜ ./pyvenv/bin/python ../../tests/functional/test_aarch64_virt.py --help Traceback (most recent call last): File "/home/alex/lsrc/qemu.git/builds/all/../../tests/functional/test_aarch64_virt.py", line 16, in

Re: [PATCH-for-10.1 1/3] accel/hvf: Display executable bit as 'X'

2025-07-16 Thread Alex Bennée
Philippe Mathieu-Daudé writes: > Developers are custom to read RWX, not RWE. > Replace E -> X. > > Reported-by: Alex Bennée > Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Alex Bennée -- Alex Bennée Virtualisation Tech Lead @ Linaro

Re: HVF EL2 support in QEMU (aka FEAT_NV/FEAT_NV2) for MacOS

2025-07-16 Thread Alex Bennée
5 at 4:51 AM Marc Zyngier wrote: >>> >>> On Tue, 15 Jul 2025 12:15:52 +0100, >>> Alex Bennée wrote: >>> >>>> - do we know which Apple silicon supports FEAT_NV2? >>> >>> M2 and latter definitely support FEAT_NV2. That's how KV

[RFC PATCH 5/6] configure: enable the container fallbacks for sparc/sparc32plus

2025-07-16 Thread Alex Bennée
Signed-off-by: Alex Bennée --- configure | 6 ++ 1 file changed, 6 insertions(+) diff --git a/configure b/configure index 3651cc3085..f187480d3a 100755 --- a/configure +++ b/configure @@ -1442,6 +1442,8 @@ probe_target_compiler() { riscv64) container_hosts=x86_64 ;; s390x

[RFC PATCH 3/6] configure: update sparc and sparc32plus target compiler detection

2025-07-16 Thread Alex Bennée
The sparc64 compiler can nominally be configured to compile 32 bit and v8plus binaries although in practice no one is now shipping them. Signed-off-by: Alex Bennée --- configure | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/configure b/configure index 2b2b3d6597

[RFC PATCH 6/6] docs/about: deprecate add sparc/sparc32plus-*-user

2025-07-16 Thread Alex Bennée
Even with a toolchain *-user is still broken. Maybe we should just deprecate the target. I haven't deprecated for system as we have functional tests that work and will continue to do so. Signed-off-by: Alex Bennée --- docs/about/deprecated.rst | 8 1 file changed, 8 insertions(+)

[RFC PATCH 1/6] tests/tcg: special case sparc test cases

2025-07-16 Thread Alex Bennée
they also need slightly different LDFLAGS to link to the atomic support library. Signed-off-by: Alex Bennée --- tests/tcg/Makefile.target | 9 --- tests/tcg/sparc/Makefile.target | 45 + 2 files changed, 50 insertions(+), 4 deletions(-) create mode 10

[RFC PATCH 0/6] Fix building of sparc/sparc32plus test cases

2025-07-16 Thread Alex Bennée
We didn't have any reliable way to build sparc test cases. I have found someone who ships a compiler but the binaries still don't run due to the need for CASA. I'm posting mainly for those who actually care who might want to fix up the remaining cases. Alex. Alex Bennée (

[RFC PATCH 4/6] tests/docker: add sparc-leon-cross container image

2025-07-16 Thread Alex Bennée
The distros no longer ship sparc compilers so we must use some others. The best I could find was Frontgrade Gasiler who ship gcc binaries: https://www.gaisler.com/compilers-operating-systems Add a simple image for building the test cases. Signed-off-by: Alex Bennée --- .../dockerfiles/sparc

[RFC PATCH 2/6] tests/tcg: special case sparc32plus test cases

2025-07-16 Thread Alex Bennée
We can re-use the sparc Makefile to ensure we build but don't run the tests. Signed-off-by: Alex Bennée --- tests/tcg/Makefile.target | 2 +- tests/tcg/sparc32plus | 1 + 2 files changed, 2 insertions(+), 1 deletion(-) create mode 12 tests/tcg/sparc32plus diff --git a/test

HVF EL2 support in QEMU (aka FEAT_NV/FEAT_NV2) for MacOS

2025-07-15 Thread Alex Bennée
pple silicon supports FEAT_NV2? - has anyone played with enabling it in QEMU or its forks? - what is missing to get this enabled upstream? And I'd follow that with: - is anyone interested in sponsoring some Mac hardware so we could enable proper HVF testing in our CI? Thanks, -- A

Re: [PATCH v6 03/39] system/runstate: Document qemu_add_vm_change_state_handler()

2025-07-15 Thread Alex Bennée
Xiaoyao Li writes: > On 7/4/2025 1:32 AM, Philippe Mathieu-Daudé wrote: >> Signed-off-by: Philippe Mathieu-Daudé >> Reviewed-by: Richard Henderson >> Reviewed-by: Alex Bennée >> --- >> include/system/runstate.h | 10 ++ >> 1 file changed, 1

Re: [PATCH v3] vfio/pci: Introduce x-pci-class-code option

2025-07-14 Thread Alex Williamson
| 6 ++ > hw/vfio/trace-events | 1 + > 3 files changed, 28 insertions(+), 8 deletions(-) Reviewed-by: Alex Williamson

[PULL 3/8] contrib/plugins/execlog: Add tab to the separator search of insn_disas

2025-07-14 Thread Alex Bennée
found in the current instruction as a trivial optimization, because searching for the remaining requested registers is unnecessary once one is found. Suggested-by: Alex Bennée Signed-off-by: Yodel Eldar Message-ID: <20250630164124.26315-2-yodel.el...@gmail.com> Reviewed-by: Pierrick Bouvier

[PULL 7/8] docs/system: clean-up formatting of virtio-net-failover

2025-07-14 Thread Alex Bennée
text. Reviewed-by: Manos Pitsidianakis Signed-off-by: Alex Bennée Message-ID: <20250710104531.3099313-8-alex.ben...@linaro.org> diff --git a/docs/system/virtio-net-failover.rst b/docs/system/virtio-net-failover.rst index 6002dc5d96..0cc465454c 100644 --- a/docs/system/virtio-net-failover.rst

[PULL 0/8] maintainer updates for rc0 (gitlab, gdbstub, plugins, docs)

2025-07-14 Thread Alex Bennée
lover docs ---- Alex Bennée (4): gitlab: use argparse in check-units script gitlab: add -n option to check-units script plugins: fix inclusion of user-mode APIs docs/system: clean-up formatting of virtio-net-failover Manos Pitsidianakis (1): docs: use :kb

[PULL 2/8] gitlab: add -n option to check-units script

2025-07-14 Thread Alex Bennée
Mostly a developer aid for those who want to look at the full backlog of multiple build units. Reviewed-by: Manos Pitsidianakis Signed-off-by: Alex Bennée Message-ID: <20250710104531.3099313-3-alex.ben...@linaro.org> diff --git a/.gitlab-ci.d/check-units.py b/.gitlab-ci.d/check-units.py

[PULL 5/8] plugins: fix inclusion of user-mode APIs

2025-07-14 Thread Alex Bennée
to be able to extract the relevant data from TaskState. Fixes: 903e870f24 (plugins/api: split out binary path/start/end/entry code) Resolves: https://gitlab.com/qemu-project/qemu/-/issues/3014 Reviewed-by: Pierrick Bouvier Signed-off-by: Alex Bennée Message-ID: <20250710104531.3099313-6-

[PULL 8/8] gdbstub: add the GDB register XML files for sparc64.

2025-07-14 Thread Alex Bennée
From: Rot127 Signed-off-by: Rot127 Message-ID: <20250711155141.62916-2-unis...@quyllur.org> [AJB: clean up commit msg] Signed-off-by: Alex Bennée diff --git a/configs/targets/sparc64-linux-user.mak b/configs/targets/sparc64-linux-user.mak index 64ea04e3e2..7c2ecb7be0 100644 --- a/c

[PULL 4/8] target/alpha: Add GDB XML feature file

2025-07-14 Thread Alex Bennée
gned-off-by: Alex Bennée Message-ID: <20250710104531.3099313-5-alex.ben...@linaro.org> diff --git a/configs/targets/alpha-linux-user.mak b/configs/targets/alpha-linux-user.mak index ef8e365b09..aa25766236 100644 --- a/configs/targets/alpha-linux-user.mak +++ b/configs/targets/alpha-linux-user

[PULL 6/8] docs: use :kbd: role in sphinx docs

2025-07-14 Thread Alex Bennée
the element to the user. Signed-off-by: Manos Pitsidianakis Message-ID: <20250709-docs_rst_improvements-v2-1-cb5096ad0...@linaro.org> Signed-off-by: Alex Bennée Message-ID: <20250710104531.3099313-7-alex.ben...@linaro.org> diff --git a/docs/devel/testing/main.rst b/docs/devel/test

[PULL 1/8] gitlab: use argparse in check-units script

2025-07-14 Thread Alex Bennée
Modernise the argument parsing so we can easily add to the script. Reviewed-by: Manos Pitsidianakis Signed-off-by: Alex Bennée Message-ID: <20250710104531.3099313-2-alex.ben...@linaro.org> diff --git a/.gitlab-ci.d/check-units.py b/.gitlab-ci.d/check-units.py index 268a4118d5..cdc6

Re: [PATCH v2 0/3] Reformatted Sparc GDB XML patches.

2025-07-14 Thread Alex Bennée
gdb-xml/sparc64-core.xml | 99 ++ > target/sparc/cpu.c | 2 + > 8 files changed, 190 insertions(+) > create mode 100644 gdb-xml/sparc32-core.xml > create mode 100644 gdb-xml/sparc64-core.xml -- Alex Bennée Virtualisation Tech Lead @ Linaro

Re: [PATCH v2 1/3] Adds the GDB register XML files for Sparc64.

2025-07-14 Thread Alex Bennée
0711155141.62916-2-unis...@quyllur.org> [AJB: clean up commit msg] Signed-off-by: Alex Bennée It's ok to have single line commit messages when the title can encapsulate everything you need to know. Extra stuff like Commit 1/3 is just noise in the commit log. > --- > configs/targets/spa

[PATCH 7/7] docs/system: clean-up formatting of virtio-net-failover

2025-07-10 Thread Alex Bennée
igned-off-by: Alex Bennée --- docs/system/virtio-net-failover.rst | 51 - 1 file changed, 28 insertions(+), 23 deletions(-) diff --git a/docs/system/virtio-net-failover.rst b/docs/system/virtio-net-failover.rst index 6002dc5d96..0cc465454c 100644 --- a/docs/system/v

  1   2   3   4   5   6   7   8   9   10   >