Re: [Qemu-devel] [PATCH v3] qemu-char: Do not disconnect when there's data for reading

2014-10-16 Thread Zifei Tong
Friendly ping. I've saw a couple of scripts affected by this bug. Thanks, Zifei On Sep 19, 2014 10:03 PM, "Kirill Batuzov" wrote: > On 19.09.2014 11:12, Zifei Tong wrote: > >> After commit 812c1057f6175ac9a9829fa2920a2b5783814193 (Handle G_IO_HUP >>

[Qemu-devel] [PATCH v3] qemu-char: Do not disconnect when there's data for reading

2014-09-19 Thread Zifei Tong
on as suggested by Kirill. Cc: Kirill Batuzov Cc: Nikolay Nikolaev Cc: Markus Armbruster Cc: Anthony Liguori Signed-off-by: Zifei Tong --- Changes in v3: handle EWOULDBLOCK, remove inaccurate comment qemu-char.c | 10 ++ 1 file changed, 2 insertions(+), 8 deletions(-) diff --git a/q

Re: [Qemu-devel] [PATCH v2] qemu-char: Do not disconnect when there's data for reading

2014-09-18 Thread Zifei Tong
Hi Markus, On Thu, Sep 18, 2014 at 8:11 PM, Markus Armbruster wrote: > Zifei Tong writes: > >> After commit 812c1057f6175ac9a9829fa2920a2b5783814193 (Handle G_IO_HUP >> in tcp_chr_read for tcp chardev), connections are disconnected when in >> G_IO_HUP condition. >

[Qemu-devel] [PATCH v2] qemu-char: Do not disconnect when there's data for reading

2014-09-18 Thread Zifei Tong
on as suggested by Kirill. Cc: Kirill Batuzov Cc: Nikolay Nikolaev Cc: Markus Armbruster Cc: Anthony Liguori Signed-off-by: Zifei Tong --- qemu-char.c | 8 +--- 1 file changed, 1 insertion(+), 7 deletions(-) diff --git a/qemu-char.c b/qemu-char.c index 2a3cb9f..6cc69fa 100644 --- a

Re: [Qemu-devel] [PATCH] qemu-char: Do not disconnect when there's data for reading

2014-09-17 Thread Zifei Tong
On Tue, Sep 16, 2014 at 11:30 PM, Kirill Batuzov wrote: > On Tue, 16 Sep 2014, Markus Armbruster wrote: > >> >> Kirill, you added the code being changed. Could you review the patch? >> > > I'll try but this is more about GIOConditions which I do not understan

Re: [Qemu-devel] [PATCH] qemu-char: Do not disconnect when there's data for reading

2014-09-16 Thread Zifei Tong
On Tue, Sep 16, 2014 at 2:06 PM, Markus Armbruster wrote: > Cc'ing Gerd for additional chardev expertise. > > Zifei Tong writes: > >> After commit 812c1057f6175ac9a9829fa2920a2b5783814193 (Handle G_IO_HUP >> in tcp_chr_read for tcp chardev), the connection is dis

Re: [Qemu-devel] [PATCH] qemu-char: Do not disconnect when there's data for reading

2014-09-15 Thread Zifei Tong
Friendly ping. Also CC to qemu-trivial. On Sun, Sep 7, 2014 at 8:24 PM, Zifei Tong wrote: > After commit 812c1057f6175ac9a9829fa2920a2b5783814193 (Handle G_IO_HUP > in tcp_chr_read for tcp chardev), the connection is disconnected when in > G_IO_HUP condition. > > However, it'

[Qemu-devel] [PATCH] qemu-char: Do not disconnect when there's data for reading

2014-09-07 Thread Zifei Tong
case, the remaining data is not handled. I saw a related bug when running socat in write-only mode, with $ echo "quit" | socat -u - UNIX-CONNECT:qemu-monitor the monitor won't not run the 'quit' command. CC: Kirill Batuzov CC: Nikolay Nikolaev CC: Anthony Ligu