[RFC PATCH] qemu-img: convert: introduce compression_level option

2023-12-09 Thread Yifan Zhao
This patch introduces a new parameter to customize the compression level in qemu-img convert. Resolves: https://gitlab.com/qemu-project/qemu/-/issues/1959 Signed-off-by: Yifan Zhao --- This patch adds a new compression_level option to qemu-img: convert, allowing the user to specify the

Re: [PATCH] accel/tcg: fix race in cpu_exec_step_atomic (bug 1863025)

2020-02-14 Thread Yifan Lu
could read tb_flush_count and find it already incremented. But if so that means thread A is at the end of do_tb_flush and the lookup tables are already cleared and the TCG context is already reset. So it should be safe for thread B to call tb_lookup__cpu_state or tb_gen_code. Yifan On Fri, Feb 14,

[Bug 1863025] Re: Use-after-free after flush in TCG accelerator

2020-02-14 Thread Yifan
Apologies, the patch got messed up. diff --git a/accel/tcg/cpu-exec.c b/accel/tcg/cpu-exec.c index c01f59c743..7a9e8c94bd 100644 --- a/accel/tcg/cpu-exec.c +++ b/accel/tcg/cpu-exec.c @@ -238,8 +238,11 @@ void cpu_exec_step_atomic(CPUState *cpu) uint32_t flags; uint32_t cflags = 1; u

[Bug 1863025] Re: Use-after-free after flush in TCG accelerator

2020-02-14 Thread Yifan
I found it just by launching Ubuntu 19.10 live cd with QXL driver. I will re-test this weekend. The workaround I had is to check the number of TLB flushes and to re-try obtaining the TB if the number changes. There is a penalty for the case where TLB is flushed but should not degrade performance i

[Bug 1863025] [NEW] Use-after-free after flush in TCG accelerator

2020-02-12 Thread Yifan
Public bug reported: I believe I found a UAF in TCG that can lead to a guest VM escape. The security list informed me "This can not be treated as a security issue." and to post it here. I am looking at the 4.2.0 source code. The issue requires a race and I will try to describe it in terms of three

[Bug 1863023] [NEW] Deadlock in QXL

2020-02-12 Thread Yifan
Public bug reported: This is on qemu 4.2.0 OSX host, running fresh Windows 7 with SPICE guest tools just installed. Command line: `qemu-system-x86_64 -qmp tcp:localhost:,server,nowait -smp cpus=2 -boot order=d -m 2048 -soundhw hda -drive file=hda.img,if=ide,media=disk -spice port=5930,addr=12

[Qemu-devel] [Bug 1679358] Re: ARM: SCTLR fields not being preserved

2017-04-04 Thread Yifan
So there won't be a fix in the future? I'm working with debugging a proprietary bootloader that I do not have the source code for. I wonder if this becomes an issue for any other platform targets. -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribe

[Qemu-devel] [Bug 1679358] [NEW] ARM: SCTLR fields not being preserved

2017-04-03 Thread Yifan
Public bug reported: There are fields in SCTLR that are RAO/SBOP or WI or in the case of the RR field, accessible only in secure mode. Currently it seems that qemu just propagates any write to SCTLR to the register and this screwed up in a bootloader that I am debugging. ** Affects: qemu Imp