Re: [PATCH] virtiofsd/helper: Add shared/no_shared options to help message

2020-02-23 Thread Xiao Yang
Hi David, Do you have any comment on this patch? :-) Cc qemu-devel@nongnu.org Best Regards, Xiao Yang On 2020/2/10 18:44, Xiao Yang wrote: > From: Xiao Yang > > Also add a hint that user should start 'ireg' daemon before using shared > cache. > > Signed-off-b

[PATCH] virtiofsd: Remove fuse.h and struct fuse_module

2020-02-20 Thread Xiao Yang
All code in fuse.h and struct fuse_module are not used by virtiofsd so removing them is safe. Signed-off-by: Xiao Yang --- tools/virtiofsd/fuse.h | 1229 -- tools/virtiofsd/fuse_i.h | 16 - 2 files changed, 1245 deletions(-) delete mode 100644 tools

Re: [PATCH v2 006/109] virtiofsd: Trim down imported files

2020-01-21 Thread Xiao Yang
tch for the detailed info: https://www.redhat.com/archives/virtio-fs/2020-January/msg00117.html Best Regards, Xiao Yang

Re: [PATCH 006/104] virtiofsd: Trim down imported files

2020-01-21 Thread Xiao Yang
On 2020/1/21 18:51, Dr. David Alan Gilbert wrote: * Xiao Yang (yangx...@cn.fujitsu.com) wrote: On 2019/12/13 0:37, Dr. David Alan Gilbert (git) wrote: - res = fuse_buf_copy(&pipe_buf, buf, - FUSE_BUF_FORCE_SPLICE | FUSE_BUF_SPLICE_NONBLOCK); - if (res&

Re: [PATCH 006/104] virtiofsd: Trim down imported files

2020-01-21 Thread Xiao Yang
removed all pipes used by fuse_buf_copy(). Is it necessary to leave the code related to splice(2)? Is it going to be used in future? We have to use splice(2) by the correct CONFIG_SPLICE macro If necessary. Best Regards, Xiao Yang

Re: [PATCH 105/104] virtiofsd: Unref old/new inodes with the same mutex lock in lo_rename()

2020-01-19 Thread Xiao Yang
f_inode(lo, newinode, 1); +pthread_mutex_unlock(&lo->mutex); Hi, It seems to avoid calling pthread_mutex_lock and pthread_mutex_unlock twice. Does the change fix some issues or improve the performance? Best Regards, Xiao Yang lo_inode_put(lo,&oldinode); lo_inode_put(lo

Re: [PATCH 040/104] virtiofsd: Pass write iov's all the way through

2020-01-19 Thread Xiao Yang
void *opaque) elem = NULL; } } +out: pthread_mutex_destroy(&ch.lock); free(fbuf.mem); Hi, Tested the patch and got the correct data written by guest, so it looks fine to me. Reviewed-by: Xiao Yang Best Regards, Xiao Yang