Re: [Qemu-devel] [PATCH v4 1/3] qmp: fix object-add assert() without props

2016-10-09 Thread Xiao Long Jiang
On 2016/9/29 下午11:23, Markus Armbruster wrote: Xiao Long Jiang writes: Hi, I have tested this patch on arch s390 system. It works fine. :-) May I credit your help by adding Tested-by: Xiao Long Jiang to the commit message? Just back from holiday. It would be great if you add

Re: [Qemu-devel] [PATCH v4 1/3] qmp: fix object-add assert() without props

2016-09-22 Thread Xiao Long Jiang
Hi, I have tested this patch on arch s390 system. It works fine. :-) On 2016/9/23 上午4:39, Marc-André Lureau wrote: Since commit ad739706bbadee49, user_creatable_add_type() expects to be given a qdict. However, if object-add is called without props, you reach the assert: "qemu/qom/object_interfa

Re: [Qemu-devel] [PATCH 1/1] qom: fix qdict visit in user_creatable_add_type

2016-09-22 Thread Xiao Long Jiang
Hi Markus, On 2016/9/22 下午7:56, Markus Armbruster wrote: Xiao Long Jiang writes: This fixes a Qemu crash that introduced by commit ad73970 ("qom: Wrap prop visit in visit_start_struct"). Not all of the callers of user_creatable_add_type always pass qdict, so we should check qdi

[Qemu-devel] [PATCH 1/1] qom: fix qdict visit in user_creatable_add_type

2016-09-22 Thread Xiao Long Jiang
adding an iothread with: $ virsh iothreadadd In which the is newly defined. The result of the command will return an error and cause the running guest crash. Cc: Eric Blake Cc: Markus Armbruster Signed-off-by: Xiao Long Jiang Reviewed-by: Dong Jia Shi --- qom/object_interfa