Re: [RFC PATCH v3 3/5] xen: add option to disable legacy backends

2023-11-27 Thread Woodhouse, David
On Fri, 2023-11-24 at 23:24 +, Volodymyr Babchuk wrote: > This patch makes legacy backends optional. As was discussed at [1] > this is a solution to a problem when we can't run QEMU as a device > model in a non-privileged domain. This is because legacy backends > assume that they are always run

Re: [PATCH v2 1/6] hw/xen: Set XenBackendInstance in the XenDevice before realizing it

2023-11-22 Thread Woodhouse, David
On Wed, 2023-11-22 at 23:49 +, Volodymyr Babchuk wrote: > > I can just pull it from this link, if you don't mind. Please do; thank you! smime.p7s Description: S/MIME cryptographic signature Amazon Development Centre (London) Ltd. Registered in England and Wales with registration number

Re: [PATCH v2 2/6] xen: backends: touch some XenStore nodes only if device...

2023-11-22 Thread Woodhouse, David
On Wed, 2023-11-22 at 17:03 +, Paul Durrant wrote: > > > This patch checks presence of xendev->backend to check if Xen PV > > device is acting as a backend (i.e. it was configured by Xen > > Technally *all* XenDevice objects are backends. Right. The key criterion is whether the backend was c

Re: [PATCH v2 1/6] hw/xen: Set XenBackendInstance in the XenDevice before realizing it

2023-11-22 Thread Woodhouse, David
On Wed, 2023-11-22 at 17:05 +, Paul Durrant wrote: > On 21/11/2023 22:10, Volodymyr Babchuk wrote: > > From: David Woodhouse > > > > This allows a XenDevice implementation to know whether it was created > > by QEMU, or merely discovered in XenStore after the toolstack created > > it. This wil

Re: [PATCH for-8.2 0/3] UI: fix default VC regressions

2023-11-21 Thread Woodhouse, David
On Tue, 2023-11-21 at 11:37 +0400, Marc-André Lureau wrote: > On Fri, Nov 17, 2023 at 6:36 PM wrote: > > > > From: Marc-André Lureau > > > > Hi, > > > > There are a few annoying regressions with the default VCs introduced with > > the > > pixman series. The "vl: revert behaviour for -display

Re: [PATCH-for-9.0 04/10] hw/xen: Factor xen_arch_align_ioreq_data() out of handle_ioreq()

2023-11-13 Thread Woodhouse, David
On 13 Nov 2023 10:22, Philippe Mathieu-Daudé wrote: Per commit f17068c1c7 ("xen-hvm: reorganize xen-hvm and move common function to xen-hvm-common"), handle_ioreq() is expected to be target-agnostic. However it uses 'target_ulong', which is a target specific definition. In order to compile this

[PATCH] doc/sphinx/hxtool.py: add optional label argument to SRST directive

2023-11-09 Thread Woodhouse, David
We can't just embed labels directly into files like qemu-options.hx which are included from multiple top-level RST files, because Sphinx sees the labels as duplicate: https://github.com/sphinx-doc/sphinx/issues/9707 So add an 'emitrefs' option to the Sphinx hxtool-doc directive, which is set only

Re: [PATCH v4 18/22] hmp: synchronize cpu state for lapic info

2023-10-26 Thread Woodhouse, David
> From: Dongli Zhang > > While the default "info lapic" always synchronizes cpu state ... > > mon_get_cpu() > -> mon_get_cpu_sync(mon, true) >-> cpu_synchronize_state(cpu) > -> ioctl KVM_GET_LAPIC (taking KVM as example) > > ... the cpu state is not synchronized when the apic-id is av

[PATCH] i386/xen: fix off-by-one in xen_evtchn_set_gsi()

2023-07-04 Thread Woodhouse, David
Coverity points out (CID 1508128) a bounds checking error. We need to check for gsi >= IOAPIC_NUM_PINS, not just greater-than. Also fix up an assert() that has the same problem, that Coverity didn't see. Signed-off-by: David Woodhouse --- hw/i386/kvm/xen_evtchn.c | 4 ++-- 1 file changed, 2 ins

Re: [PULL 57/62] hw/xen: Support MSI mapping to PIRQ

2023-04-06 Thread Woodhouse, David
On Thu, 2023-04-06 at 16:48 +0100, Peter Maydell wrote: > On Thu, 2 Mar 2023 at 12:37, Paolo Bonzini wrote: > > > > From: David Woodhouse > > > > The way that Xen handles MSI PIRQs is kind of awful. > > > Now that this is working we can finally enable XENFEAT_hvm_pirqs and > > let the guest us

Re: [PATCH] Fix build without CONFIG_XEN_EMU

2023-03-08 Thread Woodhouse, David
On Wed, 2023-03-08 at 08:05 -0500, mreza...@redhat.com wrote: > From: Miroslav Rezanina > > Upstream commit ddf0fd9ae1 "hw/xen: Support HVM_PARAM_CALLBACK_TYPE_GSI > callback" > added kvm_xen_maybe_deassert_callback usage to target/i386/kvm/kvm.c file > without > conditional preprocessing check

Re: [PATCH for-6.1 v2] i386: do not call cpudef-only models functions for max, host, base

2021-11-29 Thread Woodhouse, David
On Fri, 2021-07-23 at 13:29 +0200, Claudio Fontana wrote: > static void kvm_cpu_instance_init(CPUState *cs) > { > X86CPU *cpu = X86_CPU(cs); > +X86CPUClass *xcc = X86_CPU_GET_CLASS(cpu); > > host_cpu_instance_init(cpu); > > -if (!kvm_irqchip_in_kernel()) { > -x86_cpu