Re: [Qemu-devel] [RFC PATCH] linux-user: Add signal handling for x86_64

2017-02-03 Thread Wirth, Allan
Pranith, Thanks for doing this. I totally forgot about this (my work has moved elsewhere) so thank you for picking it back up. Please don’t worry about the attribution. The patch LGTM. :) Cheers, Allan On 2/3/17, 10:55 AM, "Pranith Kumar" wrote: Peter Maydell writes: > On

[Qemu-devel] [PATCH] Add signal handling support for x86_64.

2016-07-09 Thread Wirth, Allan
Note that x86_64 has only _rt signal handlers. This implementation attempts to share code with the x86_32 implementation. Reported-by: Timothy Pearson Suggested-by: Peter Maydell Signed-off-by: Allan Wirth --- linux-user/signal.c | 344 --- targ

Re: [Qemu-devel] [PATCH] linux-user: fix TARGET_NR_select

2016-07-07 Thread Wirth, Allan
Laurent, Seems to work well for my specific case – select no longer returns EFAULT on x86_64 linux user mode, and the arguments are passed correctly. Thank you! Cheers, Allan On 7/7/16, 7:17 PM, "Laurent Vivier" wrote: >TARGET_NR_select can have three different implementations: > > 1- to al

Re: [Qemu-devel] [PATCH] linux-user: fix signal() syscall on x86_64

2016-07-07 Thread Wirth, Allan
On 7/7/16, 3:09 PM, "Laurent Vivier" wrote: > > >Le 07/07/2016 à 21:04, Wirth, Allan a écrit : >> >> >> On 7/7/16, 3:02 PM, "Laurent Vivier" wrote: >> >>> >>> >>> Le 07/07/2016 à 20:49, Riku Voipio a écrit

Re: [Qemu-devel] [PATCH] linux-user: fix signal() syscall on x86_64

2016-07-07 Thread Wirth, Allan
On 7/7/16, 3:02 PM, "Laurent Vivier" wrote: > > >Le 07/07/2016 à 20:49, Riku Voipio a écrit : >> On Sat, Jul 02, 2016 at 09:12:09PM +0100, Peter Maydell wrote: >>> On 2 July 2016 at 17:41, Laurent Vivier wrote: Sadly, this can't work: sparc/sparc64/cris use sys_select for NR_sel

Re: [Qemu-devel] [PATCH] linux-user: fix signal() syscall on x86_64

2016-07-01 Thread Wirth, Allan
introduce new emulation bugs. Cheers, Allan Wirth On 7/1/16, 9:35 AM, "Peter Maydell" wrote: >On 1 July 2016 at 12:59, Wirth, Allan wrote: >> Linux on X86_64 does not use sel_arg_struct for select(), the args are >> passed directly. This patch switches a define s

[Qemu-devel] [PATCH] linux-user: fix signal() syscall on x86_64

2016-07-01 Thread Wirth, Allan
Linux on X86_64 does not use sel_arg_struct for select(), the args are passed directly. This patch switches a define so X86_64 uses the correct calling convention. Signed-off-by: Allan Wirth --- linux-user/syscall.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/linux-user/s